vf610twr: Drop unneeded 'status' variable

PATCH New Fabio Estevam 3 participants 4 messages Jun 5, 2013 – Jun 6, 2013

lore

Share & tools

lore

Fabio Estevam

author

2013-06-05 21:34 UTC #0 lore raw

PATCH v2 1/1 vf610twr: Drop unneeded 'status' variable

From: Fabio Estevam <[email protected]>

No need to use the 'status' variable, so just remove it.

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Drop status variable

 board/freescale/vf610twr/vf610twr.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

board/freescale/vf610twr/vf610twr.c +1 -4

index 04fa882..f14df8b 100644
@@ -301,16 +301,13 @@ int board_mmc_init(bd_t *bis)
 		NEW_PAD_CTRL(VF610_PAD_PTA28__ESDHC1_DAT2, ESDHC_PAD_CTRL),
 		NEW_PAD_CTRL(VF610_PAD_PTA29__ESDHC1_DAT3, ESDHC_PAD_CTRL),
 	};
-	s32 status = 0;
 
 	esdhc_cfg[0].sdhc_clk = mxc_get_clock(MXC_ESDHC_CLK);
 
 	imx_iomux_v3_setup_multiple_pads(
 		esdhc1_pads, ARRAY_SIZE(esdhc1_pads));
 
-	status |= fsl_esdhc_initialize(bis, &esdhc_cfg[0]);
-
-	return status;
+	return fsl_esdhc_initialize(bis, &esdhc_cfg[0]);
 }
 #endif

Signature · 1 line

1.8.1.2

Otavio Salvador

2013-06-05 21:43 UTC #1 lore raw

PATCH v2 1/1 vf610twr: Drop unneeded 'status' variable

Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>
No need to use the 'status' variable, so just remove it.
Signed-off-by Fabio Estevam <[email protected]>

Reviewed-by Otavio Salvador <[email protected]>

Signature · 3 lines

Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Stefano Babic

2013-06-06 07:50 UTC #2 lore raw

PATCH v2 1/1 vf610twr: Drop unneeded 'status' variable

In reply to Fabio Estevam

Quoted 24 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>
No need to use the 'status' variable, so just remove it.
Signed-off-by Fabio Estevam <[email protected]>
---
Changes since v1:
- Drop status variable
 board/freescale/vf610twr/vf610twr.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
board/freescale/vf610twr/vf610twr.c +0 -1
index 04fa882..f14df8b 100644
@@ -301,16 +301,13 @@ int board_mmc_init(bd_t *bis)
 		NEW_PAD_CTRL(VF610_PAD_PTA28__ESDHC1_DAT2, ESDHC_PAD_CTRL),
 		NEW_PAD_CTRL(VF610_PAD_PTA29__ESDHC1_DAT3, ESDHC_PAD_CTRL),
 	};
-	s32 status = 0;
 
 	esdhc_cfg[0].sdhc_clk = mxc_get_clock(MXC_ESDHC_CLK);
 

board/freescale/vf610twr/vf610twr.c int board_mmc_init(bd_t *bis) · line 313

Quoted 10 lines

board/freescale/vf610twr/vf610twr.c +1 -3

 	imx_iomux_v3_setup_multiple_pads(
 		esdhc1_pads, ARRAY_SIZE(esdhc1_pads));
 
-	status |= fsl_esdhc_initialize(bis, &esdhc_cfg[0]);
-
-	return status;
+	return fsl_esdhc_initialize(bis, &esdhc_cfg[0]);
 }
 #endif

Acked-by Stefano Babic <[email protected]>

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Stefano Babic

2013-06-06 15:53 UTC #3 lore raw

PATCH v2 1/1 vf610twr: Drop unneeded 'status' variable

Quoted 7 lines · Stefano Babic

Quoted 6 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
No need to use the 'status' variable, so just remove it.
Signed-off-by Fabio Estevam <[email protected]>
---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================