classes/qmake_base: allow parallel make

PATCH In review Jonathan Liu 2 participants 3 messages Jun 6, 2013

lore

Share & tools

lore

Jonathan Liu

author

2013-06-06 03:51 UTC #0 lore raw

PATCH 1/1 classes/qmake_base: allow parallel make

Remove MAKEFLAGS= from EXTRA_OEMAKE to allow parallel make.

Signed-off-by Jonathan Liu <[email protected]>

---
 meta/classes/qmake_base.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

meta/classes/qmake_base.bbclass +1 -1

index 52e7fb0..3762887 100644
@@ -4,7 +4,7 @@ OE_QMAKE_PLATFORM = "${TARGET_OS}-oe-g++"
 QMAKESPEC := "${QMAKE_MKSPEC_PATH}/${OE_QMAKE_PLATFORM}"
 
 # We override this completely to eliminate the -e normally passed in
-EXTRA_OEMAKE = ' MAKEFLAGS= '
+EXTRA_OEMAKE = ""
 
 export OE_QMAKE_CC="${CC}"
 export OE_QMAKE_CFLAGS="${CFLAGS}"

Signature · 1 line

1.8.2.3

Saul Wold

2013-06-06 05:02 UTC #1 lore raw

Quoted 12 lines · Jonathan Liu

Remove MAKEFLAGS= from EXTRA_OEMAKE to allow parallel make.
Signed-off-by Jonathan Liu <[email protected]>
---
  meta/classes/qmake_base.bbclass | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/qmake_base.bbclass +0 -0
index 52e7fb0..3762887 100644

meta/classes/qmake_base.bbclass OE_QMAKE_PLATFORM = "${TARGET_OS}-oe-g++" · line 8

Quoted 6 lines

meta/classes/qmake_base.bbclass +1 -1

@@ -4,7 +4,7 @@ OE_QMAKE_PLATFORM = "${TARGET_OS}-oe-g++"
  QMAKESPEC := "${QMAKE_MKSPEC_PATH}/${OE_QMAKE_PLATFORM}"
 
  # We override this completely to eliminate the -e normally passed in
-EXTRA_OEMAKE = ' MAKEFLAGS= '
+EXTRA_OEMAKE = ""

I don't think this is correct, have you checked the run.do_compile script?

It shows

        make -j 16  MAKEFLAGS=  "$@" || die "oe_runmake failed"

Which means the parallel make info is being passed correctly.

Sau!

Quoted 3 lines

meta/classes/qmake_base.bbclass +0 -0
  export OE_QMAKE_CC="${CC}"
  export OE_QMAKE_CFLAGS="${CFLAGS}"

Jonathan Liu

author

2013-06-06 05:08 UTC #2 lore raw

Quoted 23 lines · Saul Wold

Quoted 14 lines · Jonathan Liu
Remove MAKEFLAGS= from EXTRA_OEMAKE to allow parallel make.
Signed-off-by Jonathan Liu <[email protected]>
---
  meta/classes/qmake_base.bbclass | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/qmake_base.bbclass +0 -0
index 52e7fb0..3762887 100644
meta/classes/qmake_base.bbclass OE_QMAKE_PLATFORM = "${TARGET_OS}-oe-g++" · line 8
Quoted 6 lines
meta/classes/qmake_base.bbclass +1 -1
@@ -4,7 +4,7 @@ OE_QMAKE_PLATFORM = "${TARGET_OS}-oe-g++"
  QMAKESPEC := "${QMAKE_MKSPEC_PATH}/${OE_QMAKE_PLATFORM}"
 
  # We override this completely to eliminate the -e normally passed in
-EXTRA_OEMAKE = ' MAKEFLAGS= '
+EXTRA_OEMAKE = ""
 
I don't think this is correct, have you checked the run.do_compile script?

Quoted 6 lines

It shows
        make -j 16  MAKEFLAGS=  "$@" || die "oe_runmake failed"
Which means the parallel make info is being passed correctly.
Sau!

MAKEFLAGS= cancels out the -j 16.

Regards,
Jonathan

Quoted 7 lines

Quoted 6 lines
meta/classes/qmake_base.bbclass +0 -0
  export OE_QMAKE_CC="${CC}"
  export OE_QMAKE_CFLAGS="${CFLAGS}"