Skip to contentSkip to conversation

mx28evk: Convert to PHYLIB

PATCH New Fabio Estevam 3 participants 11 messages Jun 7, 2013 – Aug 19, 2013

Subsystems (2)
Network drivers Ethernet PHY
lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/2 mx28evk: Convert to PHYLIB

From: Fabio Estevam <[email protected]>

Phylib framework is more appropriate for handling the PHYs, so let's use it on mx28evk.

Signed-off-by Fabio Estevam <[email protected]>
---
 board/freescale/mx28evk/mx28evk.c | 7 +++++++
 include/configs/mx28evk.h         | 2 ++
 2 files changed, 9 insertions(+)
board/freescale/mx28evk/mx28evk.c +7 -0
index 4edd9f4..fc204fc 100644
@@ -105,6 +105,13 @@ int board_mmc_init(bd_t *bis)
 #endif
 
 #ifdef	CONFIG_CMD_NET
+int board_phy_config(struct phy_device *phydev)
+{
+	if (phydev->drv->config)
+		phydev->drv->config(phydev);
+
+	return 0;
+}
 
 int board_eth_init(bd_t *bis)
 {
include/configs/mx28evk.h +2 -0
index de69182..a3e2c0e 100644
@@ -176,6 +176,8 @@
 #define CONFIG_MII
 #define CONFIG_FEC_XCV_TYPE	RMII
 #define CONFIG_MX28_FEC_MAC_IN_OCOTP
+#define CONFIG_PHYLIB
+#define CONFIG_PHY_SMSC
 #endif
 
 /* RTC */
Signature · 1 line
1.8.1.2
author
#1 lore raw

PATCH 1/2 mx28evk: Convert to PHYLIB

Hi Stefano,

Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Phylib framework is more appropriate for handling the PHYs, so let's use it on mx28evk.

Signed-off-by Fabio Estevam <[email protected]>

Please discard this one for now.

I found an issue with this one.

#2 lore raw

PATCH 1/2 mx28evk: Convert to PHYLIB

Quoted 5 lines · Fabio Estevam

Hi Stefano,

Quoted 2 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Quoted 9 lines
Quoted 4 lines

Phylib framework is more appropriate for handling the PHYs, so let's use it on mx28evk.

Signed-off-by Fabio Estevam <[email protected]>

Please discard this one for now.

I found an issue with this one.

Ok, thanks.

Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
author
#3 lore raw

PATCH 2/2 phy: smsc: LAN8710/8720 are not Gbit PHYs

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

LAN8710/8720 are 10/100 Mbps PHYs, so fix the '.features' field.

Cc Joe Hershberger <[email protected]>
Cc Nobuhiro Iwamatsu <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/net/phy/smsc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/phy/smsc.c +1 -1
index 6dee8eb..0c658f4 100644
@@ -76,7 +76,7 @@ static struct phy_driver lan8710_driver = {
 	.name = "SMSC LAN8710/LAN8720",
 	.uid = 0x0007c0f0,
 	.mask = 0xffff0,
-	.features = PHY_GBIT_FEATURES,
+	.features = PHY_BASIC_FEATURES,
 	.config = &genphy_config_aneg,
 	.startup = &smsc_startup,
 	.shutdown = &genphy_shutdown,
Signature · 1 line
1.8.1.2
#5 lore raw

PATCH 2/2 phy: smsc: LAN8710/8720 are not Gbit PHYs

Quoted 5 lines · Fabio Estevam

Hi Joe,

Quoted 2 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Quoted 7 lines
Quoted 5 lines

LAN8710/8720 are 10/100 Mbps PHYs, so fix the '.features' field.

Cc Joe Hershberger <[email protected]>
Cc Nobuhiro Iwamatsu <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>

Any comments?

Seems pretty reasonable. I'll pick it up for next release.

-Joe

#6 lore raw

PATCH 2/2 phy: smsc: LAN8710/8720 are not Gbit PHYs

Quoted 8 lines · Joe Hershberger
Quoted 7 lines · Fabio Estevam

Hi Joe,

Quoted 4 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

LAN8710/8720 are 10/100 Mbps PHYs, so fix the '.features' field.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Cc Joe Hershberger <[email protected]>
Cc Nobuhiro Iwamatsu <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>

Any comments?

Seems pretty reasonable. I'll pick it up for next release.

On second thought, it's delegated in patchwork to Stefano and it's marked rejected. Why is that Stefano?

-Joe

author
#7 lore raw

PATCH 2/2 phy: smsc: LAN8710/8720 are not Gbit PHYs

Quoted 2 lines · Joe Hershberger

On second thought, it's delegated in patchwork to Stefano and it's marked rejected. Why is that Stefano?

Ok, I think I understand the reason. I asked him to reject the 1/2 patch of the series (it was a mx28evk related patch).

This one (2/2) is fine.

Sorry for the confusion.

#8 lore raw

PATCH 2/2 phy: smsc: LAN8710/8720 are not Gbit PHYs

Quoted 6 lines · Fabio Estevam
Quoted 2 lines · Joe Hershberger

On second thought, it's delegated in patchwork to Stefano and it's marked rejected. Why is that Stefano?

Quoted 6 lines

Ok, I think I understand the reason. I asked him to reject the 1/2 patch of the series (it was a mx28evk related patch).

This one (2/2) is fine.

Sorry for the confusion.

OK. That sounds fine.

-Joe

#9 lore raw

PATCH 2/2 phy: smsc: LAN8710/8720 are not Gbit PHYs

In reply to Fabio Estevam
Quoted 6 lines · Fabio Estevam
Quoted 2 lines · Joe Hershberger

On second thought, it's delegated in patchwork to Stefano and it's marked rejected. Why is that Stefano?

Quoted 6 lines

Ok, I think I understand the reason. I asked him to reject the 1/2 patch of the series (it was a mx28evk related patch).

This one (2/2) is fine.

Sorry for the confusion.

Yes, I confirm this - I rejected on Fabio's request.

Regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================