Skip to contentSkip to conversation

ARM: dts: i.MX27: Add DMA devicetree node

PATCH New Alexander Shiyan 3 participants 10 messages Jun 8, 2013 – Jun 9, 2013

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Alexander Shiyan

author
#0 lore raw

PATCH 1/5 ARM: dts: i.MX27: Add DMA devicetree node

This patch adds the missing DMA devicetree node for i.MX27 SoCs.

Signed-off-by Alexander Shiyan <[email protected]>
---
 arch/arm/boot/dts/imx27.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)
arch/arm/boot/dts/imx27.dtsi +10 -0
index 7017bfe..9d65734 100644
@@ -61,6 +61,16 @@
 			reg = <0x10000000 0x20000>;
 			ranges;
 
+			dma: dma at 10001000 {
+				compatible = "fsl,imx27-dma";
+				reg = <0x10001000 0x1000>;
+				interrupts = <32>;
+				clocks = <&clks 50>, <&clks 70>;
+				clock-names = "ipg", "ahb";
+				#dma-cells = <1>;
+				#dma-channels = <16>;
+			};
+
 			wdog: wdog at 10002000 {
 				compatible = "fsl,imx27-wdt", "fsl,imx21-wdt";
 				reg = <0x10002000 0x1000>;
Signature · 1 line
1.8.1.5
author
#1 lore raw

PATCH 2/5 ARM: dts: i.MX27: Add SDHC devicetree nodes

This patch adds the missing SDHC devicetree nodes for i.MX27 SoCs.

Signed-off-by Alexander Shiyan <[email protected]>
---
 arch/arm/boot/dts/imx27.dtsi | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)
arch/arm/boot/dts/imx27.dtsi +33 -0
index 9d65734..587f10c 100644
@@ -178,6 +178,28 @@
 				status = "disabled";
 			};
 
+			sdhci1: sdhci at 10013000 {
+				compatible = "fsl,imx27-mmc", "fsl,imx21-mmc";
+				reg = <0x10013000 0x1000>;
+				interrupts = <11>;
+				clocks = <&clks 30>, <&clks 60>;
+				clock-names = "ipg", "per";
+				dmas = <&dma 7>;
+				dma-names = "rx-tx";
+				status = "disabled";
+			};
+
+			sdhci2: sdhci at 10014000 {
+				compatible = "fsl,imx27-mmc", "fsl,imx21-mmc";
+				reg = <0x10014000 0x1000>;
+				interrupts = <10>;
+				clocks = <&clks 29>, <&clks 60>;
+				clock-names = "ipg", "per";
+				dmas = <&dma 6>;
+				dma-names = "rx-tx";
+				status = "disabled";
+			};
+
 			gpio1: gpio at 10015000 {
 				compatible = "fsl,imx27-gpio", "fsl,imx21-gpio";
 				reg = <0x10015000 0x100>;

@@ -293,6 +315,17 @@
 				status = "disabled";
 			};
 
+			sdhci3: sdhci at 1001e000 {
+				compatible = "fsl,imx27-mmc", "fsl,imx21-mmc";
+				reg = <0x1001e000 0x1000>;
+				interrupts = <9>;
+				clocks = <&clks 28>, <&clks 60>;
+				clock-names = "ipg", "per";
+				dmas = <&dma 36>;
+				dma-names = "rx-tx";
+				status = "disabled";
+			};
+
 			gpt6: timer at 1001f000 {
 				compatible = "fsl,imx27-gpt", "fsl,imx1-gpt";
 				reg = <0x1001f000 0x1000>;
Signature · 1 line
1.8.1.5
author
#2 lore raw

PATCH 3/5 ARM: dts: imx27-phytec-phycore-rdk: Add SDHC support

In reply to Alexander Shiyan

This patch adds the SHDC devicetree node for PCM970 board.

Signed-off-by Alexander Shiyan <[email protected]>
---
 arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts +8 -0
index f8a7a49..e7ed978 100644
@@ -19,6 +19,14 @@
 	cs-gpios = <&gpio4 28 0>, <&gpio4 27 0>;
 };
 
+&sdhci2 {
+	bus-width = <4>;
+	cd-gpios = <&gpio3 29 0>;
+	wp-gpios = <&gpio3 28 0>;
+	vmmc-supply = <&vmmc1_reg>;
+	status = "okay";
+};
+
 &uart1 {
 	fsl,uart-has-rtscts;
 };
Signature · 1 line
1.8.1.5
author
#3 lore raw

PATCH 4/5 ARM: dts: imx27-phytec-phycore-rdk: Add spidev node

In reply to Alexander Shiyan

This patch adds spidev device for spi0.1 which is used on ZigBee PCM970 connector. This change will help to use this connector in userspace.

Signed-off-by Alexander Shiyan <[email protected]>
---
 arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts +6 -0
index e7ed978..b2dbcdd 100644
@@ -17,6 +17,12 @@
 &cspi1 {
 	fsl,spi-num-chipselects = <2>;
 	cs-gpios = <&gpio4 28 0>, <&gpio4 27 0>;
+
+	zigbee: spidev at 1 {
+		compatible = "rohm,dh2228fv";
+		reg = <1>;
+		spi-max-frequency = <0>;
+	};
 };
 
 &sdhci2 {
Signature · 1 line
1.8.1.5
maintainer
#4 lore raw

PATCH 4/5 ARM: dts: imx27-phytec-phycore-rdk: Add spidev node

Quoted 14 lines · Alexander Shiyan

This patch adds spidev device for spi0.1 which is used on ZigBee PCM970 connector. This change will help to use this connector in userspace.

Signed-off-by Alexander Shiyan <[email protected]>
---
 arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts +0 -0
index e7ed978..b2dbcdd 100644

arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts line 24

Quoted 8 lines
arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts +5 -0
@@ -17,6 +17,12 @@
 &cspi1 {
 	fsl,spi-num-chipselects = <2>;
 	cs-gpios = <&gpio4 28 0>, <&gpio4 27 0>;
+
+	zigbee: spidev at 1 {
+		compatible = "rohm,dh2228fv";
+		reg = <1>;
+		spi-max-frequency = <0>;

Why specify a speed of 0 here? Also, is there really a dh2228fv connected or is this just a hack to let the Linux spidev driver match?

Sascha

Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
author
#5 lore raw

Re[2]: [PATCH 4/5] ARM: dts: imx27-phytec-phycore-rdk: Add spidev node

Quoted 10 lines · Alexander Shiyan
Quoted 9 lines

This patch adds spidev device for spi0.1 which is used on ZigBee PCM970 connector. This change will help to use this connector in userspace.

Signed-off-by Alexander Shiyan <[email protected]>
---
 arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts | 6 ++++++
 1 file changed, 6 insertions(+)
Quoted 16 lines

arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts line 24

Quoted 13 lines
arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts +5 -0
index e7ed978..b2dbcdd 100644
@@ -17,6 +17,12 @@
 &cspi1 {
 	fsl,spi-num-chipselects = <2>;
 	cs-gpios = <&gpio4 28 0>, <&gpio4 27 0>;
+
+	zigbee: spidev at 1 {
+		compatible = "rohm,dh2228fv";
+		reg = <1>;
+		spi-max-frequency = <0>;

Why specify a speed of 0 here? Also, is there really a dh2228fv connected or is this just a hack to let the Linux spidev driver match?

Zero in this case is indicates using SPI-controller maximum speed. This can be overriden by using SPI_IOC_RD_MAX_SPEED_HZ IOCTL for spidev device.
About using dh2228fv, of course no. Currently this is only one dt entry for spidev exist, so yes, this a trick.

---

maintainer
#6 lore raw

PATCH 4/5 ARM: dts: imx27-phytec-phycore-rdk: Add spidev node

Quoted 27 lines · Alexander Shiyan
Quoted 10 lines · Alexander Shiyan
Quoted 9 lines

This patch adds spidev device for spi0.1 which is used on ZigBee PCM970 connector. This change will help to use this connector in userspace.

Signed-off-by Alexander Shiyan <[email protected]>
---
 arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts | 6 ++++++
 1 file changed, 6 insertions(+)
Quoted 16 lines

arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts line 24

Quoted 13 lines
arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts +5 -0
index e7ed978..b2dbcdd 100644
@@ -17,6 +17,12 @@
 &cspi1 {
 	fsl,spi-num-chipselects = <2>;
 	cs-gpios = <&gpio4 28 0>, <&gpio4 27 0>;
+
+	zigbee: spidev at 1 {
+		compatible = "rohm,dh2228fv";
+		reg = <1>;
+		spi-max-frequency = <0>;

Why specify a speed of 0 here? Also, is there really a dh2228fv connected or is this just a hack to let the Linux spidev driver match?

Quoted 5 lines

Zero in this case is indicates using SPI-controller maximum speed. This can be overriden by using SPI_IOC_RD_MAX_SPEED_HZ IOCTL for spidev device.
About using dh2228fv, of course no. Currently this is only one dt entry for spidev exist, so yes, this a trick.

Then you should convince the spidev maintainers that whatever really is connected there should be added to the spidev compatible list. Just using an arbitrary binding only because the kernel happens to do the right thing at the moment is not an option.

Sascha

Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
author
#7 lore raw

PATCH 5/5 ARM: dts: imx27-phytec-phycore-rdk: Add MTD name for NOR flash

In reply to Alexander Shiyan

This patch adds name for NOR flash. This keeps compatibility for commandline partitions parsing from old bootloaders and make name of device same for DT and non-DT boot.

Signed-off-by Alexander Shiyan <[email protected]>
---
 arch/arm/boot/dts/imx27-phytec-phycore-som.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/imx27-phytec-phycore-som.dts +1 -0
index 73f4b28..f010565 100644
@@ -57,6 +57,7 @@
 		compatible = "cfi-flash";
 		bank-width = <2>;
 		reg = <0xc0000000 0x02000000>;
+		linux,mtd-name = "physmap-flash.0";
 		#address-cells = <1>;
 		#size-cells = <1>;
 	};
Signature · 1 line
1.8.1.5
maintainer
#8 lore raw

PATCH 1/5 ARM: dts: i.MX27: Add DMA devicetree node

In reply to Alexander Shiyan
Quoted 3 lines · Alexander Shiyan

This patch adds the missing DMA devicetree node for i.MX27 SoCs.

Signed-off-by Alexander Shiyan <[email protected]>

For patches 1-3 and 5:

Acked-by Sascha Hauer <[email protected]>

Sascha

Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |