is it time to split up the MAINTAINERS file?
Quite possibly the answer is "no", but the MAINTAINERS file is approaching 10,000 lines. Getting a bit unwieldy.
Most of the entries look like:
ARM/SAMSUNG MOBILE MACHINE SUPPORT
M: Kyungmin Park <[email protected]> L: [email protected] (moderated for non-subscribers) S: Maintained F: arch/arm/mach-s5pv210/mach-aquila.c F: arch/arm/mach-s5pv210/mach-goni.c F: arch/arm/mach-exynos/mach-universal_c210.c F: arch/arm/mach-exynos/mach-nuri.c
Which could be moved to an arch/arm/MAINTAINERS file, and the relevant paths trimmed.
The question is: would this be an improvement? (And worth the changes to checkpatch.pl and such required to make it work?)
One potential _advantage_ of this is we could make the reporting hierarchy more explicit. The first entry in arch/arm/MAINTAINERS would be the arm maintainer and everybody else _under_ there goes through him. (Also, that guy could handle updates to the local MAINTAINERS file itself, so we're not always spamming Andrew. Such updates could even post to the architecture-specific list rather than linux-kernel.)
Yeah, reality isn't neatly nested. Lots of things refer to include files and Documentation files, but there's generally a main area of focus (where's the actual _code_?), and when you do have something like:
ARM/SHMOBILE ARM ARCHITECTURE
M: Simon Horman <[email protected]> M: Magnus Damm <[email protected]> L: [email protected] W: http://oss.renesas.com Q: http://patchwork.kernel.org/project/linux-sh/list/ T: git git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git next S: Supported F: arch/arm/mach-shmobile/ F: drivers/sh/
You could either have the same entry in more than one MAINTAINERS file or keep it at a higher level. (This wouldn't eliminate the top level MAINTAINERS, merely trim it down a bit.)
Just throwing it out there. Seems like it might be a thing, someday anyway...
Rob
Quoted 2 lines · Rob Landley
Quite possibly the answer is "no", but the
MAINTAINERSfile is approaching 10,000 lines. Getting a bit unwieldy.
I think it hasn't been much of a bottleneck problem.
Quoted 2 lines
The question is: would this be an improvement? (And worth the changes to checkpatch.pl and such required to make it work?)
shrug.
MAINTAINERS is still the most frequently updated file. This division eliminates those changes.
Quoted 6 lines
One potential _advantage_ of this is we could make the reporting hierarchy more explicit. The first entry in
arch/arm/MAINTAINERSwould be the arm maintainer and everybody else _under_ there goes through him. (Also, that guy could handle updates to the localMAINTAINERSfile itself, so we're not always spamming Andrew. Such updates could even post to the architecture-specific list rather than linux-kernel.)
MAINTAINERS updates aren't centralized.
There are lots of MAINTAINERS updates from sub-maintainers.
Quoted 16 lines
Yeah, reality isn't neatly nested. Lots of things refer to include files and Documentation files, but there's generally a main area of focus (where's the actual _code_?), and when you do have something like:
ARM/SHMOBILE ARM ARCHITECTURE
M: Simon Horman <[email protected]> M: Magnus Damm <[email protected]> L: [email protected] W: http://oss.renesas.com Q: http://patchwork.kernel.org/project/linux-sh/list/ T: git git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git next S: Supported F: arch/arm/mach-shmobile/ F: drivers/sh/
Quoted 6 lines
You could either have the same entry in more than one
MAINTAINERSfile or keep it at a higher level. (This wouldn't eliminate the top levelMAINTAINERS, merely trim it down a bit.)Just throwing it out there. Seems like it might be a thing, someday anyway...
Patches talk...
Sprinkling a few hundred MAINTAINER styles files around the tree would be the biggest negative.
But paths and files could be relative and absolute
F: ./ (everything at this directory and lower)
F: ./foo.c (single file)
F: Documentation/foo.txt (absolute single file)
or add an initial / for the absolutes
F: */ (everything at this directory and lower)
F: foo.c (single file)
F: /Documentation/foo.txt (absolute single file)
make could be taught to create an overall integrated MAINTAINERS, which would not be part of the files managed by git/cvs from these submaintainer files.
Still, I think the "best" approach would be to enhance git to manage this additional information instead.
Something akin to:
https://lkml.org/lkml/2007/8/14/256
Maybe some standardization of "git notes" or "git annotate" might work.
A script could be written to create something like the existing MAINTAINERS file from that too.
Quoted 10 lines · Joe Perches
Quoted 1 line · Rob Landley
You could either have the same entry in more than one
MAINTAINERSfile
Quoted 5 lines
or keep it at a higher level. (This wouldn't eliminate the top level
MAINTAINERS, merely trim it down a bit.)Just throwing it out there. Seems like it might be a thing, someday anyway...
Patches talk...
So you suggest sending a patch series to break out arch directories and go "here, a whole new task for you the architecture maintainer to take on!" and that's the _polite_ way to ask whether or not it's a good idea?
Quoted 5 lines
or add an initial / for the absolutes
F: */ (everything at this directory and lower)
F:foo.c(single file)
F: /Documentation/foo.txt (absolute single file)
That one, obviously. (Optimize for the common case.)
Quoted 3 lines
make could be taught to create an overall integrated
MAINTAINERS, which would not be part of the files managed by git/cvs from these submaintainer files.
Why? (What's the point? Does it make finding who is in charge of $THING easier?)
Quoted 2 lines
Still, I think the "best" approach would be to enhance git to manage this additional information instead.
Oh please no.
Quoted 2 lines
Something akin to:
https://lkml.org/lkml/2007/8/14/256
I'm sorry I brought it up.
Quoted 2 lines
Maybe some standardization of "git notes" or "git annotate" might work.
The horror! The horror!
Quoted 2 lines
A script could be written to create something like the existing
MAINTAINERSfile from that too.
I won't mention it again.
*shudder*
Rob
Quoted 7 lines · Rob Landley
Quoted 6 lines · Joe Perches
Quoted 1 line · Rob Landley
You could either have the same entry in more than one
MAINTAINERSfile
Quoted 3 lines
or keep it at a higher level. (This wouldn't eliminate the top level
MAINTAINERS, merely trim it down a bit.)
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Just throwing it out there. Seems like it might be a thing, someday anyway...
Patches talk...
So you suggest sending a patch series to break out arch directories and go "here, a whole new task for you the architecture maintainer to take on!" and that's the _polite_ way to ask whether or not it's a good idea?
I replied with suggestions, but I'm not about to bother with implementations.
Throwing it out there without doing the work to implement it doesn't generally inspire others to do very much about it.
It's your itch, scratch away.
Quoted 7 lines
Quoted 5 lines
or add an initial / for the absolutes
F: */ (everything at this directory and lower)
F:foo.c(single file)
F: /Documentation/foo.txt (absolute single file)That one, obviously. (Optimize for the common case.)
Not really as get_maintainers or another tool would have to snarf all these files together before searching once or every time it was run.
Quoted 6 lines
Quoted 3 lines
make could be taught to create an overall integrated
MAINTAINERS, which would not be part of the files managed by git/cvs from these submaintainer files.Why? (What's the point? Does it make finding who is in charge of $THING easier?)
To make it easier for those that don't use git to find maintainers and lists to send bug reports and patches.
Quoted 7 lines
Quoted 2 lines
Still, I think the "best" approach would be to enhance git to manage this additional information instead.
Oh please no.
Quoted 2 lines
Something akin to:
https://lkml.org/lkml/2007/8/14/256I'm sorry I brought it up.
<smile> What makes it horrific?
I think it'd be useful for more than lkml.