drm/edid: Don't print messages regarding stereo or csync by default
Subsystems (2)
PATCH 1/1 drm/edid: Don't print messages regarding stereo or csync by default
drm_mode_detailed() is called quite often, therefore when a monitor that has a detailed timing mode marked DRM_EDID_PT_STEREO or requiring composite sync, warning messages will clutter up the kernel log. Like we already do for incorrect hsync/vsync pluse widths, print these messages only when KMS debugging is enabled.
--- drivers/gpu/drm/drm_edid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_edid.c +2 -2
@@ -1706,11 +1706,11 @@ static struct drm_display_mode *drm_mode_detailed(struct drm_device *dev,return NULL ;if (pt->misc &DRM_EDID_PT_STEREO ) { -printk (KERN_WARNING "stereo mode not supported\n" ); +DRM_DEBUG_KMS ("stereo mode not supported\n" );return NULL ; }if (!(pt->misc &DRM_EDID_PT_SEPARATE_SYNC )) { -printk (KERN_WARNING "composite sync not supported\n" ); +DRM_DEBUG_KMS ("composite sync not supported\n" ); }/* it is incorrect if hsync/vsync width is zero */
Signature · 1 line
1.8.1.4
Quoted 5 lines · Egbert Eich
drm_mode_detailed()is called quite often, therefore when a monitor that has a detailed timing mode markedDRM_EDID_PT_STEREOor requiring composite sync, warning messages will clutter up the kernel log. Like we already do for incorrect hsync/vsync pluse widths, print these messages only when KMS debugging is enabled.
Oof, yes, a thousand times yes, how were we still doing this.
- ajax
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel