Skip to contentSkip to conversation

arm: move HAVE_ARM_ARCH_TIMER selects into multi_v7 platforms

PATCH New Mark Rutland 3 participants 6 messages Jun 17, 2013

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

cover arm: move HAVE_ARM_ARCH_TIMER selects into multi_v7 platforms

The multi_v7_defconfig used to select ARM_ARCH_TIMER, but was broken by 8a4da6e36c: "arm: arch_timer: move core to drivers/clocksource". Since then some platforms haven't been getting the architected timer support they want when building from a multi_v7_defconfig.

As not all platforms require architected timer support, rather than selecting it in the multi_v7_defconfig, this patch adds selects to the platforms requiring support.

Thanks,
Mark.

Mark Rutland (2):
arm: vexpress: select HAVE_ARM_ARCH_TIMER
arm: highbank: select HAVE_ARM_ARCH_TIMER

 arch/arm/mach-highbank/Kconfig | 1 +
 arch/arm/mach-vexpress/Kconfig | 1 +
 2 files changed, 2 insertions(+)
Signature · 1 line
1.8.1.1
#1 lore raw

PATCH 1/2 arm: vexpress: select HAVE_ARM_ARCH_TIMER

When building a ARCH_MULTI_V7 kernel, support for the architected timers won't be enabled out-of-the-box even when ARCH_VEXPRESS is selected, which is unexpected and disappointing when using a coretile with architected timers.

Fix this up by having ARCH_VEXPRESS select HAVE_ARM_ARCH_TIMER.

---
 arch/arm/mach-vexpress/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-vexpress/Kconfig +1 -0
index 5907e10..e0f4974 100644
@@ -9,6 +9,7 @@ config ARCH_VEXPRESS
 	select COMMON_CLK_VERSATILE
 	select CPU_V7
 	select GENERIC_CLOCKEVENTS
+	select HAVE_ARM_ARCH_TIMER
 	select HAVE_ARM_SCU if SMP
 	select HAVE_ARM_TWD if LOCAL_TIMERS
 	select HAVE_CLK
Signature · 1 line
1.8.1.1
#2 lore raw

PATCH 1/2 arm: vexpress: select HAVE_ARM_ARCH_TIMER

Quoted 18 lines · Mark Rutland

When building a ARCH_MULTI_V7 kernel, support for the architected timers won't be enabled out-of-the-box even when ARCH_VEXPRESS is selected, which is unexpected and disappointing when using a coretile with architected timers.

Fix this up by having ARCH_VEXPRESS select HAVE_ARM_ARCH_TIMER.

---
 arch/arm/mach-vexpress/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-vexpress/Kconfig +0 -0
index 5907e10..e0f4974 100644

arch/arm/mach-vexpress/Kconfig config ARCH_VEXPRESS · line 15

Quoted 7 lines
arch/arm/mach-vexpress/Kconfig +1 -0
@@ -9,6 +9,7 @@ config ARCH_VEXPRESS
 	select COMMON_CLK_VERSATILE
 	select CPU_V7
 	select GENERIC_CLOCKEVENTS
+	select HAVE_ARM_ARCH_TIMER
 	select HAVE_ARM_SCU if SMP
 	select HAVE_ARM_TWD if LOCAL_TIMERS
 	select HAVE_CLK

Do you want me to queue it for 3.12?

Pawe?

#3 lore raw

PATCH 1/2 arm: vexpress: select HAVE_ARM_ARCH_TIMER

Quoted 29 lines · Pawel Moll
Quoted 18 lines · Mark Rutland

When building a ARCH_MULTI_V7 kernel, support for the architected timers won't be enabled out-of-the-box even when ARCH_VEXPRESS is selected, which is unexpected and disappointing when using a coretile with architected timers.

Fix this up by having ARCH_VEXPRESS select HAVE_ARM_ARCH_TIMER.

---
 arch/arm/mach-vexpress/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-vexpress/Kconfig +0 -0
index 5907e10..e0f4974 100644

arch/arm/mach-vexpress/Kconfig config ARCH_VEXPRESS · line 15

Quoted 7 lines
arch/arm/mach-vexpress/Kconfig +1 -0
@@ -9,6 +9,7 @@ config ARCH_VEXPRESS
 	select COMMON_CLK_VERSATILE
 	select CPU_V7
 	select GENERIC_CLOCKEVENTS
+	select HAVE_ARM_ARCH_TIMER
 	select HAVE_ARM_SCU if SMP
 	select HAVE_ARM_TWD if LOCAL_TIMERS
 	select HAVE_CLK
Quoted 1 line

Do you want me to queue it for 3.12?

That would be great, yes please :)

Thanks,
Mark.

#4 lore raw

PATCH 2/2 arm: highbank: select HAVE_ARM_ARCH_TIMER

In reply to Mark Rutland

The ECX-2000 has architected timers, but support for them is not selected by default.

Make MACH_HIGHBANK select HAVE_ARM_ARCH_TIMER, to ensure arhcited timer support is enabled by default.

---
 arch/arm/mach-highbank/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-highbank/Kconfig +1 -0
index cd9fcb1..2bb896f 100644
@@ -11,6 +11,7 @@ config ARCH_HIGHBANK
 	select COMMON_CLK
 	select CPU_V7
 	select GENERIC_CLOCKEVENTS
+	select HAVE_ARM_ARCH_TIMER
 	select HAVE_ARM_SCU
 	select HAVE_ARM_TWD if LOCAL_TIMERS
 	select HAVE_SMP
Signature · 1 line
1.8.1.1
#5 lore raw

PATCH 2/2 arm: highbank: select HAVE_ARM_ARCH_TIMER

Quoted 8 lines · Mark Rutland

The ECX-2000 has architected timers, but support for them is not selected by default.

Make MACH_HIGHBANK select HAVE_ARM_ARCH_TIMER, to ensure arhcited timer support is enabled by default.

Quoted 24 lines
---
 arch/arm/mach-highbank/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-highbank/Kconfig +1 -1
index cd9fcb1..2bb896f 100644
@@ -11,6 +11,7 @@ config ARCH_HIGHBANK
        select COMMON_CLK
        select CPU_V7
        select GENERIC_CLOCKEVENTS
+       select HAVE_ARM_ARCH_TIMER
        select HAVE_ARM_SCU
        select HAVE_ARM_TWD if LOCAL_TIMERS
        select HAVE_SMP
--

1.8.1.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel