gpio-langwell: remove Withney point support

PATCH In review Andy Shevchenko 5 participants 8 messages Jun 18, 2013 – Jun 21, 2013 GPIO

lore

Share & tools

lore

Andy Shevchenko

author

2013-06-18 06:43 UTC #0 lore raw

PATCH 1/1 gpio-langwell: remove Withney point support

It seems there is no user of the wp_gpio driver in the kernel. Let's remove it.

Signed-off-by Andy Shevchenko <[email protected]>

Acked-by Mika Westerberg <[email protected]>

---
 drivers/gpio/gpio-langwell.c | 69 +-------------------------------------------
 1 file changed, 1 insertion(+), 68 deletions(-)

drivers/gpio/gpio-langwell.c +1 ~~-68~~

index 2db6ef7..bfa1af1 100644
@@ -20,7 +20,6 @@
 /* Supports:
  * Moorestown platform Langwell chip.
  * Medfield platform Penwell chip.
- * Whitney point.
  */
 
 #include <linux/module.h>

@@ -390,75 +389,9 @@ static struct pci_driver lnw_gpio_driver = {
 	},
 };
 
-
-static int wp_gpio_probe(struct platform_device *pdev)
-{
-	struct lnw_gpio *lnw;
-	struct gpio_chip *gc;
-	struct resource *rc;
-	int retval;
-
-	lnw = devm_kzalloc(&pdev->dev, sizeof(struct lnw_gpio), GFP_KERNEL);
-	if (!lnw) {
-		dev_err(&pdev->dev, "can't allocate chip data\n");
-		return -ENOMEM;
-	}
-
-	rc = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	lnw->reg_base = devm_ioremap_resource(&pdev->dev, rc);
-	if (IS_ERR(lnw->reg_base))
-		return PTR_ERR(lnw->reg_base);
-
-	spin_lock_init(&lnw->lock);
-	gc = &lnw->chip;
-	gc->label = dev_name(&pdev->dev);
-	gc->owner = THIS_MODULE;
-	gc->direction_input = lnw_gpio_direction_input;
-	gc->direction_output = lnw_gpio_direction_output;
-	gc->get = lnw_gpio_get;
-	gc->set = lnw_gpio_set;
-	gc->to_irq = NULL;
-	gc->base = 0;
-	gc->ngpio = 64;
-	gc->can_sleep = 0;
-	retval = gpiochip_add(gc);
-	if (retval) {
-		dev_err(&pdev->dev, "gpiochip_add error %d\n", retval);
-		return retval;
-	}
-	platform_set_drvdata(pdev, lnw);
-	return 0;
-}
-
-static int wp_gpio_remove(struct platform_device *pdev)
-{
-	struct lnw_gpio *lnw = platform_get_drvdata(pdev);
-	int err;
-	err = gpiochip_remove(&lnw->chip);
-	if (err)
-		dev_err(&pdev->dev, "failed to remove gpio_chip.\n");
-	return 0;
-}
-
-static struct platform_driver wp_gpio_driver = {
-	.probe		= wp_gpio_probe,
-	.remove		= wp_gpio_remove,
-	.driver		= {
-		.name	= "wp_gpio",
-		.owner	= THIS_MODULE,
-	},
-};
-
 static int __init lnw_gpio_init(void)
 {
-	int ret;
-	ret =  pci_register_driver(&lnw_gpio_driver);
-	if (ret < 0)
-		return ret;
-	ret = platform_driver_register(&wp_gpio_driver);
-	if (ret < 0)
-		pci_unregister_driver(&lnw_gpio_driver);
-	return ret;
+	return pci_register_driver(&lnw_gpio_driver);
 }
 
 device_initcall(lnw_gpio_init);

Signature · 1 line

1.8.3.1

Linus Walleij

2013-06-19 19:23 UTC #1 lore raw

Quoted 4 lines · Andy Shevchenko

It seems there is no user of the wp_gpio driver in the kernel. Let's remove it.
Signed-off-by Andy Shevchenko <[email protected]>
Acked-by Mika Westerberg <[email protected]>

OK patch applied.

Please give some context though, Wikipedia says:

Whitney Point is the codename of a PCH in the Oak Trail platform chipset for Atom Lincroft microprocessors.
This has the following variations:
82SM35 (PCH SM35)

Does this mean that platform is not coming back to support Linux ever again like it was a stepping stone or something?

Yours,
Linus Walleij

Andy Shevchenko

2013-06-19 21:02 UTC #2 lore raw

Quoted 9 lines · Linus Walleij

Please give some context though, Wikipedia says:
Whitney Point is the codename of a PCH in the Oak Trail platform chipset for Atom Lincroft microprocessors.
This has the following variations:
82SM35 (PCH SM35)
Does this mean that platform is not coming back to support Linux ever again

I think it's very unluckily.
May be David could shed a light...

--
With Best Regards,
Andy Shevchenko

Linus Walleij

2013-06-20 06:46 UTC #3 lore raw

Quoted 10 lines · Andy Shevchenko

Quoted 6 lines · Linus Walleij
Please give some context though, Wikipedia says:
Whitney Point is the codename of a PCH in the Oak Trail platform chipset for Atom Lincroft microprocessors.
This has the following variations:
82SM35 (PCH SM35)

Quoted 5 lines

Quoted 2 lines
Does this mean that platform is not coming back to support Linux ever again
I think it's very unluckily.
May be David could shed a light...

Is that some kind of NACK? I will pull this patch out if it is possible that support is useful for the near future.

Yours,
Linus Walleij

Andy Shevchenko

2013-06-20 07:09 UTC #4 lore raw

Quoted 12 lines · Linus Walleij

Quoted 10 lines · Andy Shevchenko
Quoted 6 lines · Linus Walleij
Please give some context though, Wikipedia says:
Whitney Point is the codename of a PCH in the Oak Trail platform chipset for Atom Lincroft microprocessors.
This has the following variations:
82SM35 (PCH SM35)

Quoted 7 lines

Quoted 5 lines
Quoted 2 lines
Does this mean that platform is not coming back to support Linux ever again
I think it's very unluckily.
May be David could shed a light...
Is that some kind of NACK?

No, the opposite.
I meant it's very unluckily that we will have any Oak Trail user in future.

--
With Best Regards,
Andy Shevchenko

Mika Westerberg

2013-06-20 07:58 UTC #5 lore raw

Quoted 16 lines · Andy Shevchenko

Quoted 15 lines · Linus Walleij
Quoted 13 lines · Andy Shevchenko
Quoted 9 lines · Linus Walleij
Please give some context though, Wikipedia says:
Whitney Point is the codename of a PCH in the Oak Trail platform chipset for Atom Lincroft microprocessors.
This has the following variations:
82SM35 (PCH SM35)
Does this mean that platform is not coming back to support Linux ever again

Quoted 7 lines

Quoted 4 lines
Quoted 2 lines
I think it's very unluckily.
May be David could shed a light...
Is that some kind of NACK?
No, the opposite.
I meant it's very unluckily that we will have any Oak Trail user in future.

You mean *unlikely*, right?

AFAICT there are no real Oak Trail products outside Intel. It was superseded by Medfield.

Linus Walleij

2013-06-20 08:40 UTC #6 lore raw

Quoted 22 lines · Mika Westerberg

Quoted 21 lines · Andy Shevchenko
Quoted 19 lines · Linus Walleij
Quoted 10 lines · Andy Shevchenko
Quoted 6 lines · Linus Walleij
Please give some context though, Wikipedia says:
Whitney Point is the codename of a PCH in the Oak Trail platform chipset for Atom Lincroft microprocessors.
This has the following variations:
82SM35 (PCH SM35)
Quoted 5 lines
Quoted 2 lines
Does this mean that platform is not coming back to support Linux ever again
I think it's very unluckily.
May be David could shed a light...
Is that some kind of NACK?

Quoted 7 lines

Quoted 2 lines
No, the opposite.
I meant it's very unluckily that we will have any Oak Trail user in future.
You mean *unlikely*, right?
AFAICT there are no real Oak Trail products outside Intel. It was superseded by Medfield.

Only lab boards then? OK I will keep this patch around.

Yours,
Linus Walleij

David Cohen

Acked-by on v1 1/1

2013-06-21 00:45 UTC #7 lore raw

In reply to Andy Shevchenko

Hi Andy,

Quoted 1 line · Andy Shevchenko

It seems there is no user of the wp_gpio driver in the kernel. Let's remove it.

I never liked this wp code there too.

Quoted 3 lines

Signed-off-by Andy Shevchenko <[email protected]>
Acked-by Mika Westerberg <[email protected]>

Acked-by David Cohen <[email protected]>