base-files: create /usr/lib/locale dir
cover base-files: create /usr/lib/locale dir
From: "Roy.Li" <[email protected]>
The following changes since commit cf59801be372bda962a94e6a406e97d20744ae45:
licences: Add SGI license (2013-06-17 16:44:36 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib roy/base-files
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=roy/base-files
Roy.Li (1):
base-files: create /usr/lib/locale dir
meta/recipes-core/base-files/base-files_3.0.14.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
1.7.10.4
PATCH 1/1 base-files: create /usr/lib/locale dir
From: "Roy.Li" <[email protected]>
Lsbtest shows that /usr/lib/locale dir is lost, so create it
--- meta/recipes-core/base-files/base-files_3.0.14.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/base-files/base-files_3.0.14.bb +1 -1
@@ -36,7 +36,7 @@ dirs2775 = "/home ${prefix}/src ${localstatedir}/local" dirs755 = "/bin /boot /dev ${sysconfdir} ${sysconfdir}/default \ ${sysconfdir}/skel /lib /mnt /proc ${ROOT_HOME} /run /sbin \ ${prefix} ${bindir} ${docdir} /usr/games ${includedir} \ - ${libdir} ${sbindir} ${datadir} \ + ${libdir} /usr/lib/locale ${sbindir} ${datadir} \ ${datadir}/common-licenses ${datadir}/dict ${infodir} \ ${mandir} ${datadir}/misc ${localstatedir} \ ${localstatedir}/backups ${localstatedir}/lib \
Signature · 1 line
1.7.10.4
meta/recipes-core/base-files/base-files_3.0.14.bb dirs2775 = "/home ${prefix}/src ${localstatedir}/local" · line 39
Quoted 2 lines · On Tue, 2013-06-18 at 15:19 +0800, [email protected] wrote:
meta/recipes-core/base-files/base-files_3.0.14.bb +1
-1- ${libdir} ${sbindir} ${datadir} \ + ${libdir} /usr/lib/locale ${sbindir} ${datadir} \
This is bogus for a number of reasons. If the only reason for having it is for lsbtest, can't it go in some LSB recipe?
p.
Quoted 9 lines · Phil Blundell
Review
Quoted 2 lines · On Tue, 2013-06-18 at 15:19 +0800, [email protected] wrote:
(quoted diff) +1
-1- ${libdir} ${sbindir} ${datadir} \ + ${libdir} /usr/lib/locale ${sbindir} ${datadir} \This is bogus for a number of reasons. If the only reason for having it is for lsbtest, can't it go in some LSB recipe?
p.
Thanks, How about put it into do_install_append_linuxstdbase
meta/recipes-core/base-files/base-files_3.0.14.bb +1 -0
@@ -139,6 +139,7 @@ do_install_append_linuxstdbase() { for d in ${dirs4775}; do install -m 2755 -d ${D}$d done + install -m 755 -d ${D}/usr/lib/locale } PACKAGES = "${PN}-doc ${PN} ${PN}-dev ${PN}-dbg"
-Roy
Quoted 3 lines
Signature · 2 lines
Best Reagrds, Roy | RongQing Li
meta/recipes-core/base-files/base-files_3.0.14.bb do_install_append_linuxstdbase() { · line 142
Quoted 10 lines · Rongqing Li
meta/recipes-core/base-files/base-files_3.0.14.bb +1
-0@@ -139,6 +139,7 @@ do_install_append_linuxstdbase() { for d in ${dirs4775}; do install -m 2755 -d ${D}$d done + install -m 755 -d ${D}/usr/lib/locale
Thanks, that looks better. Could you not just add it to ${dirs3755} though? (Despite the confusing/misleading name, this variable appears to be a list of LSB directories that should be created with mode 0755, cf ${dirs4755} which is apparently directories to be created with mode 2755.)
In a stylistic sense it might be better to use ${prefix}/lib/locale (or whatever eglibc uses), but in practice LSB requires ${prefix}=="/usr", and presumably lsbtest is looking for "/usr/lib/locale" specifically, so I don't think it will actually make any functional difference in this specific case.
p.
Quoted 18 lines · Phil Blundell
meta/recipes-core/base-files/base-files_3.0.14.bb do_install_append_linuxstdbase() { · line 142
Quoted 10 lines · Rongqing Li
meta/recipes-core/base-files/base-files_3.0.14.bb +1
-0@@ -139,6 +139,7 @@ do_install_append_linuxstdbase() { for d in ${dirs4775}; do install -m 2755 -d ${D}$d done + install -m 755 -d ${D}/usr/lib/localeThanks, that looks better. Could you not just add it to ${dirs3755} though? (Despite the confusing/misleading name, this variable appears to be a list of LSB directories that should be created with mode 0755, cf ${dirs4755} which is apparently directories to be created with mode 2755.)
Quoted 5 lines
In a stylistic sense it might be better to use ${prefix}/lib/locale (or whatever eglibc uses), but in practice LSB requires ${prefix}=="/usr", and presumably lsbtest is looking for "
/usr/lib/locale" specifically, so I don't think it will actually make any functional difference in this specific case.
FYI, I agree ${prefix}/lib/locale is likely the correct directory to reference.
It preserves the semantics of the OE way of declaring paths, supports the move
of prefix to somewhere else, and will still work in an LSB compliant configuration.
--Mark
Quoted 8 lines
p.
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
meta/recipes-core/base-files/base-files_3.0.14.bb dirs2775 = "/home ${prefix}/src ${localstatedir}/local" · line 39
Quoted 2 lines · On Tuesday, 18 June 2013, wrote:
meta/recipes-core/base-files/base-files_3.0.14.bb +1
-1- ${libdir} ${sbindir} ${datadir} \ + ${libdir} /usr/lib/locale ${sbindir} ${datadir} \
What Phil said, but also please don't hard-code paths - the rest of the variable uses ${libdir} for a reason.
Ross
Quoted 9 lines · Ross
meta/recipes-core/base-files/base-files_3.0.14.bb dirs2775 = "/home ${prefix}/src ${localstatedir}/local" · line 39
Quoted 2 lines · On Tuesday, 18 June 2013, wrote:
meta/recipes-core/base-files/base-files_3.0.14.bb +1
-1- ${libdir} ${sbindir} ${datadir} \ + ${libdir} /usr/lib/locale ${sbindir} ${datadir} \What Phil said, but also please don't hard-code paths - the rest of the variable uses ${libdir} for a reason.
${libdir}/locale can be /usr/lib/locale, or /usr/lib64/locale,
but localedef only thinks /usr/lib/locale as its default outputpath(man localedef), can not /usr/lib64/locale, or other.
-Roy
Quoted 2 lines
Ross
Signature · 2 lines
Best Reagrds, Roy | RongQing Li