acpi-dma: fix sparse warning

PATCH In review Andy Shevchenko 2 participants 2 messages Jun 18, 2013 dmaengine

lore

Share & tools

lore

Andy Shevchenko

author

2013-06-18 14:19 UTC #0 lore raw

PATCH 1/1 acpi-dma: fix sparse warning

This patch fixes sparse warning:

	drivers/dma/acpi-dma.c:76:21: sparse: cast to restricted __le32

Since everything in all ACPI tables is little-endian, by definition, the used types in practice are uXX. Thus, we have to enforce __leXX if we want to convert them to CPU order.

Signed-off-by Andy Shevchenko <[email protected]>

---
 drivers/dma/acpi-dma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/dma/acpi-dma.c +1 -1

index 5a18f82..ba7f932 100644
@@ -73,7 +73,7 @@ static int acpi_dma_parse_resource_group(const struct acpi_csrt_group *grp,
 	if (si->mmio_base_low != mem || si->gsi_interrupt != irq)
 		return 0;
 
-	vendor_id = le32_to_cpu(grp->vendor_id);
+	vendor_id = le32_to_cpu((__force __le32)grp->vendor_id);
 	dev_dbg(&adev->dev, "matches with %.4s%04X (rev %u)\n",
 		(char *)&vendor_id, grp->device_id, grp->revision);

Signature · 1 line

1.8.3.1

Mika Westerberg

Reviewed-by on v1 1/1

2013-06-18 14:32 UTC #1 lore raw

Quoted 8 lines · Andy Shevchenko

This patch fixes sparse warning:
	drivers/dma/acpi-dma.c:76:21: sparse: cast to restricted __le32
Since everything in all ACPI tables is little-endian, by definition, the used types in practice are uXX. Thus, we have to enforce __leXX if we want to convert them to CPU order.
Signed-off-by Andy Shevchenko <[email protected]>

Even though it is ugly,

Reviewed-by Mika Westerberg <[email protected]>