Skip to contentSkip to conversation

clocksource: samsung_pwm: Correct definition of AUTORELOAD bit

PATCH New Tomasz Figa 1 participant 2 messages Jun 18, 2013 – Jun 23, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clocksource: samsung_pwm: Correct definition of AUTORELOAD bit

PWM channel 4 (logically channel 5 in TCON register) has its autoreload bit located at different position. This patch fixes the driver to account for this.

This fixes a problem with clocksource hanging after it overflows because it is not reloaded any more.

---
 drivers/clocksource/samsung_pwm_timer.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/clocksource/samsung_pwm_timer.c +2 -1
index 2977043..6af178f 100644
@@ -47,7 +47,8 @@
 #define TCON_START(chan)		(1 << (4 * (chan) + 0))
 #define TCON_MANUALUPDATE(chan)		(1 << (4 * (chan) + 1))
 #define TCON_INVERT(chan)		(1 << (4 * (chan) + 2))
-#define TCON_AUTORELOAD(chan)		(1 << (4 * (chan) + 3))
+#define TCON_AUTORELOAD(chan)		(1 << (4 * (chan) \
+						+ (((chan) < 5) ? 3 : 2)))
 
 DEFINE_SPINLOCK(samsung_pwm_lock);
 EXPORT_SYMBOL(samsung_pwm_lock);
Signature · 1 line
1.8.2.1
#1 lore raw

PATCH 1/1 clocksource: samsung_pwm: Correct definition of AUTORELOAD bit

Quoted 17 lines · On Tuesday 18 of June 2013 19:41:07 Tomasz Figa wrote:

PWM channel 4 (logically channel 5 in TCON register) has its autoreload bit located at different position. This patch fixes the driver to account for this.

This fixes a problem with clocksource hanging after it overflows because it is not reloaded any more.

---
 drivers/clocksource/samsung_pwm_timer.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/clocksource/samsung_pwm_timer.c index 2977043..6af178f 100644

drivers/clocksource/samsung_pwm_timer.c line 54

Quoted 9 lines
drivers/clocksource/samsung_pwm_timer.c +2 -1
@@ -47,7 +47,8 @@
 #define TCON_START(chan)		(1 << (4 * (chan) + 0))
 #define TCON_MANUALUPDATE(chan)		(1 << (4 * (chan) + 1))
 #define TCON_INVERT(chan)		(1 << (4 * (chan) + 2))
-#define TCON_AUTORELOAD(chan)		(1 << (4 * (chan) + 3))
+#define TCON_AUTORELOAD(chan)		(1 << (4 * (chan) \
+						+ (((chan) < 5) ? 3 : 2)))
 
 DEFINE_SPINLOCK(samsung_pwm_lock);
 EXPORT_SYMBOL(samsung_pwm_lock);

Ping.

Best regards,
Tomasz