powerpc: deleted unused symbol CONFIG_SPL_NAND_MINIMAL and enabled some functionality for common SPL
Subsystems (4)
PATCH v2 5/10 powerpc: deleted unused symbol CONFIG_SPL_NAND_MINIMAL and enabled some functionality for common SPL
From: Ying Zhang <[email protected]>
1. The symbol CONFIG_SPL_NAND_MINIMAL is unused, so deleted it.
2. Some functions were unused in the minimal SPL, but it is useful in the common SPL. So, enabled some functionality for common SPL.
---
Compared with the previous version, use !defined(CONFIG_SPL_BUILD) || !defined(CONFIG_SPL_INIT_MINIMAL) to replace to new symbols.
arch/powerpc/cpu/mpc85xx/tlb.c | 3 ++- arch/powerpc/cpu/mpc8xxx/law.c | 6 ++++-- include/configs/MPC8313ERDB.h | 1 - include/configs/P1022DS.h | 1 - include/configs/p1_p2_rdb_pc.h | 1 - 5 files changed, 6 insertions(+), 6 deletions(-)
arch/powerpc/cpu/mpc85xx/tlb.c +2 -1
@@ -55,7 +55,8 @@ void init_tlbs(void)return ; } -#if !defined(CONFIG_NAND_SPL ) && !defined(CONFIG_SPL_BUILD ) +#if !defined(CONFIG_NAND_SPL ) && \ + (!defined(CONFIG_SPL_BUILD ) || !defined(CONFIG_SPL_INIT_MINIMAL ))void read_tlbcam_entry (int idx,u32 *valid,u32 *tsize,unsigned long *epn,phys_addr_t *rpn) {
arch/powerpc/cpu/mpc8xxx/law.c +4 -2
@@ -92,7 +92,8 @@ void disable_law(u8 idx)return ; } -#if !defined(CONFIG_NAND_SPL ) && !defined(CONFIG_SPL_BUILD ) +#if !defined(CONFIG_NAND_SPL ) && \ + (!defined(CONFIG_SPL_BUILD ) || !defined(CONFIG_SPL_INIT_MINIMAL ))static int get_law_entry (u8 i,struct law_entry *e) {u32 lawar;
@@ -122,7 +123,8 @@ int set_next_law(phys_addr_t addr, enum law_size sz, enum law_trgt_if id)return idx; } -#if !defined(CONFIG_NAND_SPL ) && !defined(CONFIG_SPL_BUILD ) +#if !defined(CONFIG_NAND_SPL ) && \ + (!defined(CONFIG_SPL_BUILD ) || !defined(CONFIG_SPL_INIT_MINIMAL ))int set_last_law (phys_addr_t addr,enum law_size sz,enum law_trgt_if id) {u32 idx;
include/configs/MPC8313ERDB.h +0 -1
@@ -40,7 +40,6 @@#define CONFIG_SPL_INIT_MINIMAL #define CONFIG_SPL_SERIAL_SUPPORT #define CONFIG_SPL_NAND_SUPPORT -#define CONFIG_SPL_NAND_MINIMAL #define CONFIG_SPL_FLUSH_IMAGE #define CONFIG_SPL_TARGET "u-boot-with-spl.bin"#define CONFIG_SPL_MPC83XX_WAIT_FOR_NAND
include/configs/P1022DS.h +0 -1
@@ -41,7 +41,6 @@#define CONFIG_SPL_INIT_MINIMAL #define CONFIG_SPL_SERIAL_SUPPORT #define CONFIG_SPL_NAND_SUPPORT -#define CONFIG_SPL_NAND_MINIMAL #define CONFIG_SPL_FLUSH_IMAGE #define CONFIG_SPL_TARGET "u-boot-with-spl.bin"
include/configs/p1_p2_rdb_pc.h +0 -1
@@ -159,7 +159,6 @@#define CONFIG_SPL_INIT_MINIMAL #define CONFIG_SPL_SERIAL_SUPPORT #define CONFIG_SPL_NAND_SUPPORT -#define CONFIG_SPL_NAND_MINIMAL #define CONFIG_SPL_FLUSH_IMAGE #define CONFIG_SPL_TARGET "u-boot-with-spl.bin"
Signature · 1 line
1.7.0.4
PATCH v2 9/10 nand: tpl : introduce the TPL based on the SPL
From: Ying Zhang <[email protected]>
Due to the nand SPL on some board(e.g. P1022DS)has a size limit, it can not be more than 4K. So, the SPL cannot initialize the DDR with the SPD code. This patch introduces TPL to enable a loader stub that runs in the L2 SRAM, after being loaded by the code from the SPL. It initializes the DDR with the SPD or other operations.
The TPL's size is sizeable, the maximum size must not exceed the size of L2 SRAM. It initializes the DDR through SPD code, and copys final uboot image to DDR. So there are three stage uboot images:
* spl_boot, * tpl_boot, * final uboot image,
This patch is on top of the patch:
powerpc/p1022ds: boot from spi flash with SPL
---
Compared with the previous version, split into two separate patches. this pactch only introduce the TPL.
Makefile | 21 +++- README | 52 ++++++- arch/powerpc/config.mk | 2 + .../cpu/mpc8xxx/ddr/lc_common_dimm_params.c | 4 +- arch/powerpc/lib/Makefile | 2 + common/Makefile | 9 + common/cmd_nvedit.c | 8 +- config.mk | 32 ++++ doc/README.TPL | 69 +++++++++ drivers/mtd/nand/Makefile | 8 + drivers/mtd/nand/fsl_elbc_spl.c | 4 + drivers/serial/serial.c | 2 +- include/bootstage.h | 3 +- tpl/Makefile | 161 ++++++++++++++++++++ 14 files changed, 366 insertions(+), 11 deletions(-) create mode 100644 doc/README.TPL create mode 100644 tpl/Makefile
Makefile +20 -1
@@ -118,10 +118,11 @@ endif # ifneq ($(BUILD_DIR),) OBJTREE := $(if $(BUILD_DIR),$(BUILD_DIR),$(CURDIR)) SPLTREE := $(OBJTREE)/spl +TPLTREE := $(OBJTREE)/tpl SRCTREE := $(CURDIR) TOPDIR := $(SRCTREE) LNDIR := $(OBJTREE) -export TOPDIR SRCTREE OBJTREE SPLTREE +export TOPDIR SRCTREE OBJTREE SPLTREE TPLTREE MKCONFIG := $(SRCTREE)/mkconfig export MKCONFIG
@@ -412,6 +413,7 @@ ALL-y += $(obj)u-boot.srec $(obj)u-boot.bin $(obj)System.map ALL-$(CONFIG_NAND_U_BOOT) += $(obj)u-boot-nand.bin ALL-$(CONFIG_ONENAND_U_BOOT) += $(obj)u-boot-onenand.bin ALL-$(CONFIG_SPL) += $(obj)spl/u-boot-spl.bin +ALL-$(CONFIG_TPL) += $(obj)tpl/u-boot-tpl.bin ALL-$(CONFIG_OF_SEPARATE) += $(obj)u-boot.dtb $(obj)u-boot-dtb.bin ifneq ($(CONFIG_SPL_TARGET),) ALL-$(CONFIG_SPL) += $(obj)$(subst ",,$(CONFIG_SPL_TARGET))
@@ -498,6 +500,18 @@ $(obj)u-boot-with-spl.bin: $(obj)spl/u-boot-spl.bin $(obj)u-boot.bin cat $(obj)spl/u-boot-spl-pad.bin $(obj)u-boot.bin > $@ rm $(obj)spl/u-boot-spl-pad.bin +$(obj)u-boot-with-tpl.bin: $(obj)spl/u-boot-spl.bin $(obj)tpl/u-boot-tpl.bin \ + $(obj)u-boot.bin + $(OBJCOPY) ${OBJCFLAGS} --pad-to=$(CONFIG_SPL_PAD_TO) \ + -I binary -O binary \ + $(obj)spl/u-boot-spl.bin $(obj)spl/u-boot-spl-pad.bin + $(OBJCOPY) ${OBJCFLAGS} --pad-to=$(CONFIG_SYS_PAD_TO) \ + -I binary -O binary \ + $(obj)tpl/u-boot-tpl.bin $(obj)tpl/u-boot-tpl-pad.bin + cat $(obj)spl/u-boot-spl-pad.bin $(obj)tpl/u-boot-tpl-pad.bin \ + $(obj)u-boot.bin > $@ + rm $(obj)spl/u-boot-spl-pad.bin $(obj)tpl/u-boot-tpl-pad.bin + $(obj)u-boot-with-spl.imx: $(obj)spl/u-boot-spl.bin $(obj)u-boot.bin $(MAKE) -C $(SRCTREE)/arch/arm/imx-common \ $(OBJTREE)/u-boot-with-spl.imx
@@ -622,6 +636,9 @@ $(obj)u-boot-nand.bin: nand_spl $(obj)u-boot.bin $(obj)spl/u-boot-spl.bin: $(SUBDIR_TOOLS) depend $(MAKE) -C spl all +$(obj)tpl/u-boot-tpl.bin: $(SUBDIR_TOOLS) depend + $(MAKE) -C tpl all + updater: $(MAKE) -C tools/updater all
@@ -870,6 +887,8 @@ clobber: tidy @rm -f $(obj)nand_spl/{u-boot-nand_spl.lds,u-boot-spl,u-boot-spl.map} @rm -f $(obj)spl/{u-boot-spl,u-boot-spl.bin,u-boot-spl.map} @rm -f $(obj)spl/u-boot-spl.lds + @rm -f $(obj)tpl/{u-boot-tpl,u-boot-tpl.bin,u-boot-tpl.map} + @rm -f $(obj)tpl/u-boot-tpl.lds @rm -f $(obj)MLO MLO.byteswap @rm -f $(obj)SPL @rm -f $(obj)tools/xway-swap-bytes
README +50 -2
76 lines not on this page · raw message
arch/powerpc/config.mk +2 -0
@@ -48,5 +48,7 @@ endif # Only test once ifneq ($(CONFIG_SPL_BUILD),y) +ifneq ($(CONFIG_TPL_BUILD),y) ALL-y += checkgcc4 endif +endif
arch/powerpc/cpu/mpc8xxx/ddr/lc_common_dimm_params.c +2 -2
@@ -218,13 +218,13 @@ compute_lowest_common_dimm_parameters(const dimm_params_t *dimm_params,if (dimm_params[i].n_ranks) {if (dimm_params[i].registered_dimm) { temp1 =1 ; -#ifndef CONFIG_SPL_BUILD +#if !defined(CONFIG_SPL_BUILD ) && !defined(CONFIG_TPL_BUILD )printf ("Detected RDIMM %s\n" , dimm_params[i].mpart);#endif }else { temp2 =1 ; -#ifndef CONFIG_SPL_BUILD +#if !defined(CONFIG_SPL_BUILD ) && !defined(CONFIG_TPL_BUILD )printf ("Detected UDIMM %s\n" , dimm_params[i].mpart);#endif
arch/powerpc/lib/Makefile +2 -0
@@ -59,10 +59,12 @@ SOBJS-y += reloc.o COBJS-$(CONFIG_BAT_RW) += bat_rw.o ifndef CONFIG_SPL_BUILD +ifndef CONFIG_TPL_BUILD ifndef CONFIG_SYS_GENERIC_BOARD COBJS-y += board.o endif endif +endif COBJS-y += bootm.o COBJS-y += cache.o COBJS-y += extable.o
common/Makefile +9 -0
@@ -27,6 +27,7 @@ LIB = $(obj)libcommon.o # core ifndef CONFIG_SPL_BUILD +ifndef CONFIG_TPL_BUILD COBJS-y += main.o COBJS-y += command.o COBJS-y += exports.o
@@ -204,6 +205,7 @@ COBJS-$(CONFIG_USB_KEYBOARD) += usb_kbd.o COBJS-$(CONFIG_CMD_DFU) += cmd_dfu.o COBJS-$(CONFIG_CMD_GPT) += cmd_gpt.o endif +endif ifdef CONFIG_SPL_BUILD COBJS-$(CONFIG_ENV_IS_IN_FLASH) += env_flash.o
@@ -223,6 +225,13 @@ else COBJS-y += env_nowhere.o endif endif + +ifdef CONFIG_TPL_BUILD +COBJS-$(CONFIG_SYS_ENV_SUPPORT) += env_attr.o +COBJS-$(CONFIG_SYS_ENV_SUPPORT) += env_flags.o +COBJS-$(CONFIG_SYS_ENV_SUPPORT) += env_callback.o +endif + # core command COBJS-y += cmd_nvedit.o #environment
common/cmd_nvedit.c +4 -4
@@ -87,7 +87,7 @@ int get_env_id(void)return env_id; } -#ifndef CONFIG_SPL_BUILD +#if !defined(CONFIG_SPL_BUILD ) && !defined(CONFIG_TPL_BUILD )/* * Command interface: print one or all environment variables *
@@ -356,7 +356,7 @@ ulong getenv_hex(const char *varname, ulong default_val)return value; } -#ifndef CONFIG_SPL_BUILD +#if !defined(CONFIG_SPL_BUILD ) && !defined(CONFIG_TPL_BUILD )static int do_env_set (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[]) {if (argc <2 )
@@ -700,7 +700,7 @@ ulong getenv_ulong(const char *name, int base, ulong default_val)return str ?simple_strtoul (str,NULL , base) : default_val; } -#ifndef CONFIG_SPL_BUILD +#if !defined(CONFIG_SPL_BUILD ) && !defined(CONFIG_TPL_BUILD )#if defined(CONFIG_CMD_SAVEENV ) && !defined(CONFIG_ENV_IS_NOWHERE )static int do_env_save (cmd_tbl_t *cmdtp,int flag,int argc,char *const argv[])
@@ -741,7 +741,7 @@ int envmatch(uchar *s1, int i2)return -1 ; } -#ifndef CONFIG_SPL_BUILD +#if !defined(CONFIG_SPL_BUILD ) && !defined(CONFIG_TPL_BUILD )static int do_env_default (cmd_tbl_t *cmdtp,int __flag,int argc,char *const argv[]) {
config.mk +32 -0
@@ -41,8 +41,12 @@ ifneq ($(OBJTREE),$(SRCTREE)) ifeq ($(CONFIG_SPL_BUILD),y) obj := $(if $(dir),$(SPLTREE)/$(dir)/,$(SPLTREE)/) else +ifeq ($(CONFIG_TPL_BUILD),y) +obj := $(if $(dir),$(TPLTREE)/$(dir)/,$(TPLTREE)/) +else obj := $(if $(dir),$(OBJTREE)/$(dir)/,$(OBJTREE)/) endif +endif src := $(if $(dir),$(SRCTREE)/$(dir)/,$(SRCTREE)/) $(shell mkdir -p $(obj))
@@ -53,8 +57,14 @@ obj := $(if $(dir),$(SPLTREE)/$(dir)/,$(SPLTREE)/) $(shell mkdir -p $(obj)) else +ifeq ($(CONFIG_TPL_BUILD),y) +obj := $(if $(dir),$(TPLTREE)/$(dir)/,$(TPLTREE)/) + +$(shell mkdir -p $(obj)) +else obj := endif +endif src := endif
@@ -210,6 +220,11 @@ CPPFLAGS += -ffunction-sections -fdata-sections LDFLAGS_FINAL += --gc-sections endif +ifeq ($(CONFIG_TPL_BUILD),y) +CPPFLAGS += -ffunction-sections -fdata-sections +LDFLAGS_FINAL += --gc-sections +endif + ifneq ($(CONFIG_SYS_TEXT_BASE),) CPPFLAGS += -DCONFIG_SYS_TEXT_BASE=$(CONFIG_SYS_TEXT_BASE) endif
@@ -218,10 +233,18 @@ ifneq ($(CONFIG_SPL_TEXT_BASE),) CPPFLAGS += -DCONFIG_SPL_TEXT_BASE=$(CONFIG_SPL_TEXT_BASE) endif +ifneq ($(CONFIG_TPL_TEXT_BASE),) +CPPFLAGS += -DCONFIG_TPL_TEXT_BASE=$(CONFIG_TPL_TEXT_BASE) +endif + ifneq ($(CONFIG_SPL_PAD_TO),) CPPFLAGS += -DCONFIG_SPL_PAD_TO=$(CONFIG_SPL_PAD_TO) endif +ifneq ($(CONFIG_SYS_PAD_TO),) +CPPFLAGS += -DCONFIG_SYS_PAD_TO=$(CONFIG_SYS_PAD_TO) +endif + ifneq ($(CONFIG_UBOOT_PAD_TO),) CPPFLAGS += -DCONFIG_UBOOT_PAD_TO=$(CONFIG_UBOOT_PAD_TO) endif
@@ -230,6 +253,10 @@ ifeq ($(CONFIG_SPL_BUILD),y) CPPFLAGS += -DCONFIG_SPL_BUILD endif +ifeq ($(CONFIG_TPL_BUILD),y) +CPPFLAGS += -DCONFIG_TPL_BUILD +endif + # Does this architecture support generic board init? ifeq ($(__HAVE_ARCH_GENERIC_BOARD),) ifneq ($(CONFIG_SYS_GENERIC_BOARD),)
@@ -294,6 +321,11 @@ ifneq ($(CONFIG_SPL_TEXT_BASE),) LDFLAGS_u-boot-spl += -Ttext $(CONFIG_SPL_TEXT_BASE) endif +LDFLAGS_u-boot-tpl += -T $(obj)u-boot-spl.lds $(LDFLAGS_FINAL) +ifneq ($(CONFIG_TPL_TEXT_BASE),) +LDFLAGS_u-boot-tpl += -Ttext $(CONFIG_TPL_TEXT_BASE) +endif + # Linus' kernel sanity checking tool CHECKFLAGS := -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__ \ -Wbitwise -Wno-return-void -D__CHECK_ENDIAN__ $(CF)
doc/README.TPL new file +69 -0
69 lines not on this page · raw message
drivers/mtd/nand/Makefile +8 -0
@@ -42,6 +42,8 @@ COBJS-$(CONFIG_SPL_NAND_BASE) += nand_base.o else # not spl +ifndef CONFIG_TPL_BUILD + NORMAL_DRIVERS=y COBJS-y += nand.o
@@ -51,6 +53,7 @@ COBJS-y += nand_util.o COBJS-y += nand_ecc.o COBJS-y += nand_base.o +endif # not tpl endif # not spl ifdef NORMAL_DRIVERS
@@ -82,8 +85,13 @@ COBJS-$(CONFIG_NAND_DOCG4) += docg4.o else # minimal SPL drivers +ifdef CONFIG_SPL_BUILD COBJS-$(CONFIG_NAND_FSL_ELBC) += fsl_elbc_spl.o COBJS-$(CONFIG_NAND_MXC) += mxc_nand_spl.o +endif +ifdef CONFIG_TPL_BUILD +COBJS-$(CONFIG_NAND_FSL_ELBC) += fsl_elbc_spl.o +endif endif # drivers endif # nand
drivers/mtd/nand/fsl_elbc_spl.c +4 -0
@@ -47,7 +47,11 @@ static void nand_wait(void) } } +#ifdef CONFIG_SPL_BUILD static int nand_load_image(uint32_t offs, unsigned int uboot_size, void *vdst) +#else +int nand_load_image(uint32_t offs, unsigned int uboot_size, void *vdst) +#endif {fsl_lbc_t *regs =LBC_BASE_ADDR ;uchar *buf = (uchar *)CONFIG_SYS_NAND_BASE ;
drivers/serial/serial.c +1 -1
@@ -371,7 +371,7 @@ static struct serial_device *get_current(void)/* We must have a console device */ if (!dev) { -#ifdef CONFIG_SPL_BUILD +#if defined(CONFIG_SPL_BUILD ) || defined(CONFIG_TPL_BUILD )puts ("Cannot find console\n" );hang ();#else
include/bootstage.h +2 -1
@@ -220,7 +220,8 @@ enum bootstage_id {*/ ulong timer_get_boot_us (void ); -#if !defined(CONFIG_SPL_BUILD ) && !defined(USE_HOSTCC ) +#if !defined(CONFIG_SPL_BUILD ) && !defined(CONFIG_TPL_BUILD ) && \ + !defined(USE_HOSTCC )/* * Board code can implement show_boot_progress() if needed. *
tpl/Makefile new file +161 -0
161 lines not on this page · raw message
Signature · 1 line
1.7.0.4
PATCH 10/10 powerpc: p1022ds: support TPL on the P1022DS
In reply to ying.zhang at freescale.comFrom: Ying Zhang <[email protected]>
Support TPL on the P1022DS.
The TPL's size is sizeable, the maximum size must not exceed the size of L2 SRAM. It initializes the DDR through SPD code, and copys final uboot image to DDR. So there are three stage uboot images:
* spl_boot, 4KB size, pad to 128K byte.
* tpl_boot, 88K size, pad to 128K size. The env variables are copied to L2 SRAM, so that ddr SPD code can get the interleaving mode setting in env. It loads final uboot image from offset 256KB.
* final uboot image, size is variable depends on the functions enabled.
This patch is on top of the patch:
nand: tpl : introduce the TPL based on the SPL
--- arch/powerpc/cpu/mpc85xx/u-boot-spl.lds | 4 + board/freescale/p1022ds/Makefile | 3 + board/freescale/p1022ds/spl_minimal.c | 57 ++--------------- board/freescale/p1022ds/tlb.c | 4 +- board/freescale/p1022ds/tpl.c | 102 +++++++++++++++++++++++++++++++ drivers/mtd/nand/fsl_elbc_spl.c | 18 +++++- include/configs/P1022DS.h | 79 ++++++++++++++++++------ 7 files changed, 196 insertions(+), 71 deletions(-) create mode 100644 board/freescale/p1022ds/tpl.c
arch/powerpc/cpu/mpc85xx/u-boot-spl.lds +4 -0
@@ -32,7 +32,11 @@ PHDRS #endif SECTIONS { +#ifdef CONFIG_SPL_BUILD . = CONFIG_SPL_TEXT_BASE; +#else + . = CONFIG_TPL_TEXT_BASE; +#endif .text : { *(.text*) }
board/freescale/p1022ds/Makefile +3 -0
@@ -27,6 +27,9 @@ else ifdef CONFIG_SPL_BUILD COBJS-y += spl.o endif +ifdef CONFIG_TPL_BUILD +COBJS-y += tpl.o +endif COBJS-y += $(BOARD).o COBJS-y += ddr.o COBJS-y += law.o
board/freescale/p1022ds/spl_minimal.c +7 -50
83 lines not on this page · raw message
board/freescale/p1022ds/tlb.c +2 -2
@@ -41,7 +41,7 @@ struct fsl_e_tlb_entry tlb_table[] = { MAS3_SX|MAS3_SW|MAS3_SR, MAS2_I|MAS2_G, 0, 1, BOOKE_PAGESZ_1M, 1), -#ifndef CONFIG_SPL_BUILD +#if !defined(CONFIG_SPL_BUILD ) && !defined(CONFIG_TPL_BUILD )/* W**G* - Flash/promjet, localbus */ /* This will be changed to *I*G* after relocation to RAM. */ SET_TLB_ENTRY(1, CONFIG_SYS_FLASH_BASE, CONFIG_SYS_FLASH_BASE_PHYS,
@@ -75,7 +75,7 @@ struct fsl_e_tlb_entry tlb_table[] = { 0, 7, BOOKE_PAGESZ_4K, 1),#if defined(CONFIG_SYS_RAMBOOT ) || \ - (defined(CONFIG_SPL ) && !defined(CONFIG_SPL_COMMON_INIT_DDR )) + (defined(CONFIG_SPL ) && !defined(CONFIG_COMMON_INIT_DDR ))/* **** - eSDHC/eSPI/NAND boot */ SET_TLB_ENTRY(1, CONFIG_SYS_DDR_SDRAM_BASE, CONFIG_SYS_DDR_SDRAM_BASE, MAS3_SX|MAS3_SW|MAS3_SR, 0,
board/freescale/p1022ds/tpl.c new file +102 -0
102 lines not on this page · raw message
drivers/mtd/nand/fsl_elbc_spl.c +17 -1
@@ -50,7 +50,7 @@ static void nand_wait(void)#ifdef CONFIG_SPL_BUILD static int nand_load_image(uint32_t offs, unsigned int uboot_size, void *vdst)#else -int nand_load_image(uint32_t offs, unsigned int uboot_size, void *vdst) +int nand_load(uint32_t offs, unsigned int uboot_size, void *vdst)#endif {fsl_lbc_t *regs =LBC_BASE_ADDR ;
@@ -141,17 +141,33 @@ void nand_boot(void)/* * Load U-Boot image from NAND into RAM */ +#ifdef CONFIG_SPL_BUILD nand_load_image (CONFIG_SYS_NAND_U_BOOT_OFFS ,CONFIG_SYS_NAND_U_BOOT_SIZE , (void *)CONFIG_SYS_NAND_U_BOOT_DST ); +#else +nand_load (CONFIG_SYS_NAND_U_BOOT_OFFS , +CONFIG_SYS_NAND_U_BOOT_SIZE , + (void *)CONFIG_SYS_NAND_U_BOOT_DST ); +#endif #ifdef CONFIG_NAND_ENV_DST +#ifdef CONFIG_SPL_BUILD nand_load_image (CONFIG_ENV_OFFSET ,CONFIG_ENV_SIZE , (void *)CONFIG_NAND_ENV_DST ); +#else +nand_load (CONFIG_ENV_OFFSET ,CONFIG_ENV_SIZE , + (void *)CONFIG_NAND_ENV_DST ); +#endif #ifdef CONFIG_ENV_OFFSET_REDUND +#ifdef CONFIG_SPL_BUILD nand_load_image (CONFIG_ENV_OFFSET_REDUND ,CONFIG_ENV_SIZE , (void *)CONFIG_NAND_ENV_DST +CONFIG_ENV_SIZE ); +#else +nand_load (CONFIG_ENV_OFFSET_REDUND ,CONFIG_ENV_SIZE , + (void *)CONFIG_NAND_ENV_DST +CONFIG_ENV_SIZE ); +#endif #endif #endif
include/configs/P1022DS.h +61 -18
139 lines not on this page · raw message
Signature · 1 line
1.7.0.4
PATCH 10/10 powerpc: p1022ds: support TPL on the P1022DS
Quoted 3 lines · On Tue, Jun 18, 2013 at 5:39 AM, <[email protected]> wrote:
From: Ying Zhang <[email protected]>
Support TPL on the P1022DS.
Please define "TPL". I have no idea what it is.
PATCH 10/10 powerpc: p1022ds: support TPL on the P1022DS
Quoted 6 lines · Timur Tabi
Quoted 3 lines · On Tue, Jun 18, 2013 at 5:39 AM, <[email protected]> wrote:
From: Ying Zhang <[email protected]>
Support TPL on the P1022DS.
Please define "TPL". I have no idea what it is.
Third Program Loader. An additional stage that comes after SPL, before the main image. But yes, the commit message and README should explain this.
-Scott
PATCH 10/10 powerpc: p1022ds: support TPL on the P1022DS
Quoted 5 lines · Scott Wood
Quoted 3 lines · Timur Tabi
Quoted 2 lines · On Tue, Jun 18, 2013 at 5:39 AM, <[email protected]> wrote:
From: Ying Zhang <[email protected]>
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Support TPL on the P1022DS.
Please define "TPL". I have no idea what it is.
Third Program Loader. An additional stage that comes after SPL, before the main image. But yes, the commit message and README should explain this.
I'm having a great deal of difficulty understanding your patch numbering system. This patch is 10/10, and I see 5/10 and 9/10. Where are 1-4 and 7-8? I also see some unnumbered, unversioned patches (despite the fact that they are clearly part of a series, and not the first versions of the patch submitted). I also see a series of 4 patches, which are marked as being a series of 8 patches, and we only see 2, 5, 6, and 8.
Please:
1) Put version numbers on your patches. The version should increment each time you send the patch out (even if it hasn't changed. It helps keep the patch series coherent). You don't need a version number on the first instance of the patch
2) Put a changelog for your patch below the "---", which describes the change history of that patch. If you are on v5, there should be 4 changelogs, so we see how the patch has changed over time. If it doesn't change, just put "no change"
3) If a set of patches are related to each other, then put them in a series, and number them x/n, where x is 1-n. I suspect that this particular numbering oddness is caused by generating 10 patches, and then only submitting 3 of them (perhaps because the others are already up-to-date). Please default to re-sending all patches in a series. It is fairly trivial to notice in patchworks, and much easier to ensure that I've actually seen all the relevant patches.
Andy