consolekit: fix tow QA warnings
cover consolekit: fix tow QA warnings
From: Jackie Huang <[email protected]>
Tested with:DISTRO_FEATURES += 'pam'WARN_QA = "unsafe-references-in-binaries unsafe-references-in-scripts"
--
The following changes since commit defa05f2085f78d9ec9ada7051c284e1fc72e6c1:
bdwgc-native: Add missing pkgconfig DEPENDS (2013-06-19 18:03:21 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib jhuang0/r_bbappend_consolekit_dbus_0620_1
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jhuang0/r_bbappend_consolekit_dbus_0620_1
Jackie Huang (2):
consolekit: move libck-connector to base_libdir
dbus: move libdbus-1.so* to base_libdir
meta/recipes-core/dbus/dbus.inc | 10 +++++++++- .../recipes-support/consolekit/consolekit_0.4.5.bb | 13 ++++++++++++- 2 files changed, 21 insertions(+), 2 deletions(-)
Signature · 1 line
1.7.4.1
PATCH 1/2 consolekit: move libck-connector to base_libdir
From: Jackie Huang <[email protected]>
move libck-connector.so.* to base_libdir and move pam_ck_connector.la to libdir to kill two warnings:
WARNING: QA Issue: consolekit: /lib64/security/pam_ck_connector.so, installed in the base_prefix, requires a shared library under exec_prefix (/usr): libck-connector.so.0 => /usr/lib64/ libck-connector.so.0 (0x00000000dead300
WARNING: QA Issue: lib32-consolekit: Found a reference to /usr/ in
/buildarea1/jhuang0/t_multilib/p_x64_0217/bitbake_build/tmp/work/
x86-wrsmllib32-linux/lib32-consolekit-0.4.5-r10/packages-split/i lib32-consolekit/lib/security/pam_ck_connector.la
WARNING: QA Issue: Shell scripts in base_bindir and base_sbindir should not reference anything in exec_prefix
--- .../recipes-support/consolekit/consolekit_0.4.5.bb | 13 ++++++++++++- 1 files changed, 12 insertions(+), 1 deletions(-)
meta/recipes-support/consolekit/consolekit_0.4.5.bb +12 -1
@@ -2,7 +2,7 @@ DESCRIPTION = "ConsoleKit is a framework for defining and tracking users, login HOMEPAGE="http://www.freedesktop.org/wiki/Software/ConsoleKit" BUGTRACKER="https://bugs.freedesktop.org/buglist.cgi?query_format=specific&product=ConsoleKit" -PR = "r10" +PR = "r11" LICENSE = "GPLv2+" LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \
@@ -41,4 +41,15 @@ RDEPENDS_pam-plugin-ck-connector += "${PN}" do_install_append() { # Remove /var/run from package as console-kit-daemon will populate it on startup rm -fr "${D}${localstatedir}/run" + # Moving libck-connector to base_libdir + # and moving pam_ck_connector.la to libdir + if [ ! ${D}${libdir} -ef ${D}${base_libdir} ]; then + mkdir -p ${D}/${base_libdir}/ + mv -f ${D}${libdir}/libck-connector.so.0* ${D}${base_libdir}/ + rel_lib_prefix=${@os.path.relpath(d.getVar('base_libdir', True), d.getVar('libdir', True))} + ln -sf ${rel_lib_prefix}${base_libdir}/libck-connector.so.0.0.0 ${D}${libdir}/libck-connector.so + if [ -f ${D}${base_libdir}/security/pam_ck_connector.la ]; then + mv -f ${D}${base_libdir}/security/pam_ck_connector.la ${D}${libdir}/ + fi + fi }
Signature · 1 line
1.7.4.1
Re: [PATCH 1/2] consolekit: move libck-connector to base_libdir
Sorry I accidently sent the not working one, drop it and I will re-send.
Thanks,
Jackie
Quoted 53 lines · On 6/20/2013 6:36 PM, [email protected] wrote:
From: Jackie Huang <[email protected]>
move libck-connector.so.* to
base_libdirand move pam_ck_connector.la to libdir to kill two warnings:WARNING: QA Issue: consolekit:
/lib64/security/pam_ck_connector.so, installed in thebase_prefix, requires a shared library underexec_prefix(/usr): libck-connector.so.0 =>/usr/lib64/libck-connector.so.0 (0x00000000dead300WARNING: QA Issue: lib32-consolekit: Found a reference to
/usr/in
/buildarea1/jhuang0/t_multilib/p_x64_0217/bitbake_build/tmp/work/
x86-wrsmllib32-linux/lib32-consolekit-0.4.5-r10/packages-split/i lib32-consolekit/lib/security/pam_ck_connector.la
WARNING: QA Issue: Shell scripts inbase_bindirandbase_sbindirshould not reference anything inexec_prefixSigned-off-by Roy.Li <[email protected]>Signed-off-by Jackie Huang <[email protected]>--- .../recipes-support/consolekit/consolekit_0.4.5.bb | 13 ++++++++++++- 1 files changed, 12 insertions(+), 1 deletions(-)meta/recipes-support/consolekit/consolekit_0.4.5.bb +12
-1@@ -2,7 +2,7 @@ DESCRIPTION = "ConsoleKit is a framework for defining and tracking users, login HOMEPAGE="http://www.freedesktop.org/wiki/Software/ConsoleKit" BUGTRACKER="https://bugs.freedesktop.org/buglist.cgi?query_format=specific&product=ConsoleKit" -PR = "r10" +PR = "r11" LICENSE = "GPLv2+" LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \@@ -41,4 +41,15 @@ RDEPENDS_pam-plugin-ck-connector += "${PN}" do_install_append() { # Remove /var/run from package as console-kit-daemon will populate it on startup rm -fr "${D}${localstatedir}/run" + # Moving libck-connector to base_libdir + # and moving pam_ck_connector.la to libdir + if [ ! ${D}${libdir} -ef ${D}${base_libdir} ]; then + mkdir -p ${D}/${base_libdir}/ + mv -f ${D}${libdir}/libck-connector.so.0* ${D}${base_libdir}/ + rel_lib_prefix=${@os.path.relpath(d.getVar('base_libdir', True), d.getVar('libdir', True))} + ln -sf ${rel_lib_prefix}${base_libdir}/libck-connector.so.0.0.0 ${D}${libdir}/libck-connector.so + if [ -f ${D}${base_libdir}/security/pam_ck_connector.la ]; then + mv -f ${D}${base_libdir}/security/pam_ck_connector.la ${D}${libdir}/ + fi + fi }
Signature · 5 lines
Jackie Huang WIND RIVER | China Development Center MSN:[email protected] Tel: +86 8477 8594 Mobile: +86 138 1027 4745
PATCH 2/2 dbus: move libdbus-1.so* to base_libdir
In reply to [email protected]From: Jackie Huang <[email protected]>
move libdbus-1.so* to base_libdir to kill a warning:
WARNING: QA Issue: lib32-consolekit: /lib/security/ pam_ck_connector.so, installed in the base_prefix, requires a shared library under exec_prefix (/usr):
libdbus-1.so.3 => /usr/lib/libdbus-1.so.3 (0xdead3000)
--- meta/recipes-core/dbus/dbus.inc | 10 +++++++++- 1 files changed, 9 insertions(+), 1 deletions(-)
meta/recipes-core/dbus/dbus.inc +9 -1
@@ -12,7 +12,7 @@ DEPENDS_class-nativesdk = "nativesdk-expat virtual/nativesdk-libintl" RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest-ptest', '', d)}" RDEPENDS_class-native = "" -INC_PR = "r6" +INC_PR = "r7" SRC_URI = "http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz \ file://tmpdir.patch; \
@@ -116,6 +116,14 @@ do_install() { # Remove /var/run as it is created on startup rm -rf ${D}${localstatedir}/run + + # Move libdbus-1.so.3* to base_libdir + if [ ! ${D}${libdir} -ef ${D}${base_libdir} ]; then + mkdir -p ${D}/${base_libdir}/ + mv -f ${D}${libdir}/libdbus-1.so.3* ${D}${base_libdir}/ + rel_lib_prefix=${@os.path.relpath(d.getVar('base_libdir', True), d.getVar('libdir', True))} + ln -sf ${rel_lib_prefix}/libdbus-1.so.3.7.2 ${D}${libdir}/libdbus-1.so + fi } do_install_class-native() {
Signature · 1 line
1.7.4.1
Re: [PATCH 2/2] dbus: move libdbus-1.so* to base_libdir
Quoted 11 lines · On 20 June 2013 11:36, <[email protected]> wrote:
From: Jackie Huang <[email protected]>
move libdbus-1.so* to
base_libdirto kill a warning:WARNING: QA Issue: lib32-consolekit:
/lib/security/pam_ck_connector.so, installed in thebase_prefix, requires a shared library underexec_prefix(/usr):
libdbus-1.so.3 =>/usr/lib/libdbus-1.so.3(0xdead3000)Signed-off-by Roy.Li <[email protected]>Signed-off-by Jackie Huang <[email protected]>
More and more and more libraries move. Do we *really* need to support split-usr? Have you audited all of the udev helpers yet?
Ross
Re: [PATCH 2/2] dbus: move libdbus-1.so* to base_libdir
Quoted 10 lines · Ross
Quoted 9 lines · On 20 June 2013 11:36, <[email protected]> wrote:
From: Jackie Huang <[email protected]>
move libdbus-1.so* to
base_libdirto kill a warning:WARNING: QA Issue: lib32-consolekit:
/lib/security/pam_ck_connector.so, installed in thebase_prefix, requires a shared library underexec_prefix(/usr):
libdbus-1.so.3 =>/usr/lib/libdbus-1.so.3(0xdead3000)
Quoted 5 lines
Quoted 2 lines
Signed-off-by Roy.Li <[email protected]>Signed-off-by Jackie Huang <[email protected]>More and more and more libraries move. Do we *really* need to support split-usr? Have you audited all of the udev helpers yet?
I have to admit I'm not happy with the piece by piece approach this is taking. We're going to end up with nearly everything moving to base_libdir at this rate. If we're going to do this, I want someone to come up with a definitive list of what needs to move before any more of these merge.
Cheers,
Richard
Re: [PATCH 2/2] dbus: move libdbus-1.so* to base_libdir
Quoted 5 lines · Richard Purdie
I have to admit I'm not happy with the piece by piece approach this is taking. We're going to end up with nearly everything moving to
base_libdirat this rate. If we're going to do this, I want someone to come up with a definitive list of what needs to move before any more of these merge.
The "fun" is stuff like udev helpers, which can link to whatever they want. If the hardware is probed before /usr is mounted, they'll fail to run and the work they should have done won't have happened.
Stock oe-core doesn't ship any interesting helpers, but on my Debian system there is mtp-probe linking to /usr/lib/libmtp.so, and udev-configure-printer (CUPS hotplug support) linking to (deep breath) libcups gnutls avahi kerberos p11-kit. So, all of those (and their dependencies) probably have to move to /lib, or you put in the documentation that printers and cameras can't be attached at boot.
Ross
Re: [PATCH 2/2] dbus: move libdbus-1.so* to base_libdir
In reply to Richard PurdieQuoted 14 lines · Richard Purdie
Quoted 13 lines · Ross
Quoted 11 lines · On 20 June 2013 11:36, <[email protected]> wrote:
From: Jackie Huang <[email protected]>
move libdbus-1.so* to
base_libdirto kill a warning:WARNING: QA Issue: lib32-consolekit:
/lib/security/pam_ck_connector.so, installed in thebase_prefix, requires a shared library underexec_prefix(/usr):
libdbus-1.so.3 =>/usr/lib/libdbus-1.so.3(0xdead3000)Signed-off-by Roy.Li <[email protected]>Signed-off-by Jackie Huang <[email protected]>
Quoted 9 lines
Quoted 2 lines
More and more and more libraries move. Do we *really* need to support split-usr? Have you audited all of the udev helpers yet?
I have to admit I'm not happy with the piece by piece approach this is taking. We're going to end up with nearly everything moving to
base_libdirat this rate. If we're going to do this, I want someone to come up with a definitive list of what needs to move before any more of these merge.
And this should be checked with various DISTRO_FEATURES such as pam (enabled/disabled) and systemd (enabled/disabled), not just one variation, please be sure to list what your testing matrix is.
Thanks
Sau!
Quoted 12 lines
Cheers,
Richard
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [PATCH 2/2] dbus: move libdbus-1.so* to base_libdir
Quoted 24 lines · Saul Wold
Quoted 14 lines · Richard Purdie
Quoted 13 lines · Ross
Quoted 11 lines · On 20 June 2013 11:36, <[email protected]> wrote:
From: Jackie Huang <[email protected]>
move libdbus-1.so* to
base_libdirto kill a warning:WARNING: QA Issue: lib32-consolekit:
/lib/security/pam_ck_connector.so, installed in thebase_prefix, requires a shared library underexec_prefix(/usr):
libdbus-1.so.3 =>/usr/lib/libdbus-1.so.3(0xdead3000)Signed-off-by Roy.Li <[email protected]>Signed-off-by Jackie Huang <[email protected]>Quoted 9 lines
Quoted 2 lines
More and more and more libraries move. Do we *really* need to support split-usr? Have you audited all of the udev helpers yet?
I have to admit I'm not happy with the piece by piece approach this is taking. We're going to end up with nearly everything moving to
base_libdirat this rate. If we're going to do this, I want someone to come up with a definitive list of what needs to move before any more of these merge.
Quoted 3 lines
And this should be checked with various
DISTRO_FEATURESsuch as pam (enabled/disabled) and systemd (enabled/disabled), not just one variation, please be sure to list what your testing matrix is.
I tested with DISTRO_FEATURES 'pam' (enabled/disabled) and 'systemd' (enabled/disabled) and WARN_QA = "unsafe-references-in-binaries unsafe-references-in-scripts", and I have sent a v3. If you are agree to merge, please merge the v3 one, thanks!
Thanks,
Jackie
Quoted 18 lines
Thanks
Sau!Quoted 12 lines
Cheers,
Richard
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Signature · 5 lines
Jackie Huang WIND RIVER | China Development Center MSN:[email protected] Tel: +86 8477 8594 Mobile: +86 138 1027 4745
Re: [PATCH 2/2] dbus: move libdbus-1.so* to base_libdir
Quoted 26 lines · On Fri, 2013-06-21 at 10:02 +0800, jhuang0 wrote:
Quoted 24 lines · Saul Wold
Quoted 23 lines · Richard Purdie
Quoted 10 lines · Ross
Quoted 9 lines · On 20 June 2013 11:36, <[email protected]> wrote:
From: Jackie Huang <[email protected]>
move libdbus-1.so* to
base_libdirto kill a warning:WARNING: QA Issue: lib32-consolekit:
/lib/security/pam_ck_connector.so, installed in thebase_prefix, requires a shared library underexec_prefix(/usr):
libdbus-1.so.3 =>/usr/lib/libdbus-1.so.3(0xdead3000)Quoted 5 lines
Quoted 2 lines
Signed-off-by Roy.Li <[email protected]>Signed-off-by Jackie Huang <[email protected]>More and more and more libraries move. Do we *really* need to support split-usr? Have you audited all of the udev helpers yet?
I have to admit I'm not happy with the piece by piece approach this is taking. We're going to end up with nearly everything moving to
base_libdirat this rate. If we're going to do this, I want someone to come up with a definitive list of what needs to move before any more of these merge.
Quoted 8 lines
Quoted 3 lines
And this should be checked with various
DISTRO_FEATURESsuch as pam (enabled/disabled) and systemd (enabled/disabled), not just one variation, please be sure to list what your testing matrix is.I tested with
DISTRO_FEATURES'pam' (enabled/disabled) and 'systemd' (enabled/disabled) andWARN_QA= "unsafe-references-in-binaries unsafe-references-in-scripts", and I have sent a v3. If you are agree to merge, please merge the v3 one, thanks!
As I said, I'm not taking any more of these moves until there is a well thought out analysis/plan. Sorry.
Cheers,
Richard
Re: [PATCH 2/2] dbus: move libdbus-1.so* to base_libdir
Quoted 31 lines · Richard Purdie
Quoted 30 lines · On Fri, 2013-06-21 at 10:02 +0800, jhuang0 wrote:
Quoted 27 lines · Saul Wold
Quoted 14 lines · Richard Purdie
Quoted 13 lines · Ross
Quoted 11 lines · On 20 June 2013 11:36, <[email protected]> wrote:
From: Jackie Huang <[email protected]>
move libdbus-1.so* to
base_libdirto kill a warning:WARNING: QA Issue: lib32-consolekit:
/lib/security/pam_ck_connector.so, installed in thebase_prefix, requires a shared library underexec_prefix(/usr):
libdbus-1.so.3 =>/usr/lib/libdbus-1.so.3(0xdead3000)Signed-off-by Roy.Li <[email protected]>Signed-off-by Jackie Huang <[email protected]>Quoted 9 lines
Quoted 2 lines
More and more and more libraries move. Do we *really* need to support split-usr? Have you audited all of the udev helpers yet?
I have to admit I'm not happy with the piece by piece approach this is taking. We're going to end up with nearly everything moving to
base_libdirat this rate. If we're going to do this, I want someone to come up with a definitive list of what needs to move before any more of these merge.And this should be checked with various
DISTRO_FEATURESsuch as pam (enabled/disabled) and systemd (enabled/disabled), not just one variation, please be sure to list what your testing matrix is.
Quoted 7 lines
Quoted 4 lines
I tested with
DISTRO_FEATURES'pam' (enabled/disabled) and 'systemd' (enabled/disabled) andWARN_QA= "unsafe-references-in-binaries unsafe-references-in-scripts", and I have sent a v3. If you are agree to merge, please merge the v3 one, thanks!As I said, I'm not taking any more of these moves until there is a well thought out analysis/plan. Sorry.
Hi Richard/Saul,
We sent these since we used bbappend approach to fix issues in our layer and now we want to minimize the usage of bbappend files, I admit that the piece by piece approach is not good so I undertand if it is not taken, we will analyze the issue and come out a plan sometime later.
Thanks,
Jackie
Quoted 6 lines
Cheers,
Richard
Signature · 5 lines
Jackie Huang WIND RIVER | China Development Center MSN:[email protected] Tel: +86 8477 8594 Mobile: +86 138 1027 4745