base.bbclass: Ensure finalised data is displayed in build banner
PATCH 1/1 base.bbclass: Ensure finalised data is displayed in build banner
The build banner displayed at the start of builds can be misleading since the data store has not been finalised. As easy way to illustrate this is to use something like:
DEFAULTTUNE = "i586"
DEFAULTTUNE_<machineoverride> = "core2"
and the banner will display the i586 tune yet the core2 tune will be used. We can avoid this if we finalise a copy of the data before displaying it.
[YOCTO #4225]
Signed-off-by Richard Purdie <[email protected]>
---
meta/classes/base.bbclass +4 -2
@@ -309,13 +309,15 @@ python base_eventhandler() { oe.utils.features_backfill("MACHINE_FEATURES", e.data) if isinstance(e, bb.event.BuildStarted): + localdata = bb.data.createCopy(e.data) + bb.data.update_data(localdata) statuslines = [] - for func in oe.data.typed_value('BUILDCFG_FUNCS', e.data): + for func in oe.data.typed_value('BUILDCFG_FUNCS', localdata): g = globals() if func not in g: bb.warn("Build configuration function '%s' does not exist" % func) else: - flines = g[func](e.data) + flines = g[func](localdata) if flines: statuslines.extend(flines)