Skip to contentSkip to conversation

serial: Use ARRAY_SIZE instead of reinventing it

PATCH In review Axel Lin 2 participants 2 messages Jun 22, 2013 – Jun 26, 2013

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 serial: Use ARRAY_SIZE instead of reinventing it

Signed-off-by Axel Lin <[email protected]>
---
 drivers/serial/serial.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/serial/serial.c +2 -3
index daa8003..a19cec5 100644
@@ -37,7 +37,6 @@ static struct serial_device *serial_current;
  * Table with supported baudrates (defined in config_xyz.h)
  */
 static const unsigned long baudrate_table[] = CONFIG_SYS_BAUDRATE_TABLE;
-#define	N_BAUDRATES (sizeof(baudrate_table) / sizeof(baudrate_table[0]))
 
 /**
  * serial_null() - Void registration routine of a serial driver

@@ -74,11 +73,11 @@ static int on_baudrate(const char *name, const char *value, enum env_op op,
 		if (gd->baudrate == baudrate)
 			return 0;
 
-		for (i = 0; i < N_BAUDRATES; ++i) {
+		for (i = 0; i < ARRAY_SIZE(baudrate_table); ++i) {
 			if (baudrate == baudrate_table[i])
 				break;
 		}
-		if (i == N_BAUDRATES) {
+		if (i == ARRAY_SIZE(baudrate_table)) {
 			if ((flags & H_FORCE) == 0)
 				printf("## Baudrate %d bps not supported\n",
 					baudrate);
Signature · 1 line
1.8.1.2
#1 lore raw
Quoted 5 lines · Axel Lin
Signed-off-by Axel Lin <[email protected]>

---
drivers/serial/serial.c | 5 ++---

 1 file changed, 2 insertions(+), 3 deletions(-)

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130626/647b1da0/attachment.pgp>