Skip to contentSkip to conversation

pinctrl: rockchip: Add missing irq_gc_unlock() call before return error

PATCH In review Axel Lin 3 participants 3 messages Jun 23, 2013 – Jun 24, 2013

Subsystems (2)
Arm Rockchip Pin control
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 pinctrl: rockchip: Add missing irq_gc_unlock() call before return error

Signed-off-by Axel Lin <[email protected]>
---
 drivers/pinctrl/pinctrl-rockchip.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pinctrl/pinctrl-rockchip.c +1 -0
index 427564f..1eb5a2e 100644
@@ -1035,6 +1035,7 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type)
 		polarity &= ~mask;
 		break;
 	default:
+		irq_gc_unlock(gc);
 		return -EINVAL;
 	}
Signature · 1 line
1.8.1.2
maintainer Acked-by on v1 1/1
#1 lore raw

Am Sonntag, 23. Juni 2013, 02:48:34 schrieb Axel Lin:

Quoted 1 line
Signed-off-by Axel Lin <[email protected]>

Thanks for catching this glitch.

Acked-by Heiko Stuebner <[email protected]>
Quoted 15 lines
---
 drivers/pinctrl/pinctrl-rockchip.c | 1 +
 1 file changed, 1 insertion(+)
(quoted diff) +0 -0

b/drivers/pinctrl/pinctrl-rockchip.c index 427564f..1eb5a2e 100644

drivers/pinctrl/pinctrl-rockchip.c +1 -0
@@ -1035,6 +1035,7 @@ static int rockchip_irq_set_type(struct irq_data *d,
 unsigned int type) polarity &= ~mask;
 		break;
 	default:
+		irq_gc_unlock(gc);
 		return -EINVAL;
 	}