Skip to contentSkip to conversation

fix grub-mknetdir --help output

PATCH In review Andrey Borzenkov 2 participants 2 messages Jun 23, 2013 – Jul 12, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix grub-mknetdir --help output

Remove stray line. It

a) incorrect, because grub-mknetdir does not install grub on hard drive
b) causes --help to fail immediately due to

Usage: grub-mknetdir [OPTION]
gettext: missing arguments

It was this way for quite some time, but became obvious only recently when all utilities started to use "set -e" by default.

---
 util/grub-mknetdir.in | 1 -
 1 file changed, 1 deletion(-)
util/grub-mknetdir.in +0 -1
index 97d4155..b7b59da 100644
@@ -37,7 +37,6 @@ itanium_dir="${libdir}/@PACKAGE@/ia64-efi"
 # Print the usage.
 usage () {
     gettext_printf "Usage: %s [OPTION]\n" "$self"
-    gettext; echo "Install GRUB on your drive."; echo
     echo
     print_option_help "-h, --help" "$(gettext "print this message and exit")"
     grub_print_install_files_help
Signature · 1 line
tg: (2cca311..) u/grub-mknetdir-gettext (depends on: master)
#1 lore raw

Go ahead

Quoted 30 lines · Andrey Borzenkov

Remove stray line. It

a) incorrect, because grub-mknetdir does not install grub on hard drive
b) causes --help to fail immediately due to

Usage: grub-mknetdir [OPTION]
gettext: missing arguments

It was this way for quite some time, but became obvious only recently when all utilities started to use "set -e" by default.

---
  util/grub-mknetdir.in | 1 -
  1 file changed, 1 deletion(-)
util/grub-mknetdir.in +0 -1
index 97d4155..b7b59da 100644
@@ -37,7 +37,6 @@ itanium_dir="${libdir}/@PACKAGE@/ia64-efi"
  # Print the usage.
  usage () {
      gettext_printf "Usage: %s [OPTION]\n" "$self"
-    gettext; echo "Install GRUB on your drive."; echo
      echo
      print_option_help "-h, --help" "$(gettext "print this message and exit")"
      grub_print_install_files_help