misc/bmp085: Enable building as a module
PATCH 1/1 misc/bmp085: Enable building as a module
Commit 985087dbcb02 'misc: add support for bmp18x chips to the bmp085 driver' changed the BMP085 config symbol to a boolean. I see no reason why the shared code cannot be built as a module, so change it back to tristate.
--- drivers/misc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/Kconfig +1 -1
@@ -451,7 +451,7 @@ config ARM_CHARLCD still useful. config BMP085 - bool + tristate depends on SYSFS config BMP085_I2C
Quoted 17 lines · Ben Hutchings
Commit
985087dbcb02'misc: add support for bmp18x chips to the bmp085 driver' changed the BMP085 config symbol to a boolean. I see no reason why the shared code cannot be built as a module, so change it back to tristate.Cc Eric Andersson <[email protected]>Signed-off-by Ben Hutchings <[email protected]>--- drivers/misc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/misc/Kconfig +0
-0
drivers/misc/Kconfig config ARM_CHARLCD · line 457
Quoted 8 lines
drivers/misc/Kconfig +1
-1@@ -451,7 +451,7 @@ config ARM_CHARLCD still useful. config BMP085 - bool + tristate depends on SYSFS config BMP085_I2C
There is no reason for building the common code stand-alone. The BMP085 config option is only selectable via the BMP085_I2C/_SPI options. See the select-statement for those options:
config BMP085_I2C
tristate "BMP085 digital pressure sensor on I2C" select BMP085
...
Signature · 4 lines
Best regards, Eric http://www.unixphere.com
Quoted 24 lines · Eric Andersson
Quoted 23 lines · Ben Hutchings
Commit
985087dbcb02'misc: add support for bmp18x chips to the bmp085 driver' changed the BMP085 config symbol to a boolean. I see no reason why the shared code cannot be built as a module, so change it back to tristate.Cc Eric Andersson <[email protected]>Signed-off-by Ben Hutchings <[email protected]>--- drivers/misc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/misc/Kconfig +1
-1@@ -451,7 +451,7 @@ config ARM_CHARLCD still useful. config BMP085 - bool + tristate depends on SYSFS
Quoted 5 lines
drivers/misc/Kconfig config ARM_CHARLCD · line 457
Quoted 2 lines
drivers/misc/Kconfig +0
-0config BMP085_I2CThere is no reason for building the common code stand-alone. The BMP085 config option is only selectable via the BMP085_I2C/_SPI options.
Yes, but it is then always built-in.
Ben.
Quoted 7 lines
See the select-statement for those options:
config
BMP085_I2C
tristate "BMP085 digital pressure sensor on I2C" select BMP085
...
Signature · 3 lines
Ben Hutchings Life is like a sewer: what you get out of it depends on what you put into it.
Quoted 25 lines · Ben Hutchings
Quoted 24 lines · Eric Andersson
Quoted 23 lines · Ben Hutchings
Commit
985087dbcb02'misc: add support for bmp18x chips to the bmp085 driver' changed the BMP085 config symbol to a boolean. I see no reason why the shared code cannot be built as a module, so change it back to tristate.Cc Eric Andersson <[email protected]>Signed-off-by Ben Hutchings <[email protected]>--- drivers/misc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/misc/Kconfig +1
-1@@ -451,7 +451,7 @@ config ARM_CHARLCD still useful. config BMP085 - bool + tristate depends on SYSFS
Quoted 7 lines
Quoted 5 lines
drivers/misc/Kconfig config ARM_CHARLCD · line 457
Quoted 2 lines
drivers/misc/Kconfig +0
-0config BMP085_I2CThere is no reason for building the common code stand-alone. The BMP085 config option is only selectable via the BMP085_I2C/_SPI options.
Yes, but it is then always built-in.
Good point. This change is fine by me.
Signature · 4 lines
Best regards, Eric http://www.unixphere.com