board/bsc913x: Add config flag for bootdelay
PATCH 1/1 board/bsc913x: Add config flag for bootdelay
Keep the value of CONFIG_BOOTDELAY as -1 to disable autoboot
--- include/configs/BSC9131RDB.h | 1 + include/configs/BSC9132QDS.h | 1 + 2 files changed, 2 insertions(+), 0 deletions(-)
include/configs/BSC9131RDB.h +1 -0
@@ -393,6 +393,7 @@ extern unsigned long get_sdram_size(void);#define CONFIG_UBOOTPATH "u-boot.bin"/* U-Boot image on TFTP server */ #define CONFIG_BAUDRATE 115200 +#define CONFIG_BOOTDELAY -1/* Disable autoboot */ #define CONFIG_EXTRA_ENV_SETTINGS \ "netdev=eth0\0" \
include/configs/BSC9132QDS.h +1 -0
@@ -607,6 +607,7 @@ combinations. this should be removed later#define CONFIG_UBOOTPATH "u-boot.bin"#define CONFIG_BAUDRATE 115200 +#define CONFIG_BOOTDELAY -1/* Disable autoboot */ #ifdef CONFIG_SDCARD #define CONFIG_DEF_HWCONFIG "hwconfig=usb1:dr_mode=host,phy_type=ulpi\0"
Signature · 1 line
1.5.5.6
PATCH 1/1 board/bsc913x: Add config flag for bootdelay
Hi Harninder,
Quoted 25 lines · Harninder Rai
Keep the value of
CONFIG_BOOTDELAYas -1 to disable autobootSigned-off-by Harninder Rai <[email protected]>--- include/configs/BSC9131RDB.h | 1 + include/configs/BSC9132QDS.h | 1 + 2 files changed, 2 insertions(+), 0 deletions(-)include/configs/BSC9131RDB.h +1
-0@@ -393,6 +393,7 @@ extern unsigned long get_sdram_size(void);#define CONFIG_UBOOTPATH "u-boot.bin"/* U-Boot image on TFTP server */ #define CONFIG_BAUDRATE 115200 +#define CONFIG_BOOTDELAY -1/* Disable autoboot */ #define CONFIG_EXTRA_ENV_SETTINGS \ "netdev=eth0\0" \include/configs/BSC9132QDS.h +0
-0
include/configs/BSC9132QDS.h combinations. this should be removed later · line 613
Quoted 7 lines
include/configs/BSC9132QDS.h +1
-0@@ -607,6 +607,7 @@ combinations. this should be removed later#define CONFIG_UBOOTPATH "u-boot.bin"#define CONFIG_BAUDRATE 115200 +#define CONFIG_BOOTDELAY -1/* Disable autoboot */ #ifdef CONFIG_SDCARD #define CONFIG_DEF_HWCONFIG "hwconfig=usb1:dr_mode=host,phy_type=ulpi\0"
Plase fix commit message: you're not simply adding a boot delay flag, you're in fact disabling autoboot, which is quite different.
Also, when touching on a board's code, you should Cc: the board's maintainer(s). Please do so for V2 of your patch -- and if you get a non-delivery status (e.g. a maintainer's mail address does not exist any more), please follow up on your patch submission to let us know.
Amicalement,
Signature · 1 line
Albert.
PATCH 1/1 board/bsc913x: Add config flag for bootdelay
Hello Albert,
Plase fix commit message: you're not simply adding a boot delay flag, you're in fact disabling autoboot, which is quite different. [Rai Harninder-B01044] "Disable autoboot through bootdelay config flag". Is this ok?
Also, when touching on a board's code, you should Cc: the board's maintainer(s). Please do so for V2 of your patch -- and if you get a non-delivery status (e.g. a maintainer's mail address does not exist any more), please follow up on your patch submission to let us know. [Rai Harninder-B01044] The board's maintainer is Andy Fleming who is already included in cc
Harry++
PATCH 1/1 board/bsc913x: Add config flag for bootdelay
Hi Rai,
Quoted 5 lines · On Mon, 24 Jun 2013 09:28:26 +0000, Rai Harninder-B01044…
Hello Albert,
Plase fix commit message: you're not simply adding a boot delay flag, you're in fact disabling autoboot, which is quite different. [Rai Harninder-B01044] "Disable autoboot through bootdelay config flag". Is this ok?
(weird way of quoting messages; makes it really hard to see who said what. Can't your mail client use the standard ">" line prefix?)
As for the commit summary, it is fine by me.
Quoted 2 lines
Also, when touching on a board's code, you should Cc: the board's maintainer(s). Please do so for V2 of your patch -- and if you get a non-delivery status (e.g. a maintainer's mail address does not exist any more), please follow up on your patch submission to let us know. [Rai Harninder-B01044] The board's maintainer is Andy Fleming who is already included in cc
Are you not mixing up BSC9131RDB and BSC9132QDS maintainership with MPC85xx tree custodianship?
Andy is the MPC85xx custodian, but has no entry in the MAINTAINERS file, which OTOH lists Poonam Aggrwal <[email protected]> as the BSC9131RDB maintainer, and Naveen Burmi <[email protected]> as the BSC9132QDS one.
Quoted 1 line
Harry++
Amicalement,
Signature · 1 line
Albert.
PATCH 1/1 board/bsc913x: Add config flag for bootdelay
Hi Albert,
(weird way of quoting messages; makes it really hard to see who said what. Can't your mail client use the standard ">" line prefix?)
Quoted 1 line
Fixed
As for the commit summary, it is fine by me.
Quoted 1 line
Scott has commented on the same. Can you please have a look and suggest?
Are you not mixing up BSC9131RDB and BSC9132QDS maintainership with MPC85xx tree custodianship?
Quoted 3 lines
913x fall under 85xx platforms only (though their naming convention is quite different) for which Andy has the custodianship. I will anyways include both Poonam and Naveen in the next rev of the patch (if any)
Harry++
PATCH 1/1 board/bsc913x: Add config flag for bootdelay
Quoted 5 lines · On 06/25/2013 07:38:20 AM, Rai Harninder-B01044 wrote:
Hi Albert,
(weird way of quoting messages; makes it really hard to see who said what. Can't your mail client use the standard ">" line prefix?)
Quoted 1 line
Fixed
No, it's not fixed. "> " is supposed to go before lines that you're quoting -- not before your own lines.
-Scott
PATCH 1/1 board/bsc913x: Add config flag for bootdelay
In reply to Rai Harninder-B01044Quoted 7 lines · On 06/24/2013 04:28:26 AM, Rai Harninder-B01044 wrote:
Hello Albert,
Plase fix commit message: you're not simply adding a boot delay flag, you're in fact disabling autoboot, which is quite different. [Rai Harninder-B01044] "Disable autoboot through bootdelay config flag". Is this ok?
But the patch isn't disabling autoboot. It was already compile-time disabled, since CONFIG_BOOTDELAY wasn't specified at all. The patch is allowing it to be enabled at runtime, without enabling it by default.
-Scott