TTY: fix memory leakage in tty_buffer_find()
PATCH 1/1 TTY: fix memory leakage in tty_buffer_find()
In tty_buffer_find(), it scans all tty buffers in free buffer queue, if it finds matched one, tty->buf.free will point to matched one's next buffer, so tty buffers that ahead of matched one are removed from free queue, they will never be used but they are not released, then memory leak happen.
This patch is to make tty_buffer_find() only extract the matched tty buffer, and keep others left inside free queue, so that they could be found and used next time.
Signed-off-by Chao Bi <[email protected]>
--- drivers/tty/tty_buffer.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-)
drivers/tty/tty_buffer.c +6 -1
@@ -178,10 +178,14 @@ void tty_buffer_flush(struct tty_struct *tty)static struct tty_buffer *tty_buffer_find (struct tty_port *port,size_t size) {struct tty_buffer **tbh = &port->buf.free; +struct tty_buffer *prev = port->buf.free;while ((*tbh) !=NULL ) {struct tty_buffer *t = *tbh;if (t->size >= size) { - *tbh = t->next; +if (prev ==NULL ) + *tbh = t->next; +else + prev->next = t->next; t->next =NULL ; t->used =0 ; t->commit =0 ;
@@ -189,6 +193,7 @@ static struct tty_buffer *tty_buffer_find(struct tty_port *port, size_t size) port->buf.memory_used += t->size;return t; } + prev = t; tbh = &((*tbh)->next); }/* Round the buffer size out */
Signature · 1 line
1.7.1