quick_dump: Add automagic DPIO register support
PATCH 1/3 quick_dump: Add automagic DPIO register support
From: Ville Syrjälä <[email protected]>
Repurpose the (currently unused) third element in the register definition tuple to indicate the type of the register. 'DPIO' is the only special register type for now.
--- tools/quick_dump/quick_dump.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
tools/quick_dump/quick_dump.py +4 -1
@@ -13,7 +13,10 @@ def parse_file(file): print('-' * 54) for line in file: register = ast.literal_eval(line) - val = reg.read(register[1]) + if register[2] == 'DPIO': + val = reg.dpio_read(register[1]) + else: + val = reg.read(register[1]) intreg = int(register[1], 16) print('{0:#010x} | {1:<28} | {2:#010x}'.format(intreg, register[0], val)) print('')
Signature · 6 lines
1.8.1.5 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 3/3 quick_dump: Add VLV DPIO registers
From: Ville Syrjälä <[email protected]>
Add the names of all VLV DPIO registers.
v2: Use the third element to signal DPIO registers, and split
the code changes to a separate patch
--- tools/quick_dump/Makefile.am | 2 +- tools/quick_dump/valleyview | 1 + tools/quick_dump/vlv_dpio.txt | 53 +++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 55 insertions(+), 1 deletion(-) create mode 100644 tools/quick_dump/vlv_dpio.txt
tools/quick_dump/Makefile.am +1 -1
@@ -25,7 +25,7 @@ EXTRA_DIST = \ base_display.txt base_interrupt.txt base_other.txt base_power.txt base_rings.txt \ gen6_other.txt sandybridge \ gen7_other.txt ivybridge \ - vlv_display.txt valleyview \ + vlv_display.txt vlv_dpio.txt valleyview \ quick_dump.py \ reg_access.py \ chipset.i chipset.py
tools/quick_dump/valleyview +1 -0
@@ -5,3 +5,4 @@ base_other.txt base_power.txt base_rings.txt gen7_other.txt +vlv_dpio.txt
tools/quick_dump/vlv_dpio.txt new file +53 -0
53 lines not on this page · raw message
Signature · 6 lines
1.8.1.5 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH i-g-t v2 3/3] quick_dump: Add VLV DPIO registers
Quoted 9 lines · On Wed, Jun 26, 2013 at 08:57:34PM +0300, [email protected] wrote:
From: Ville Syrjälä <[email protected]>
Add the names of all VLV DPIO registers.
v2: Use the third element to signal DPIO registers, and split
the code changes to a separate patchSigned-off-by Ville Syrjälä <[email protected]>
Series is:
Signature · 5 lines
Ben Widawsky, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/3 quick_dump: Document the register definition format
In reply to [email protected]From: Ville Syrjälä <[email protected]>
Add a small comment about what the elements in the register tuple mean.
--- tools/quick_dump/quick_dump.py | 7 +++++++ 1 file changed, 7 insertions(+)
tools/quick_dump/quick_dump.py +7 -0
@@ -1,5 +1,12 @@ #!/usr/bin/env python3 +# register definition format: +# ('register name', 'register offset', 'register type') +# +# register types: +# '' - normal register +# 'DPIO' - DPIO register + import argparse import os import sys
Signature · 6 lines
1.8.1.5 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 17 lines · On Wed, Jun 26, 2013 at 08:57:32PM +0300, [email protected] wrote:
From: Ville Syrjälä <[email protected]>
Repurpose the (currently unused) third element in the register definition tuple to indicate the type of the register. 'DPIO' is the only special register type for now.
Signed-off-by Ville Syrjälä <[email protected]>--- tools/quick_dump/quick_dump.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)tools/quick_dump/quick_dump.py +0
-0@@ -13,7 +13,10 @@ def parse_file(file): print('-' * 54)
tools/quick_dump/quick_dump.py def parse_file(file): · line 22
Quoted 10 lines
tools/quick_dump/quick_dump.py +4
-1for line in file: register = ast.literal_eval(line) - val = reg.read(register[1]) + if register[2] == 'DPIO': + val = reg.dpio_read(register[1]) + else: + val = reg.read(register[1]) intreg = int(register[1], 16) print('{0:#010x} | {1:<28} | {2:#010x}'.format(intreg, register[0], val)) print('')
I can't recall if you have push access, but I've pushed it.
Signature · 5 lines
Ben Widawsky, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx