f2fs: Remove the unused argument "sbi" of func destroy_fsync_dnodes()
PATCH 1/1 f2fs: Remove the unused argument "sbi" of func destroy_fsync_dnodes()
Destroy_fsync_dnodes() is a simple list-cleanup func, so delete the unused and unrelated f2fs_sb_info argument of it.
--- fs/f2fs/recovery.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)
fs/f2fs/recovery.c +2 -3
@@ -192,8 +192,7 @@ out:return err; } -static void destroy_fsync_dnodes (struct f2fs_sb_info *sbi, -struct list_head *head) +static void destroy_fsync_dnodes (struct list_head *head) {struct fsync_inode_entry *entry, *tmp;
@@ -438,7 +437,7 @@ int recover_fsync_data(struct f2fs_sb_info *sbi) err =recover_data (sbi, &inode_list,CURSEG_WARM_NODE );BUG_ON (!list_empty (&inode_list)); out: -destroy_fsync_dnodes (sbi, &inode_list); +destroy_fsync_dnodes (&inode_list);kmem_cache_destroy (fsync_entry_slab); sbi->por_doing =0 ;if (!err)
Signature · 8 lines
1.7.7 ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev
Hi Gu,
Could you check your email environment?
I can't merge your patch, since all the indentations consist of white spaces.
And also, please check 80 characters limit per line. Thanks,
2013-06-26 (수), 17:58 +0800, Gu Zheng:
Quoted 31 lines
Destroy_fsync_dnodes()is a simple list-cleanup func, so delete the unused and unrelatedf2fs_sb_infoargument of it.Signed-off-by Gu Zheng <[email protected]>--- fs/f2fs/recovery.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)fs/f2fs/recovery.c +2
-3@@ -192,8 +192,7 @@ out:return err; } -static void destroy_fsync_dnodes (struct f2fs_sb_info *sbi, -struct list_head *head) +static void destroy_fsync_dnodes (struct list_head *head) {struct fsync_inode_entry *entry, *tmp;@@ -438,7 +437,7 @@ int recover_fsync_data(struct f2fs_sb_info *sbi) err =recover_data (sbi, &inode_list,CURSEG_WARM_NODE );BUG_ON (!list_empty (&inode_list)); out: -destroy_fsync_dnodes (sbi, &inode_list); +destroy_fsync_dnodes (&inode_list);kmem_cache_destroy (fsync_entry_slab); sbi->por_doing =0 ;if (!err)
Signature · 15 lines
Jaegeuk Kim Samsung ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Quoted 7 lines · Jaegeuk Kim
Hi Gu,
Could you check your email environment?
I can't merge your patch, since all the indentations consist of white spaces.
And also, please check 80 characters limit per line. Thanks,
OK, thanks for your reminder.
Regards,
Gu
Quoted 24 lines
2013-06-26 (수), 17:58 +0800, Gu Zheng:
Quoted 22 lines
Destroy_fsync_dnodes()is a simple list-cleanup func, so delete the unused and unrelatedf2fs_sb_infoargument of it.Signed-off-by Gu Zheng <[email protected]>--- fs/f2fs/recovery.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)fs/f2fs/recovery.c +1
-2@@ -192,8 +192,7 @@ out:return err; } -static void destroy_fsync_dnodes (struct f2fs_sb_info *sbi, -struct list_head *head) +static void destroy_fsync_dnodes (struct list_head *head) {struct fsync_inode_entry *entry, *tmp;
Quoted 10 lines
fs/f2fs/recovery.c int recover_fsync_data(struct f2fs_sb_info *sbi) · line 443
Quoted 9 lines
fs/f2fs/recovery.c +1
-1@@ -438,7 +437,7 @@ int recover_fsync_data(struct f2fs_sb_info *sbi) err =recover_data (sbi, &inode_list,CURSEG_WARM_NODE );BUG_ON (!list_empty (&inode_list)); out: -destroy_fsync_dnodes (sbi, &inode_list); +destroy_fsync_dnodes (&inode_list);kmem_cache_destroy (fsync_entry_slab); sbi->por_doing =0 ;if (!err)
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel