drivers: net: cpsw: add newline after MACID log

PATCH Applied Daniel Mack 3 participants 3 messages Jun 27, 2013 – Jun 29, 2013

Subsystems (3)

Networking Network drivers TI Ethernet switch driver (cpsw)

lore

Share & tools

lore

Daniel Mack

author

2013-06-27 09:46 UTC #0 lore raw

PATCH 1/1 drivers: net: cpsw: add newline after MACID log

Cosmetic patch to add a newline after logging the device's MACID.

Signed-off-by Daniel Mack <[email protected]>

---
 drivers/net/ethernet/ti/cpsw.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/net/ethernet/ti/cpsw.c +2 -2

index d1a769f..e10328d 100644
@@ -1698,10 +1698,10 @@ static int cpsw_probe(struct platform_device *pdev)
 
 	if (is_valid_ether_addr(data->slave_data[0].mac_addr)) {
 		memcpy(priv->mac_addr, data->slave_data[0].mac_addr, ETH_ALEN);
-		pr_info("Detected MACID = %pM", priv->mac_addr);
+		pr_info("Detected MACID = %pM\n", priv->mac_addr);
 	} else {
 		eth_random_addr(priv->mac_addr);
-		pr_info("Random MACID = %pM", priv->mac_addr);
+		pr_info("Random MACID = %pM\n", priv->mac_addr);
 	}
 
 	memcpy(ndev->dev_addr, priv->mac_addr, ETH_ALEN);

Signature · 1 line

1.8.1.4

Mugunthan V N

Acked-by on v1 1/1

2013-06-27 09:52 UTC #1 lore raw

Quoted 14 lines · Daniel Mack

Cosmetic patch to add a newline after logging the device's MACID.
Signed-off-by Daniel Mack <[email protected]>
---
  drivers/net/ethernet/ti/cpsw.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/ti/cpsw.c +0 -0
index d1a769f..e10328d 100644
@@ -1698,10 +1698,10 @@ static int cpsw_probe(struct platform_device *pdev)
 
  	if (is_valid_ether_addr(data->slave_data[0].mac_addr)) {

drivers/net/ethernet/ti/cpsw.c static int cpsw_probe(struct platform_device *pdev) · line 1707

Quoted 10 lines

drivers/net/ethernet/ti/cpsw.c +2 -2

  		memcpy(priv->mac_addr, data->slave_data[0].mac_addr, ETH_ALEN);
-		pr_info("Detected MACID = %pM", priv->mac_addr);
+		pr_info("Detected MACID = %pM\n", priv->mac_addr);
  	} else {
  		eth_random_addr(priv->mac_addr);
-		pr_info("Random MACID = %pM", priv->mac_addr);
+		pr_info("Random MACID = %pM\n", priv->mac_addr);
  	}
 
  	memcpy(ndev->dev_addr, priv->mac_addr, ETH_ALEN);

Acked-by Mugunthan V N <[email protected]>

Regards
Mugunthan V N

David Miller

maintainer Applied

2013-06-29 04:39 UTC #2 lore raw

From: Mugunthan V N <[email protected]>
Date: Thu, 27 Jun 2013 15:21:53 +0530

Quoted 4 lines · Daniel Mack

Quoted 3 lines
Cosmetic patch to add a newline after logging the device's MACID.
Signed-off-by Daniel Mack <[email protected]>

...

Quoted 1 line

Acked-by Mugunthan V N <[email protected]>

Applied, thanks.