powerpc/T4240EMU: Add T4240EMU target

PATCH Superseded York Sun 3 participants 7 messages Jun 26, 2013 – Jun 27, 2013

Share & tools

York Sun

author

2013-06-26 16:17 UTC #0 lore raw

PATCH v2 6/11 powerpc/T4240EMU: Add T4240EMU target

Add emulator support for T4240. Emulator has limited peripherals and interfaces. Difference between emulator and T4240QDS includes:
ECC for DDR is disabled due the procedure to load images No board FPGA (QIXIS)
NOR flash has 32-bit port for higher loading speed IFC and I2C timing don't really matter, so set them fast No ethernet

Signed-off-by York Sun <[email protected]>

---
 MAINTAINERS                      |    4 +
 board/freescale/t4qds/Makefile   |    3 +-
 board/freescale/t4qds/ddr.c      |   73 +---
 board/freescale/t4qds/ddr.h      |  122 ++++++
 board/freescale/t4qds/law.c      |    2 +
 board/freescale/t4qds/t4240emu.c |   96 +++++
 board/freescale/t4qds/t4240qds.c |  854 ++++++++++++++++++++++++++++++++++++++
 board/freescale/t4qds/t4qds.c    |  853 -------------------------------------
 board/freescale/t4qds/tlb.c      |    3 +-
 boards.cfg                       |    1 +
 include/configs/T4240EMU.h       |  185 +++++++++
 include/configs/T4240QDS.h       |  539 ++++++++++++++++++++++++
 include/configs/t4qds.h          |  482 +--------------------
 13 files changed, 1810 insertions(+), 1407 deletions(-)
 create mode 100644 board/freescale/t4qds/ddr.h
 create mode 100644 board/freescale/t4qds/t4240emu.c
 create mode 100644 board/freescale/t4qds/t4240qds.c
 delete mode 100644 board/freescale/t4qds/t4qds.c
 create mode 100644 include/configs/T4240EMU.h

MAINTAINERS +4 -0

index 7820375..480b647 100644
@@ -538,6 +538,10 @@ Detlev Zundel <[email protected]>
 
 	inka4x0		MPC5200
 
+York Sun <[email protected]>
+
+	T4240EMU	T4240
+
 -------------------------------------------------------------------------
 
 Unknown / orphaned boards:

board/freescale/t4qds/Makefile +2 -1

index ff09ffa..1923a47 100644
@@ -24,7 +24,8 @@ include $(TOPDIR)/config.mk
 
 LIB	= $(obj)lib$(BOARD).o
 
-COBJS-y	+= $(BOARD).o
+COBJS-$(CONFIG_T4240QDS) += t4240qds.o
+COBJS-$(CONFIG_T4240EMU) += t4240emu.o
 COBJS-y	+= ddr.o
 COBJS-$(CONFIG_T4240QDS)+= eth.o
 COBJS-$(CONFIG_PCI)	+= pci.o

board/freescale/t4qds/ddr.c +1 ~~-72~~

82 lines not on this page · raw message

board/freescale/t4qds/ddr.h new file +122 -0

122 lines not on this page · raw message

board/freescale/t4qds/law.c +2 -0

index f3848f3..7e41556 100644
@@ -35,7 +35,9 @@ struct law_entry law_table[] = {
 #ifdef CONFIG_SYS_QMAN_MEM_PHYS
 	SET_LAW(CONFIG_SYS_QMAN_MEM_PHYS, LAW_SIZE_32M, LAW_TRGT_IF_QMAN),
 #endif
+#ifdef QIXIS_BASE_PHYS
 	SET_LAW(QIXIS_BASE_PHYS, LAW_SIZE_4K, LAW_TRGT_IF_IFC),
+#endif
 #ifdef CONFIG_SYS_DCSRBAR_PHYS
 	/* Limit DCSR to 32M to access NPC Trace Buffer */
 	SET_LAW(CONFIG_SYS_DCSRBAR_PHYS, LAW_SIZE_32M, LAW_TRGT_IF_DCSR),

board/freescale/t4qds/t4240emu.c new file +96 -0

96 lines not on this page · raw message

board/freescale/t4qds/t4240qds.c new file +854 -0

854 lines not on this page · raw message

board/freescale/t4qds/t4qds.c deleted +0 ~~-853~~

853 lines not on this page · raw message

board/freescale/t4qds/tlb.c +2 -1

index 92c01cf..08bf1f0 100644
@@ -127,10 +127,11 @@ struct fsl_e_tlb_entry tlb_table[] = {
 			MAS3_SX|MAS3_SW|MAS3_SR, MAS2_I|MAS2_G,
 			0, 16, BOOKE_PAGESZ_64K, 1),
 #endif
+#ifdef QIXIS_BASE_PHYS
 	SET_TLB_ENTRY(1, QIXIS_BASE, QIXIS_BASE_PHYS,
 		      MAS3_SX|MAS3_SW|MAS3_SR, MAS2_I|MAS2_G,
 		      0, 17, BOOKE_PAGESZ_4K, 1),
-
+#endif
 };
 
 int num_tlb_entries = ARRAY_SIZE(tlb_table);

boards.cfg +1 -0

index 1e598cb..6a1d56b 100644
@@ -910,6 +910,7 @@ stxgp3                       powerpc     mpc85xx     stxgp3              stx
 stxssa                       powerpc     mpc85xx     stxssa              stx            -           stxssa
 stxssa_4M                    powerpc     mpc85xx     stxssa              stx            -           stxssa:STXSSA_4M
 T4240QDS                     powerpc     mpc85xx     t4qds               freescale      -           T4240QDS:PPC_T4240
+T4240EMU                     powerpc     mpc85xx     t4qds               freescale	-           T4240EMU:PPC_T4240
 T4240QDS_SDCARD              powerpc     mpc85xx     t4qds               freescale	-           T4240QDS:PPC_T4240,RAMBOOT_PBL,SDCARD,SYS_TEXT_BASE=0xFFF80000
 T4240QDS_SPIFLASH            powerpc     mpc85xx     t4qds               freescale	-           T4240QDS:PPC_T4240,RAMBOOT_PBL,SPIFLASH,SYS_TEXT_BASE=0xFFF80000
 T4160QDS                     powerpc     mpc85xx     t4qds               freescale      -           T4240QDS:PPC_T4160

include/configs/T4240EMU.h new file +185 -0

185 lines not on this page · raw message

include/configs/T4240QDS.h +539 -0

549 lines not on this page · raw message

include/configs/t4qds.h +2 ~~-480~~

212 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line

1.7.9.5

Part of the diff is not shown here. View the raw message.

Wolfgang Denk

2013-06-26 22:03 UTC #1 lore raw

PATCH v2 6/11 powerpc/T4240EMU: Add T4240EMU target

Dear York Sun,

Quoted 10 lines · In message <[email protected]> you wrote:

Add emulator support for T4240. Emulator has limited peripherals and interfaces. Difference between emulator and T4240QDS includes:
ECC for DDR is disabled due the procedure to load images No board FPGA (QIXIS)
NOR flash has 32-bit port for higher loading speed IFC and I2C timing don't really matter, so set them fast No ethernet
Signed-off-by York Sun <[email protected]>
---

So what exactly are the changes compared to V1?

MAINTAINERS Detlev Zundel <[email protected]> · line 544

Quoted 10 lines

MAINTAINERS +4 -0

@@ -538,6 +538,10 @@ Detlev Zundel <[email protected]>
 
 	inka4x0		MPC5200
 
+York Sun <[email protected]>
+
+	T4240EMU	T4240
+

Can you please keep the list sorted? Thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Vor allem kein Gedanke! Nichts ist kompromittierender als ein  Gedan-
ke!            - Friedrich Wilhelm Nietzsche _Der Fall Wagner_ (1888)

York Sun

author

2013-06-27 17:30 UTC #2 lore raw

PATCH v2 6/11 powerpc/T4240EMU: Add T4240EMU target

Quoted 11 lines · Wolfgang Denk

Dear York Sun,
Quoted 8 lines · In message <[email protected]> you wrote:
Add emulator support for T4240. Emulator has limited peripherals and interfaces. Difference between emulator and T4240QDS includes:
ECC for DDR is disabled due the procedure to load images No board FPGA (QIXIS)
NOR flash has 32-bit port for higher loading speed IFC and I2C timing don't really matter, so set them fast No ethernet

Quoted 4 lines

Quoted 2 lines
Signed-off-by York Sun <[email protected]>
---
So what exactly are the changes compared to V1?

Added entry to MAINTAINERS

Fixed checkpatch warning
- WARNING: quoted string split across lines
- WARNING: Avoid unnecessary line continuations

Quoted 5 lines

Quoted 5 lines
MAINTAINERS +0 -0
@@ -538,6 +538,10 @@ Detlev Zundel <[email protected]>
 

Quoted 8 lines

MAINTAINERS Detlev Zundel <[email protected]> · line 544
Quoted 6 lines
MAINTAINERS +4 -0
 	inka4x0		MPC5200
 
+York Sun <[email protected]>
+
+	T4240EMU	T4240
+
Can you please keep the list sorted? Thanks.

The list is not sorted. I tried with my best guess, sort on "CPU". That's why I put it at the end of "PowerPC Systems".

York

Scott Wood

2013-06-27 17:35 UTC #3 lore raw

PATCH v2 6/11 powerpc/T4240EMU: Add T4240EMU target

Quoted 15 lines · York Sun

Quoted 5 lines · Wolfgang Denk
Quoted 5 lines
MAINTAINERS +0 -0
@@ -538,6 +538,10 @@ Detlev Zundel <[email protected]>
 
Quoted 8 lines
MAINTAINERS Detlev Zundel <[email protected]> · line 544
Quoted 6 lines
MAINTAINERS +4 -0
 	inka4x0		MPC5200
 
+York Sun <[email protected]>
+
+	T4240EMU	T4240
+
Can you please keep the list sorted? Thanks.

Quoted 2 lines

The list is not sorted. I tried with my best guess, sort on "CPU". That's why I put it at the end of "PowerPC Systems".

It is sorted by maintainer name (as noted at the top of the file) within each architecture section.

-Scott

York Sun

author

2013-06-27 17:40 UTC #4 lore raw

PATCH v2 6/11 powerpc/T4240EMU: Add T4240EMU target

Quoted 16 lines · Scott Wood

Quoted 15 lines · York Sun
Quoted 13 lines · Wolfgang Denk
MAINTAINERS Detlev Zundel <[email protected]> · line 544
Quoted 11 lines
MAINTAINERS +4 -0
@@ -538,6 +538,10 @@ Detlev Zundel <[email protected]>
 
     inka4x0        MPC5200
 
+York Sun <[email protected]>
+
+    T4240EMU    T4240
+
Can you please keep the list sorted? Thanks.

Quoted 6 lines

Quoted 2 lines
The list is not sorted. I tried with my best guess, sort on "CPU". That's why I put it at the end of "PowerPC Systems".
It is sorted by maintainer name (as noted at the top of the file) within each architecture section.

Thanks.

York

Wolfgang Denk

2013-06-27 17:51 UTC #5 lore raw

PATCH v2 6/11 powerpc/T4240EMU: Add T4240EMU target

In reply to York Sun

Dear York Sun,

Quoted 8 lines · In message <[email protected]> you wrote:

Quoted 2 lines
So what exactly are the changes compared to V1?
Added entry to MAINTAINERS
Fixed checkpatch warning
- WARNING: quoted string split across lines
- WARNING: Avoid unnecessary line continuations

And why do you not include this information with the patch? You've been around here long enough that you should know this requirement.

Quoted 13 lines

Quoted 4 lines
Quoted 4 lines
MAINTAINERS +0 -0
@@ -538,6 +538,10 @@ Detlev Zundel <[email protected]>
 
Quoted 8 lines
MAINTAINERS Detlev Zundel <[email protected]> · line 544
Quoted 6 lines
MAINTAINERS +4 -0
 	inka4x0		MPC5200
 
+York Sun <[email protected]>
+
+	T4240EMU	T4240
+
Can you please keep the list sorted? Thanks.

Quoted 2 lines

The list is not sorted. I tried with my best guess, sort on "CPU". That's why I put it at the end of "PowerPC Systems".

The list IS sorted. The sort key is the last name of the maintainer. "Sun" clearly sorts before "Zundel".

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Be careful what you wish for. You never know who will be listening.
                                      - Terry Pratchett, _Soul Music_

York Sun

author

2013-06-27 17:57 UTC #6 lore raw

PATCH v2 6/11 powerpc/T4240EMU: Add T4240EMU target

Quoted 6 lines · Wolfgang Denk

Dear York Sun,
Quoted 3 lines · In message <[email protected]> you wrote:
Quoted 2 lines
So what exactly are the changes compared to V1?

Quoted 8 lines

Quoted 5 lines
Added entry to MAINTAINERS
Fixed checkpatch warning
- WARNING: quoted string split across lines
- WARNING: Avoid unnecessary line continuations
And why do you not include this information with the patch? You've been around here long enough that you should know this requirement.

I forgot. Updated in v3 patch.

Quoted 14 lines

Quoted 14 lines
Quoted 13 lines
MAINTAINERS Detlev Zundel <[email protected]> · line 544
Quoted 11 lines
MAINTAINERS +4 -0
@@ -538,6 +538,10 @@ Detlev Zundel <[email protected]>
 
 	inka4x0		MPC5200
 
+York Sun <[email protected]>
+
+	T4240EMU	T4240
+
Can you please keep the list sorted? Thanks.

Quoted 5 lines

Quoted 2 lines
The list is not sorted. I tried with my best guess, sort on "CPU". That's why I put it at the end of "PowerPC Systems".
The list IS sorted. The sort key is the last name of the maintainer. "Sun" clearly sorts before "Zundel".

Got it. Updated in v3 patch.

York