p1020rdb-pd: platform support

PATCH New Haijun.Zhang 3 participants 7 messages Apr 28, 2013 – Jun 28, 2013

lore

Share & tools

lore

Haijun.Zhang

author

2013-04-28 06:17 UTC #0 lore raw

PATCH 1/1 p1020rdb-pd: platform support

From: "Haijun.Zhang" <[email protected]>

Add platform support for p1020rdb-pd

Signed-off-by Jerry Huang <[email protected]>

Signed-off-by Haijun Zhang <[email protected]>

CC Sun Yusong-R58495 <[email protected]>

CC u-boot at lists.denx.de

---
 board/freescale/p1_p2_rdb_pc/ddr.c |  2 +-
 boards.cfg                         |  4 ++++
 include/configs/p1_p2_rdb_pc.h     | 19 +++++++++++++++++--
 3 files changed, 22 insertions(+), 3 deletions(-)

board/freescale/p1_p2_rdb_pc/ddr.c +1 -1

index 9355536..262fd36 100644
@@ -80,7 +80,7 @@ dimm_params_t ddr_raw_timing = {
 	.refresh_rate_ps = 7800000,
 	.tFAW_ps = 30000,
 };
-#elif defined(CONFIG_P1020MBG)
+#elif (defined(CONFIG_P1020MBG) || defined(CONFIG_P1020RDB_PD))
 /* Micron MT41J512M8_187E */
 dimm_params_t ddr_raw_timing = {
 	.n_ranks = 2,

boards.cfg +4 -0

index 79ee5e7..a855348 100644
@@ -772,6 +772,10 @@ P1020RDB-PC_SDCARD           powerpc     mpc85xx     p1_p2_rdb_pc        freesca
 P1020RDB-PC_SPIFLASH         powerpc     mpc85xx     p1_p2_rdb_pc        freescale      -           p1_p2_rdb_pc:P1020RDB,SPIFLASH
 P1020RDB_SDCARD              powerpc     mpc85xx     p1_p2_rdb           freescale      -           P1_P2_RDB:P1020RDB,SDCARD
 P1020RDB_SPIFLASH            powerpc     mpc85xx     p1_p2_rdb           freescale      -           P1_P2_RDB:P1020RDB,SPIFLASH
+P1020RDB-PD                  powerpc     mpc85xx     p1_p2_rdb_pc        freescale      -           p1_p2_rdb_pc:P1020RDB_PD
+P1020RDB-PD_NAND             powerpc     mpc85xx     p1_p2_rdb_pc        freescale      -           p1_p2_rdb_pc:P1020RDB_PD,NAND
+P1020RDB-PD_SDCARD           powerpc     mpc85xx     p1_p2_rdb_pc        freescale      -           p1_p2_rdb_pc:P1020RDB_PD,SDCARD
+P1020RDB-PD_SPIFLASH         powerpc     mpc85xx     p1_p2_rdb_pc        freescale      -           p1_p2_rdb_pc:P1020RDB_PD,SPIFLASH
 P1020UTM-PC                  powerpc     mpc85xx     p1_p2_rdb_pc        freescale      -           p1_p2_rdb_pc:P1020UTM
 P1020UTM-PC_36BIT            powerpc     mpc85xx     p1_p2_rdb_pc        freescale      -           p1_p2_rdb_pc:P1020UTM,36BIT
 P1020UTM-PC_36BIT_SDCARD     powerpc     mpc85xx     p1_p2_rdb_pc        freescale      -           p1_p2_rdb_pc:P1020UTM,36BIT,SDCARD

include/configs/p1_p2_rdb_pc.h +17 -2

index 1a8ea3a..d65c5b7 100644
@@ -50,8 +50,12 @@
 #define CONFIG_SYS_L2_SIZE	(256 << 10)
 #endif
 
+#if (defined(CONFIG_P1020RDB) || defined(CONFIG_P1020RDB_PD))
 #if defined(CONFIG_P1020RDB)
 #define CONFIG_BOARDNAME "P1020RDB-PC"
+#elif defined(CONFIG_P1020RDB_PD)
+#define CONFIG_BOARDNAME "P1020RDB-PD"
+#endif
 #define CONFIG_NAND_FSL_ELBC
 #define CONFIG_P1020
 #define CONFIG_SPI_FLASH

@@ -278,7 +282,7 @@
 #define SPD_EEPROM_ADDRESS 0x52
 #undef CONFIG_FSL_DDR_INTERACTIVE
 
-#ifdef CONFIG_P1020MBG
+#if (defined(CONFIG_P1020MBG) || defined(CONFIG_P1020RDB_PD))
 #define CONFIG_SYS_SDRAM_SIZE_LAW	LAW_SIZE_2G
 #define CONFIG_CHIP_SELECTS_PER_CTRL	2
 #else

@@ -349,7 +353,7 @@
 /*
  * Local Bus Definitions
  */
-#if defined(CONFIG_P1020MBG)
+#if (defined(CONFIG_P1020MBG) || defined(CONFIG_P1020RDB_PD))
 #define CONFIG_SYS_MAX_FLASH_SECT	512	/* 64M */
 #define CONFIG_SYS_FLASH_BASE		0xec000000
 #elif defined(CONFIG_P1020UTM)

@@ -407,6 +411,16 @@
 	| BR_PS_8	/* Port Size = 8 bit */ \
 	| BR_MS_FCM	/* MSEL = FCM */ \
 	| BR_V)	/* valid */
+#if defined(CONFIG_P1020RDB_PD)
+#define CONFIG_SYS_NAND_OR_PRELIM	(OR_AM_32KB \
+	| OR_FCM_PGS	/* Large Page*/ \
+	| OR_FCM_CSCT \
+	| OR_FCM_CST \
+	| OR_FCM_CHT \
+	| OR_FCM_SCY_1 \
+	| OR_FCM_TRLX \
+	| OR_FCM_EHTR)
+#else
 #define CONFIG_SYS_NAND_OR_PRELIM	(OR_AM_32KB	/* small page */ \
 	| OR_FCM_CSCT \
 	| OR_FCM_CST \

@@ -414,6 +428,7 @@
 	| OR_FCM_SCY_1 \
 	| OR_FCM_TRLX \
 	| OR_FCM_EHTR)
+#endif
 #endif /* CONFIG_NAND_FSL_ELBC */
 
 #define CONFIG_BOARD_EARLY_INIT_R	/* call board_early_init_r function */

Signature · 1 line

1.8.0

Scott Wood

2013-05-21 22:23 UTC #1 lore raw

PATCH 1/1 p1020rdb-pd: platform support

Quoted 3 lines · Haijun.Zhang

From: "Haijun.Zhang" <[email protected]>
Add platform support for p1020rdb-pd

Explain what is different about "-pd" and why this new revision requires a separate compile-time target.

If it's due to raw DDR config, say so in the changelog. Is there any way we could read a revision register to select the proper DDR config at runtime?

If it's due to different NAND page size, that will no longer be an issue once this is applied:
http://patchwork.ozlabs.org/patch/223436/

include/configs/p1_p2_rdb_pc.h line 58

Quoted 6 lines

include/configs/p1_p2_rdb_pc.h +4 -0

+#if (defined(CONFIG_P1020RDB) || defined(CONFIG_P1020RDB_PD))
 #if defined(CONFIG_P1020RDB)
 #define CONFIG_BOARDNAME "P1020RDB-PC"
+#elif defined(CONFIG_P1020RDB_PD)
+#define CONFIG_BOARDNAME "P1020RDB-PD"
+#endif

CONFIG_P1020RDB is not a good name to mean specifically the -PC revision. Change it so that CONFIG_P1020RDB is set for all revisions of P1020RDB, and introduce CONFIG_P1020RDB-PC for PC-specific things.

-Scott

Zhang Haijun-B42677

2013-06-27 08:58 UTC #2 lore raw

PATCH 1/1 p1020rdb-pd: platform support

Hi, Scott

Sorry to reply to so late.
Pls see my reply below.

Regards & Thanks
Haijun.

Quoted 8 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, May 22, 2013 6:24 AM
To: Zhang Haijun-B42677
Cc: Fleming Andy-AFLEMING; u-boot at lists.denx.de; Huang Changming-R66093; Zhang Haijun-B42677; Zhang Haijun-B42677; sun york-R58495
Subject: Re: [U-Boot] [PATCH] p1020rdb-pd: platform support

Quoted 8 lines

Quoted 3 lines · Haijun.Zhang
From: "Haijun.Zhang" <[email protected]>
Add platform support for p1020rdb-pd
Explain what is different about "-pd" and why this new revision requires a separate compile-time target.

[Haijun Wrote:] We use P1020RDB-PD to instead of P1020RDB-PC board later on. They are all supported. Nand, DDR, Nor and Spi Flash are different between them. So I thinks they should be two separate board as P1020UTM and P1020MBG do.

Quoted 3 lines

If it's due to raw DDR config, say so in the changelog. Is there any way we could read a revision register to select the proper DDR config at runtime?

[Haijun Wrote:] Now we read DDR config from SPD fist, if not found read from config file.

Quoted 17 lines

If it's due to different NAND page size, that will no longer be an issue once this is applied:
http://patchwork.ozlabs.org/patch/223436/
include/configs/p1_p2_rdb_pc.h line 58
Quoted 6 lines
include/configs/p1_p2_rdb_pc.h +4 -0
+#if (defined(CONFIG_P1020RDB) || defined(CONFIG_P1020RDB_PD))
 #if defined(CONFIG_P1020RDB)
 #define CONFIG_BOARDNAME "P1020RDB-PC"
+#elif defined(CONFIG_P1020RDB_PD)
+#define CONFIG_BOARDNAME "P1020RDB-PD"
+#endif
CONFIG_P1020RDB is not a good name to mean specifically the -PC revision. Change it so that CONFIG_P1020RDB is set for all revisions of P1020RDB, and introduce CONFIG_P1020RDB-PC for PC-specific things.
-Scott

Scott Wood

2013-06-27 20:10 UTC #3 lore raw

PATCH 1/1 p1020rdb-pd: platform support

Quoted 25 lines · On 06/27/2013 03:58:57 AM, Zhang Haijun-B42677 wrote:

Hi, Scott
Sorry to reply to so late.
Pls see my reply below.
Regards & Thanks
Haijun.
Quoted 5 lines
-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, May 22, 2013 6:24 AM
To: Zhang Haijun-B42677
Cc: Fleming Andy-AFLEMING; u-boot at lists.denx.de; Huang
Changming-R66093;
Quoted 9 lines
Zhang Haijun-B42677; Zhang Haijun-B42677; sun york-R58495
Subject: Re: [U-Boot] [PATCH] p1020rdb-pd: platform support
Quoted 3 lines · Haijun.Zhang
From: "Haijun.Zhang" <[email protected]>
Add platform support for p1020rdb-pd
Explain what is different about "-pd" and why this new revision
requires

Quoted 8 lines

Quoted 2 lines
a separate compile-time target.
[Haijun Wrote:] We use P1020RDB-PD to instead of P1020RDB-PC board later on.
They are all supported. Nand, DDR, Nor and Spi Flash are different between them.
So I thinks they should be two separate board as P1020UTM and P1020MBG do.

Put this information in the changelog.

Quoted 6 lines

Quoted 1 line
If it's due to raw DDR config, say so in the changelog. Is there
any way
Quoted 2 lines
we could read a revision register to select the proper DDR config at runtime?
[Haijun Wrote:] Now we read DDR config from SPD fist, if not found read from config file.

Is there any reason why SPD would not be found?

Quoted 8 lines

Quoted 8 lines
include/configs/p1_p2_rdb_pc.h line 58
Quoted 6 lines
include/configs/p1_p2_rdb_pc.h +4 -0
+#if (defined(CONFIG_P1020RDB) || defined(CONFIG_P1020RDB_PD))
 #if defined(CONFIG_P1020RDB)
 #define CONFIG_BOARDNAME "P1020RDB-PC"
+#elif defined(CONFIG_P1020RDB_PD)
+#define CONFIG_BOARDNAME "P1020RDB-PD"
+#endif
CONFIG_P1020RDB is not a good name to mean specifically the -PC

Quoted 4 lines

revision.
Quoted 1 line
Change it so that CONFIG_P1020RDB is set for all revisions of
P1020RDB,
Quoted 1 line
and introduce CONFIG_P1020RDB-PC for PC-specific things.

Could you reply to this one?

...and of course I meant CONFIG_P1020RDB_PC rather than CONFIG_P1020RDB-PC. :-)

-Scott

Zhang Haijun-B42677

2013-06-28 01:55 UTC #4 lore raw

PATCH 1/1 p1020rdb-pd: platform support

Regards
Haijun.

Quoted 36 lines

-----Original Message-----
From: Wood Scott-B07421
Sent: Friday, June 28, 2013 4:10 AM
To: Zhang Haijun-B42677
Cc: Wood Scott-B07421; Fleming Andy-AFLEMING; u-boot at lists.denx.de; Huang Changming-R66093; sun york-R58495
Subject: Re: [U-Boot] [PATCH] p1020rdb-pd: platform support
Quoted 27 lines · On 06/27/2013 03:58:57 AM, Zhang Haijun-B42677 wrote:
Hi, Scott
Sorry to reply to so late.
Pls see my reply below.
Regards & Thanks
Haijun.
Quoted 5 lines
-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, May 22, 2013 6:24 AM
To: Zhang Haijun-B42677
Cc: Fleming Andy-AFLEMING; u-boot at lists.denx.de; Huang
Changming-R66093;
Quoted 9 lines
Zhang Haijun-B42677; Zhang Haijun-B42677; sun york-R58495
Subject: Re: [U-Boot] [PATCH] p1020rdb-pd: platform support
Quoted 3 lines · Haijun.Zhang
From: "Haijun.Zhang" <[email protected]>
Add platform support for p1020rdb-pd
Explain what is different about "-pd" and why this new revision
requires
Quoted 2 lines
a separate compile-time target.

Quoted 8 lines

Quoted 6 lines
[Haijun Wrote:] We use P1020RDB-PD to instead of P1020RDB-PC board later on.
They are all supported. Nand, DDR, Nor and Spi Flash are different between them.
So I thinks they should be two separate board as P1020UTM and P1020MBG do.
Put this information in the changelog.

[Haijun Wrote:] change log you mean?

Quoted 9 lines

Quoted 7 lines
Quoted 2 lines
If it's due to raw DDR config, say so in the changelog. Is there
any way
Quoted 2 lines
we could read a revision register to select the proper DDR config at runtime?
[Haijun Wrote:] Now we read DDR config from SPD fist, if not found read from config file.
Is there any reason why SPD would not be found?

[Haijun Wrote:] If someone erase the I2C area(SPD EEPROM) by mistake or change by other possible reason. They will need to read from local config file to make sure uboot can working.

Quoted 10 lines

Quoted 10 lines
Quoted 9 lines
include/configs/p1_p2_rdb_pc.h line 58
Quoted 7 lines
include/configs/p1_p2_rdb_pc.h +4 -0
+#if (defined(CONFIG_P1020RDB) || defined(CONFIG_P1020RDB_PD))
 #if defined(CONFIG_P1020RDB)
 #define CONFIG_BOARDNAME "P1020RDB-PC"
+#elif defined(CONFIG_P1020RDB_PD) #define CONFIG_BOARDNAME
+"P1020RDB-PD"
+#endif
CONFIG_P1020RDB is not a good name to mean specifically the -PC
revision.

Quoted 8 lines

Quoted 3 lines
Quoted 1 line
Change it so that CONFIG_P1020RDB is set for all revisions of
P1020RDB,
Quoted 1 line
and introduce CONFIG_P1020RDB-PC for PC-specific things.
Could you reply to this one?
...and of course I meant CONFIG_P1020RDB_PC rather than CONFIG_P1020RDB- PC. :-)

[Haijun Wrote:] Oh, yes I agree. It a little strange to have "-PD", but this patch was aim at add new board p1020rdb-pd board. If need i'll send another patch to change the config name for PC,RDB and PD. I had send another patch(Mean v2 of this patch), pls give some advice.
Thanks in advance.

Quoted 2 lines

-Scott

-------------- next part --------------
An embedded message was scrubbed...
From: Zhang Haijun-B42677 <[email protected]>
Subject: [PATCH] p1020rdb-pd: platform support
Date: Thu, 27 Jun 2013 07:44:02 +0000
Size: 7764
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130628/5ed8e1c4/attachment.eml>

Scott Wood

2013-06-28 02:13 UTC #5 lore raw

PATCH 1/1 p1020rdb-pd: platform support

Quoted 42 lines · On 06/27/2013 08:55:26 PM, Zhang Haijun-B42677 wrote:

Quoted 5 lines
-----Original Message-----
From: Wood Scott-B07421
Sent: Friday, June 28, 2013 4:10 AM
To: Zhang Haijun-B42677
Cc: Wood Scott-B07421; Fleming Andy-AFLEMING; u-boot at lists.denx.de;
Huang
Quoted 36 lines
Changming-R66093; sun york-R58495
Subject: Re: [U-Boot] [PATCH] p1020rdb-pd: platform support
Quoted 32 lines · On 06/27/2013 03:58:57 AM, Zhang Haijun-B42677 wrote:
Hi, Scott
Sorry to reply to so late.
Pls see my reply below.
Regards & Thanks
Haijun.
Quoted 5 lines
-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, May 22, 2013 6:24 AM
To: Zhang Haijun-B42677
Cc: Fleming Andy-AFLEMING; u-boot at lists.denx.de; Huang
Changming-R66093;
Quoted 9 lines
Zhang Haijun-B42677; Zhang Haijun-B42677; sun york-R58495
Subject: Re: [U-Boot] [PATCH] p1020rdb-pd: platform support
Quoted 3 lines · Haijun.Zhang
From: "Haijun.Zhang" <[email protected]>
Add platform support for p1020rdb-pd
Explain what is different about "-pd" and why this new revision
requires
Quoted 2 lines
a separate compile-time target.
[Haijun Wrote:] We use P1020RDB-PD to instead of P1020RDB-PC board later on.
They are all supported. Nand, DDR, Nor and Spi Flash are different between them.
So I thinks they should be two separate board as P1020UTM and

Quoted 5 lines

P1020MBG
Quoted 3 lines
Quoted 1 line
do.
Put this information in the changelog.
[Haijun Wrote:] change log you mean?

The git commit message.

Quoted 6 lines

Quoted 1 line
Quoted 1 line
Quoted 1 line
If it's due to raw DDR config, say so in the changelog. Is
there
Quoted 2 lines
Quoted 2 lines
any way
Quoted 1 line
we could read a revision register to select the proper DDR
config at
Quoted 1 line
Quoted 1 line
Quoted 1 line
runtime?

Quoted 8 lines

Quoted 4 lines
Quoted 2 lines
[Haijun Wrote:] Now we read DDR config from SPD fist, if not found read from config file.
Is there any reason why SPD would not be found?
[Haijun Wrote:] If someone erase the I2C area(SPD EEPROM) by mistake or change by other possible reason.
They will need to read from local config file to make sure uboot can working.

I don't think we normally provide backup DDR config for such a case. There are many other, easier ways the user can accidentally screw up the system (e.g. they could erase U-Boot). And it would get little to no testing, so likely bitrot or otherwise not work (e.g. the board starts shipping with different RAM, or the settings were never quite right to begin with).

Quoted 15 lines

Quoted 15 lines
Quoted 8 lines
Quoted 8 lines
include/configs/p1_p2_rdb_pc.h line 58
Quoted 6 lines
include/configs/p1_p2_rdb_pc.h +4 -0
+#if (defined(CONFIG_P1020RDB) || defined(CONFIG_P1020RDB_PD))
 #if defined(CONFIG_P1020RDB)
 #define CONFIG_BOARDNAME "P1020RDB-PC"
+#elif defined(CONFIG_P1020RDB_PD) #define CONFIG_BOARDNAME
+"P1020RDB-PD"
+#endif
CONFIG_P1020RDB is not a good name to mean specifically the -PC
Quoted 4 lines
revision.
Quoted 1 line
Change it so that CONFIG_P1020RDB is set for all revisions of
P1020RDB,
Quoted 1 line
and introduce CONFIG_P1020RDB-PC for PC-specific things.
Could you reply to this one?

Quoted 7 lines

Quoted 1 line
...and of course I meant CONFIG_P1020RDB_PC rather than
CONFIG_P1020RDB-
Quoted 1 line
PC. :-)
[Haijun Wrote:] Oh, yes I agree. It a little strange to have "-PD", but this patch was aim at add new board p1020rdb-pd board. If need i'll send another patch to change the config name for PC,RDB and PD. I had send another patch(Mean v2 of this patch), pls give some advice.

Respin that patch so that CONFIG_P1020RDB is set for all revisions of p1020rdb, and either CONFIG_P1020RDB_PC or CONFIG_P1020RDB_PD is specified to indicated the revision.

-SCott

Zhang Haijun-B42677

2013-06-28 02:07 UTC #6 lore raw

PATCH 1/1 p1020rdb-pd: platform support

In reply to Scott Wood

Regards
Haijun.

Quoted 11 lines

-----Original Message-----
From: Zhang Haijun-B42677
Sent: Friday, June 28, 2013 9:55 AM
To: Wood Scott-B07421
Cc: Fleming Andy-AFLEMING; u-boot at lists.denx.de; Huang Changming-R66093; sun york-R58495
Subject: RE: [U-Boot] [PATCH] p1020rdb-pd: platform support

Quoted 48 lines

Regards
Haijun.
Quoted 44 lines
-----Original Message-----
From: Wood Scott-B07421
Sent: Friday, June 28, 2013 4:10 AM
To: Zhang Haijun-B42677
Cc: Wood Scott-B07421; Fleming Andy-AFLEMING; u-boot at lists.denx.de; Huang Changming-R66093; sun york-R58495
Subject: Re: [U-Boot] [PATCH] p1020rdb-pd: platform support
Quoted 25 lines · On 06/27/2013 03:58:57 AM, Zhang Haijun-B42677 wrote:
Hi, Scott
Sorry to reply to so late.
Pls see my reply below.
Regards & Thanks
Haijun.
Quoted 5 lines
-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, May 22, 2013 6:24 AM
To: Zhang Haijun-B42677
Cc: Fleming Andy-AFLEMING; u-boot at lists.denx.de; Huang
Changming-R66093;
Quoted 9 lines
Zhang Haijun-B42677; Zhang Haijun-B42677; sun york-R58495
Subject: Re: [U-Boot] [PATCH] p1020rdb-pd: platform support
Quoted 3 lines · Haijun.Zhang
From: "Haijun.Zhang" <[email protected]>
Add platform support for p1020rdb-pd
Explain what is different about "-pd" and why this new revision
requires
Quoted 8 lines
Quoted 2 lines
a separate compile-time target.
[Haijun Wrote:] We use P1020RDB-PD to instead of P1020RDB-PC board later on.
They are all supported. Nand, DDR, Nor and Spi Flash are different between them.
So I thinks they should be two separate board as P1020UTM and P1020MBG do.
Put this information in the changelog.

[Haijun Wrote:] change log you mean?

Quoted 9 lines

Quoted 9 lines
Quoted 7 lines
Quoted 2 lines
If it's due to raw DDR config, say so in the changelog. Is there
any way
Quoted 2 lines
we could read a revision register to select the proper DDR config at runtime?
[Haijun Wrote:] Now we read DDR config from SPD fist, if not found read from config file.
Is there any reason why SPD would not be found?

[Haijun Wrote:] If someone erase the I2C area(SPD EEPROM) by mistake or change by other possible reason.
They will need to read from local config file to make sure uboot can working.

Quoted 10 lines

Quoted 10 lines
Quoted 10 lines
Quoted 9 lines
include/configs/p1_p2_rdb_pc.h line 58
Quoted 7 lines
include/configs/p1_p2_rdb_pc.h +4 -0
+#if (defined(CONFIG_P1020RDB) || defined(CONFIG_P1020RDB_PD))
 #if defined(CONFIG_P1020RDB)
 #define CONFIG_BOARDNAME "P1020RDB-PC"
+#elif defined(CONFIG_P1020RDB_PD) #define CONFIG_BOARDNAME
+"P1020RDB-PD"
+#endif
CONFIG_P1020RDB is not a good name to mean specifically the -PC
revision.

Quoted 8 lines

Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Change it so that CONFIG_P1020RDB is set for all revisions of
P1020RDB,
Quoted 1 line
and introduce CONFIG_P1020RDB-PC for PC-specific things.
Could you reply to this one?
...and of course I meant CONFIG_P1020RDB_PC rather than CONFIG_P1020RDB- PC. :-)

Quoted 2 lines

Quoted 2 lines
-Scott