Disable qt and related packages on mips64 with 64 bits userspace

PATCH In review Kai Kang 3 participants 7 messages Jun 28, 2013

lore

Share & tools

lore

Kai Kang

author

2013-06-28 07:49 UTC #0 lore raw

cover Disable qt and related packages on mips64 with 64 bits userspace

The following changes since commit 8e9501ffa8726d69412d669580d787ffedb88d34:

populate_sdk_base, adt_installer: abort install if path contains spaces (2013-06-25 17:59:17 +0100)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib kangkai/qt4-mips64
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=kangkai/qt4-mips64

Kai Kang (2):
qt4*.bbclass: disable build qt on mips64 with 64 bits userspace Disable build qt related packagegroups on mips64 with 64 bits
userspace

 meta/classes/qt4e.bbclass                          |    3 +++
 meta/classes/qt4x11.bbclass                        |    3 +++
 .../packagegroups/packagegroup-core-qt.bb          |    3 +++
 .../packagegroups/packagegroup-core-qt4e.bb        |    3 +++
 .../packagegroup-qt-toolchain-target.inc           |    3 +++
 5 files changed, 15 insertions(+), 0 deletions(-)

Signature · 1 line

1.7.5.4

Kai Kang

author

2013-06-28 07:49 UTC #1 lore raw

PATCH 1/2 qt4*.bbclass: disable build qt on mips64 with 64 bits userspace

Qt/qt-embedded build fails on mips64 with 64 bits userspace. Set COMPATIBLE_HOST in qt4e.bbclass and qt4x11.bbclass to disable build qt/qt-embedded and packages which inherit these two classes on mips64 with 64 bits userspace.

Signed-off-by Kai Kang <[email protected]>

---
 meta/classes/qt4e.bbclass   |    3 +++
 meta/classes/qt4x11.bbclass |    3 +++
 2 files changed, 6 insertions(+), 0 deletions(-)

meta/classes/qt4e.bbclass +3 -0

index de2a68d..d7f5df8 100644
@@ -18,3 +18,6 @@ EXTRA_QMAKEVARS_PRE += " QT_LIBINFIX=${QT_LIBINFIX} "
 
 # Qt4 uses atomic instructions not supported in thumb mode
 ARM_INSTRUCTION_SET = "arm"
+
+# Qt4 could NOT be built on MIPS64 with 64 bits userspace
+COMPATIBLE_HOST_mips64 = "mips64.*-linux-gnun32"

meta/classes/qt4x11.bbclass +3 -0

index b06e15d..65d196a 100644
@@ -9,3 +9,6 @@ QT_LIBINFIX = ""
 
 # Qt4 uses atomic instructions not supported in thumb mode
 ARM_INSTRUCTION_SET = "arm"
+
+# Qt4 could NOT be built on MIPS64 with 64 bits userspace
+COMPATIBLE_HOST_mips64 = "mips64.*-linux-gnun32"

Signature · 1 line

1.7.5.4

Kai Kang

author

2013-06-28 07:49 UTC #2 lore raw

PATCH 2/2 Disable build qt related packagegroups on mips64 with 64 bits userspace

In reply to Kai Kang

Because qt could not be built on mips64 with 64 bits userspace, set COMPATIBLE_HOST for qt related packagegroups to disable them on mips64 with 64 bit userspace too.

Signed-off-by Kai Kang <[email protected]>

---
 .../packagegroups/packagegroup-core-qt.bb          |    3 +++
 .../packagegroups/packagegroup-core-qt4e.bb        |    3 +++
 .../packagegroup-qt-toolchain-target.inc           |    3 +++
 3 files changed, 9 insertions(+), 0 deletions(-)

meta/recipes-qt/packagegroups/packagegroup-core-qt.bb +3 -0

index 315df33..c993242 100644
@@ -6,6 +6,9 @@ DESCRIPTION = "Qt package groups"
 LICENSE = "MIT"
 PR = "r4"
 
+# Qt4 could NOT be built on MIPS64 with 64 bits userspace
+COMPATIBLE_HOST_mips64 = "mips64.*-linux-gnun32"
+
 inherit packagegroup
 
 PACKAGES = "${PN}-demoapps"

meta/recipes-qt/packagegroups/packagegroup-core-qt4e.bb +3 -0

index 9263828..6ef844f 100644
@@ -2,6 +2,9 @@ SUMMARY = "Qt for Embedded Linux (Qt without X11)"
 PR = "r2"
 LICENSE = "MIT"
 
+# Qt4 could NOT be built on MIPS64 with 64 bits userspace
+COMPATIBLE_HOST_mips64 = "mips64.*-linux-gnun32"
+
 inherit packagegroup
 
 # For backwards compatibility after rename

meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc +3 -0

index 8413eec..fc1ccba 100644
@@ -1,5 +1,8 @@
 LICENSE = "MIT"
 
+# Qt4 could NOT be built on MIPS64 with 64 bits userspace
+COMPATIBLE_HOST_mips64 = "mips64.*-linux-gnun32"
+
 inherit packagegroup
 
 PACKAGEGROUP_DISABLE_COMPLEMENTARY = "1"

Signature · 1 line

1.7.5.4

Paul Eggleton

2013-06-28 09:00 UTC #3 lore raw

Re: [PATCH 2/2] Disable build qt related packagegroups on mips64 with 64 bits userspace

Hi Kai,

Quoted 48 lines · On Friday 28 June 2013 15:48:47 Kai Kang wrote:

Because qt could not be built on mips64 with 64 bits userspace, set COMPATIBLE_HOST for qt related packagegroups to disable them on mips64 with 64 bit userspace too.
Signed-off-by Kai Kang <[email protected]>
---
 .../packagegroups/packagegroup-core-qt.bb          |    3 +++
 .../packagegroups/packagegroup-core-qt4e.bb        |    3 +++
 .../packagegroup-qt-toolchain-target.inc           |    3 +++
 3 files changed, 9 insertions(+), 0 deletions(-)
(quoted diff) +0 -0
b/meta/recipes-qt/packagegroups/packagegroup-core-qt.bb index 315df33..c993242 100644
meta/recipes-qt/packagegroups/packagegroup-core-qt.bb +3 -0
@@ -6,6 +6,9 @@ DESCRIPTION = "Qt package groups"
 LICENSE = "MIT"
 PR = "r4"
 
+# Qt4 could NOT be built on MIPS64 with 64 bits userspace
+COMPATIBLE_HOST_mips64 = "mips64.*-linux-gnun32"
+
 inherit packagegroup
 
 PACKAGES = "${PN}-demoapps"
(quoted diff) +0 -0
b/meta/recipes-qt/packagegroups/packagegroup-core-qt4e.bb index 9263828..6ef844f 100644
meta/recipes-qt/packagegroups/packagegroup-core-qt4e.bb +3 -0
@@ -2,6 +2,9 @@ SUMMARY = "Qt for Embedded Linux (Qt without X11)"
 PR = "r2"
 LICENSE = "MIT"
 
+# Qt4 could NOT be built on MIPS64 with 64 bits userspace
+COMPATIBLE_HOST_mips64 = "mips64.*-linux-gnun32"
+
 inherit packagegroup
 
 # For backwards compatibility after rename
diff --git a/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc b/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc index 8413eec..fc1ccba 100644

meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc line 8

Quoted 8 lines

meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc +3 -0

@@ -1,5 +1,8 @@
 LICENSE = "MIT"
 
+# Qt4 could NOT be built on MIPS64 with 64 bits userspace
+COMPATIBLE_HOST_mips64 = "mips64.*-linux-gnun32"
+
 inherit packagegroup
 
 PACKAGEGROUP_DISABLE_COMPLEMENTARY = "1"

I'm fine with the other change; the question is is this one needed in addition? Since the packagegroup-*qt* recipes reference packages from Qt which itself inherits qt4x11/qt4e bbclasses, surely trying to build these will immediately fail for mips64 anyway?

Cheers,
Paul

Signature · 2 lines

Paul Eggleton
Intel Open Source Technology Centre

Kang Kai

author

2013-06-28 09:34 UTC #4 lore raw

Re: [PATCH 2/2] Disable build qt related packagegroups on mips64 with 64 bits userspace

Quoted 58 lines · Paul Eggleton

Hi Kai,
Quoted 55 lines · On Friday 28 June 2013 15:48:47 Kai Kang wrote:
Because qt could not be built on mips64 with 64 bits userspace, set COMPATIBLE_HOST for qt related packagegroups to disable them on mips64 with 64 bit userspace too.
Signed-off-by Kai Kang <[email protected]>
---
  .../packagegroups/packagegroup-core-qt.bb          |    3 +++
  .../packagegroups/packagegroup-core-qt4e.bb        |    3 +++
  .../packagegroup-qt-toolchain-target.inc           |    3 +++
  3 files changed, 9 insertions(+), 0 deletions(-)
(quoted diff) +0 -0
b/meta/recipes-qt/packagegroups/packagegroup-core-qt.bb index 315df33..c993242 100644
meta/recipes-qt/packagegroups/packagegroup-core-qt.bb +3 -0
@@ -6,6 +6,9 @@ DESCRIPTION = "Qt package groups"
  LICENSE = "MIT"
  PR = "r4"
 
+# Qt4 could NOT be built on MIPS64 with 64 bits userspace
+COMPATIBLE_HOST_mips64 = "mips64.*-linux-gnun32"
+
  inherit packagegroup
 
  PACKAGES = "${PN}-demoapps"
(quoted diff) +0 -0
b/meta/recipes-qt/packagegroups/packagegroup-core-qt4e.bb index 9263828..6ef844f 100644
meta/recipes-qt/packagegroups/packagegroup-core-qt4e.bb +3 -0
@@ -2,6 +2,9 @@ SUMMARY = "Qt for Embedded Linux (Qt without X11)"
  PR = "r2"
  LICENSE = "MIT"
 
+# Qt4 could NOT be built on MIPS64 with 64 bits userspace
+COMPATIBLE_HOST_mips64 = "mips64.*-linux-gnun32"
+
  inherit packagegroup
 
  # For backwards compatibility after rename
diff --git a/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc b/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc index 8413eec..fc1ccba 100644
meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc +3 -0
@@ -1,5 +1,8 @@
  LICENSE = "MIT"
 
+# Qt4 could NOT be built on MIPS64 with 64 bits userspace
+COMPATIBLE_HOST_mips64 = "mips64.*-linux-gnun32"
+
  inherit packagegroup
 

Quoted 5 lines

meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc line 8
Quoted 1 line
meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc +0 -0
  PACKAGEGROUP_DISABLE_COMPLEMENTARY = "1"
I'm fine with the other change; the question is is this one needed in addition? Since the packagegroup-*qt* recipes reference packages from Qt which itself inherits qt4x11/qt4e bbclasses, surely trying to build these will immediately fail for mips64 anyway?

Yes, it will fail immediately. What I want to do is to underline these packagegroups' build platform. If you believe that they are redundant, I retrieve the patch 2/2.

Thanks,
Kai

Quoted 4 lines

Cheers,
Paul

Signature · 2 lines

Regards,
Neil | Kai Kang

Richard Purdie

2013-06-28 09:42 UTC #5 lore raw

Re: [PATCH 2/2] Disable build qt related packagegroups on mips64 with 64 bits userspace

Quoted 65 lines · Kang Kai

Quoted 58 lines · Paul Eggleton
Hi Kai,
Quoted 55 lines · On Friday 28 June 2013 15:48:47 Kai Kang wrote:
Because qt could not be built on mips64 with 64 bits userspace, set COMPATIBLE_HOST for qt related packagegroups to disable them on mips64 with 64 bit userspace too.
Signed-off-by Kai Kang <[email protected]>
---
  .../packagegroups/packagegroup-core-qt.bb          |    3 +++
  .../packagegroups/packagegroup-core-qt4e.bb        |    3 +++
  .../packagegroup-qt-toolchain-target.inc           |    3 +++
  3 files changed, 9 insertions(+), 0 deletions(-)
(quoted diff) +0 -0
b/meta/recipes-qt/packagegroups/packagegroup-core-qt.bb index 315df33..c993242 100644
meta/recipes-qt/packagegroups/packagegroup-core-qt.bb +3 -0
@@ -6,6 +6,9 @@ DESCRIPTION = "Qt package groups"
  LICENSE = "MIT"
  PR = "r4"
 
+# Qt4 could NOT be built on MIPS64 with 64 bits userspace
+COMPATIBLE_HOST_mips64 = "mips64.*-linux-gnun32"
+
  inherit packagegroup
 
  PACKAGES = "${PN}-demoapps"
(quoted diff) +0 -0
b/meta/recipes-qt/packagegroups/packagegroup-core-qt4e.bb index 9263828..6ef844f 100644
meta/recipes-qt/packagegroups/packagegroup-core-qt4e.bb +3 -0
@@ -2,6 +2,9 @@ SUMMARY = "Qt for Embedded Linux (Qt without X11)"
  PR = "r2"
  LICENSE = "MIT"
 
+# Qt4 could NOT be built on MIPS64 with 64 bits userspace
+COMPATIBLE_HOST_mips64 = "mips64.*-linux-gnun32"
+
  inherit packagegroup
 
  # For backwards compatibility after rename
diff --git a/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc b/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc index 8413eec..fc1ccba 100644
meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc +3 -0
@@ -1,5 +1,8 @@
  LICENSE = "MIT"
 
+# Qt4 could NOT be built on MIPS64 with 64 bits userspace
+COMPATIBLE_HOST_mips64 = "mips64.*-linux-gnun32"
+
  inherit packagegroup
 
Quoted 5 lines
meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc line 8
Quoted 1 line
meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc +0 -0
  PACKAGEGROUP_DISABLE_COMPLEMENTARY = "1"
I'm fine with the other change; the question is is this one needed in addition? Since the packagegroup-*qt* recipes reference packages from Qt which itself inherits qt4x11/qt4e bbclasses, surely trying to build these will immediately fail for mips64 anyway?

Quoted 3 lines

Yes, it will fail immediately. What I want to do is to underline these packagegroups' build platform.
If you believe that they are redundant, I retrieve the patch 2/2.

At a guess the one advantage of this is to clean up what "bitbake world" would show?

Cheers,

Richard

Paul Eggleton

2013-06-28 09:58 UTC #6 lore raw

Re: [PATCH 2/2] Disable build qt related packagegroups on mips64 with 64 bits userspace

Quoted 79 lines · On Friday 28 June 2013 10:42:29 Richard Purdie wrote:

Quoted 78 lines · Kang Kai
Quoted 76 lines · Paul Eggleton
Hi Kai,
Quoted 67 lines · On Friday 28 June 2013 15:48:47 Kai Kang wrote:
Because qt could not be built on mips64 with 64 bits userspace, set COMPATIBLE_HOST for qt related packagegroups to disable them on mips64 with 64 bit userspace too.
Signed-off-by Kai Kang <[email protected]>
---
  .../packagegroups/packagegroup-core-qt.bb          |    3 +++
  .../packagegroups/packagegroup-core-qt4e.bb        |    3 +++
  .../packagegroup-qt-toolchain-target.inc           |    3 +++
  3 files changed, 9 insertions(+), 0 deletions(-)
(quoted diff) +0 -0
b/meta/recipes-qt/packagegroups/packagegroup-core-qt.bb index 315df33..c993242 100644
meta/recipes-qt/packagegroups/packagegroup-core-qt.bb +3 -0
@@ -6,6 +6,9 @@ DESCRIPTION = "Qt package groups"
 
  LICENSE = "MIT"
  PR = "r4"
 
+# Qt4 could NOT be built on MIPS64 with 64 bits userspace
+COMPATIBLE_HOST_mips64 = "mips64.*-linux-gnun32"
+
 
  inherit packagegroup
  
  PACKAGES = "${PN}-demoapps"
(quoted diff) +0 -0
b/meta/recipes-qt/packagegroups/packagegroup-core-qt4e.bb index 9263828..6ef844f 100644
meta/recipes-qt/packagegroups/packagegroup-core-qt4e.bb +3 -0
@@ -2,6 +2,9 @@ SUMMARY = "Qt for Embedded Linux (Qt without X11)"
 
  PR = "r2"
  LICENSE = "MIT"
 
+# Qt4 could NOT be built on MIPS64 with 64 bits userspace
+COMPATIBLE_HOST_mips64 = "mips64.*-linux-gnun32"
+
 
  inherit packagegroup
# For backwards compatibility after rename
diff --git a/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc b/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc index
8413eec..fc1ccba 100644
---
a/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc
+++
b/meta/recipes-qt/packagegroups/packagegroup-qt-toolchain-target.inc
meta/recipes-qt/packagegroups/packagegroup-core-qt4e.bb +3 -0
@@ -1,5 +1,8 @@
 
  LICENSE = "MIT"
 
+# Qt4 could NOT be built on MIPS64 with 64 bits userspace
+COMPATIBLE_HOST_mips64 = "mips64.*-linux-gnun32"
+
 
  inherit packagegroup
Quoted 1 line
PACKAGEGROUP_DISABLE_COMPLEMENTARY = "1"
I'm fine with the other change; the question is is this one needed in addition? Since the packagegroup-*qt* recipes reference packages from Qt which itself inherits qt4x11/qt4e bbclasses, surely trying to build these will immediately fail for mips64 anyway?

Quoted 6 lines

Quoted 3 lines
Yes, it will fail immediately. What I want to do is to underline these packagegroups' build platform.
If you believe that they are redundant, I retrieve the patch 2/2.
At a guess the one advantage of this is to clean up what "bitbake world" would show?

OK, I don't have any strong objections if it does help in some way.

Cheers,
Paul

Signature · 2 lines

Paul Eggleton
Intel Open Source Technology Centre