Skip to contentSkip to conversation

socfpga: Move board/socfpga_cyclone5 to board/socfpga

PATCH Superseded dinguyen at altera.com 3 participants 7 messages Jul 2, 2013 – Jul 25, 2013

lore
Share & tools
lore

dinguyen at altera.com

author
#0 lore raw

PATCH v2 1/1 socfpga: Move board/socfpga_cyclone5 to board/socfpga

From: Dinh Nguyen <[email protected]>

Because the SOCFPGA platform will include support for Cyclone V and Arria V FPGA parts, renaming socfpga_cyclone5 folder to socfpga to be more generic.

Signed-off-by Dinh Nguyen <[email protected]>
Reviewed-by Pavel Machek <[email protected]>
Cc Chin Liang See <[email protected]>
Cc Wolfgang Denk <[email protected]>
CC Pavel Machek <[email protected]>
Cc Tom Rini <[email protected]>

v2:
- Add Reviewed-by: Pavel Machek
- Cc: Tom Rini

---
 .../altera/{socfpga_cyclone5 => socfpga}/Makefile  |    0
 .../socfpga_cyclone5.c                             |    0
 boards.cfg                                         |    2 +-
 3 files changed, 1 insertion(+), 1 deletion(-)
 rename board/altera/{socfpga_cyclone5 => socfpga}/Makefile (100%)
 rename board/altera/{socfpga_cyclone5 => socfpga}/socfpga_cyclone5.c (100%)
board/altera/socfpga/Makefile renamed from board/altera/socfpga_cyclone5/Makefile +0 -0
similarity index 100%
rename from board/altera/socfpga_cyclone5/Makefile
rename to board/altera/socfpga/Makefile
board/altera/socfpga/socfpga_cyclone5.c renamed from board/altera/socfpga_cyclone5/socfpga_cyclone5.c +0 -0
similarity index 100%
rename from board/altera/socfpga_cyclone5/socfpga_cyclone5.c
rename to board/altera/socfpga/socfpga_cyclone5.c
boards.cfg +1 -1
index c0c4282..eea92d5 100644
@@ -335,7 +335,7 @@ kzm9g                        arm         armv7       kzm9g               kmc
 armadillo-800eva             arm         armv7       armadillo-800eva    atmark-techno  rmobile
 zynq                         arm         armv7       zynq                xilinx         zynq
 zynq_dcc                     arm         armv7       zynq                xilinx         zynq        zynq:ZYNQ_DCC
-socfpga_cyclone5                arm         armv7          socfpga_cyclone5    altera		    socfpga
+socfpga_cyclone5                arm         armv7          socfpga    altera		    socfpga
 actux1_4_16                  arm         ixp         actux1              -              -           actux1:FLASH2X2
 actux1_4_32                  arm         ixp         actux1              -              -           actux1:FLASH2X2,RAM_32MB
 actux1_8_16                  arm         ixp         actux1              -              -           actux1:FLASH1X8
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v2 1/1 socfpga: Move board/socfpga_cyclone5 to board/socfpga

Hi dinguyen at altera.com,

Quoted 13 lines · On Tue, 2 Jul 2013 17:00:18 -0500, <[email protected]> wrote:

From: Dinh Nguyen <[email protected]>

Because the SOCFPGA platform will include support for Cyclone V and Arria V FPGA parts, renaming socfpga_cyclone5 folder to socfpga to be more generic.

Signed-off-by Dinh Nguyen <[email protected]>
Reviewed-by Pavel Machek <[email protected]>
Cc Chin Liang See <[email protected]>
Cc Wolfgang Denk <[email protected]>
CC Pavel Machek <[email protected]>
Cc Tom Rini <[email protected]>
Quoted 4 lines

v2:
- Add Reviewed-by: Pavel Machek
- Cc: Tom Rini
---

Do you really mean that V2 is the exact same code as V1? If it is, then V2 is unneeded. And if V2 is different from V1, then history should tells us the difference(s).

Amicalement,

Signature · 1 line
Albert.
author
#2 lore raw

PATCH v2 1/1 socfpga: Move board/socfpga_cyclone5 to board/socfpga

Hi Albert,

Quoted 17 lines · ZY - albert.u.boot

Hi dinguyen at altera.com,

Quoted 13 lines · On Tue, 2 Jul 2013 17:00:18 -0500, <[email protected]> wrote:

From: Dinh Nguyen <[email protected]>

Because the SOCFPGA platform will include support for Cyclone V and Arria V FPGA parts, renaming socfpga_cyclone5 folder to socfpga to be more generic.

Signed-off-by Dinh Nguyen <[email protected]>
Reviewed-by Pavel Machek <[email protected]>
Cc Chin Liang See <[email protected]>
Cc Wolfgang Denk <[email protected]>
CC Pavel Machek <[email protected]>
Cc Tom Rini <[email protected]>
Quoted 8 lines
Quoted 4 lines

v2:
- Add Reviewed-by: Pavel Machek
- Cc: Tom Rini
---

Do you really mean that V2 is the exact same code as V1? If it is, then V2 is unneeded. And if V2 is different from V1, then history should tells us the difference(s).

V2 is the same as v1 codewise. So should I resend this a V1 to be applied?

Dinh

Quoted 2 lines

Amicalement,

#3 lore raw

PATCH v2 1/1 socfpga: Move board/socfpga_cyclone5 to board/socfpga

Hi Dinh,

Quoted 25 lines · Dinh Nguyen

Hi Albert,

Quoted 22 lines · ZY - albert.u.boot

Hi dinguyen at altera.com,

Quoted 17 lines · On Tue, 2 Jul 2013 17:00:18 -0500, <[email protected]> wrote:

From: Dinh Nguyen <[email protected]>

Because the SOCFPGA platform will include support for Cyclone V and Arria V FPGA parts, renaming socfpga_cyclone5 folder to socfpga to be more generic.

Signed-off-by Dinh Nguyen <[email protected]>
Reviewed-by Pavel Machek <[email protected]>
Cc Chin Liang See <[email protected]>
Cc Wolfgang Denk <[email protected]>
CC Pavel Machek <[email protected]>
Cc Tom Rini <[email protected]>

v2:
- Add Reviewed-by: Pavel Machek
- Cc: Tom Rini
---

Quoted 6 lines
Quoted 3 lines

Do you really mean that V2 is the exact same code as V1? If it is, then V2 is unneeded. And if V2 is different from V1, then history should tells us the difference(s).

V2 is the same as v1 codewise. So should I resend this a V1 to be applied?

If V1 is the same as V2 as far as the code is concerned, then there is simply no point in sending V2 or resending V1 again.

The V2 history makes me guess you thought it necessary to officialize Pavel's Reviewed-By somehow, but that's unneeded; patchworks takes care of collecting all the {Reviewed,Acked,Tested,...}-by's and providing them when applying the patch through pwclient.

Quoted 1 line

Dinh

Amicalement,

Signature · 1 line
Albert.
#4 lore raw

PATCH v2 1/1 socfpga: Move board/socfpga_cyclone5 to board/socfpga

Hi!

Quoted 25 lines
Quoted 18 lines
Quoted 18 lines
Quoted 17 lines

From: Dinh Nguyen <[email protected]>

Because the SOCFPGA platform will include support for Cyclone V and Arria V FPGA parts, renaming socfpga_cyclone5 folder to socfpga to be more generic.

Signed-off-by Dinh Nguyen <[email protected]>
Reviewed-by Pavel Machek <[email protected]>
Cc Chin Liang See <[email protected]>
Cc Wolfgang Denk <[email protected]>
CC Pavel Machek <[email protected]>
Cc Tom Rini <[email protected]>

v2:
- Add Reviewed-by: Pavel Machek
- Cc: Tom Rini
---

Quoted 6 lines
Quoted 3 lines

Do you really mean that V2 is the exact same code as V1? If it is, then V2 is unneeded. And if V2 is different from V1, then history should tells us the difference(s).

V2 is the same as v1 codewise. So should I resend this a V1 to be applied?

Quoted 7 lines

If V1 is the same as V2 as far as the code is concerned, then there is simply no point in sending V2 or resending V1 again.

The V2 history makes me guess you thought it necessary to officialize Pavel's Reviewed-By somehow, but that's unneeded; patchworks takes care of collecting all the {Reviewed,Acked,Tested,...}-by's and providing them when applying the patch through pwclient.

This got pretty confusing lately. Can we just wait for the patches to be applied, or do we need to take some action?

Thanks,
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#5 lore raw

PATCH v2 1/1 socfpga: Move board/socfpga_cyclone5 to board/socfpga

Hi Pavel,

Quoted 30 lines · Pavel Machek

Hi!

Quoted 28 lines
Quoted 18 lines
Quoted 18 lines
Quoted 17 lines

From: Dinh Nguyen <[email protected]>

Because the SOCFPGA platform will include support for Cyclone V and Arria V FPGA parts, renaming socfpga_cyclone5 folder to socfpga to be more generic.

Signed-off-by Dinh Nguyen <[email protected]>
Reviewed-by Pavel Machek <[email protected]>
Cc Chin Liang See <[email protected]>
Cc Wolfgang Denk <[email protected]>
CC Pavel Machek <[email protected]>
Cc Tom Rini <[email protected]>

v2:
- Add Reviewed-by: Pavel Machek
- Cc: Tom Rini
---

Quoted 6 lines
Quoted 3 lines

Do you really mean that V2 is the exact same code as V1? If it is, then V2 is unneeded. And if V2 is different from V1, then history should tells us the difference(s).

V2 is the same as v1 codewise. So should I resend this a V1 to be applied?

If V1 is the same as V2 as far as the code is concerned, then there is simply no point in sending V2 or resending V1 again.

Quoted 7 lines
Quoted 4 lines

The V2 history makes me guess you thought it necessary to officialize Pavel's Reviewed-By somehow, but that's unneeded; patchworks takes care of collecting all the {Reviewed,Acked,Tested,...}-by's and providing them when applying the patch through pwclient.

This got pretty confusing lately. Can we just wait for the patches to be applied, or do we need to take some action?

No, no need to take action; I was just clarifying why V2 was unneeded here, so that similar uneeded new versions are avoided in the future.

Since V1 has already been marked as superseded, I'll apply V2 -- after 2013.07 is out.

Quoted 2 lines

Thanks,
Pavel

Amicalement,

Signature · 1 line
Albert.
#6 lore raw

PATCH v2 1/1 socfpga: Move board/socfpga_cyclone5 to board/socfpga

In reply to dinguyen at altera.com

Hi dinguyen at altera.com,

Quoted 37 lines · On Tue, 2 Jul 2013 17:00:18 -0500, <[email protected]> wrote:

From: Dinh Nguyen <[email protected]>

Because the SOCFPGA platform will include support for Cyclone V and Arria V FPGA parts, renaming socfpga_cyclone5 folder to socfpga to be more generic.

Signed-off-by Dinh Nguyen <[email protected]>
Reviewed-by Pavel Machek <[email protected]>
Cc Chin Liang See <[email protected]>
Cc Wolfgang Denk <[email protected]>
CC Pavel Machek <[email protected]>
Cc Tom Rini <[email protected]>

v2:
- Add Reviewed-by: Pavel Machek
- Cc: Tom Rini

---
 .../altera/{socfpga_cyclone5 => socfpga}/Makefile  |    0
 .../socfpga_cyclone5.c                             |    0
 boards.cfg                                         |    2 +-
 3 files changed, 1 insertion(+), 1 deletion(-)
 rename board/altera/{socfpga_cyclone5 => socfpga}/Makefile (100%)
 rename board/altera/{socfpga_cyclone5 => socfpga}/socfpga_cyclone5.c (100%)
board/altera/socfpga/Makefile renamed from board/altera/socfpga_cyclone5/Makefile +0 -0
similarity index 100%
rename from board/altera/socfpga_cyclone5/Makefile
rename to board/altera/socfpga/Makefile
board/altera/socfpga/socfpga_cyclone5.c renamed from board/altera/socfpga_cyclone5/socfpga_cyclone5.c +0 -0
similarity index 100%
rename from board/altera/socfpga_cyclone5/socfpga_cyclone5.c
rename to board/altera/socfpga/socfpga_cyclone5.c
boards.cfg +0 -0
index c0c4282..eea92d5 100644

boards.cfg kzm9g arm armv7 kzm9g kmc · line 341

Quoted 8 lines
boards.cfg +1 -1
@@ -335,7 +335,7 @@ kzm9g                        arm         armv7       kzm9g               kmc
 armadillo-800eva             arm         armv7       armadillo-800eva    atmark-techno  rmobile
 zynq                         arm         armv7       zynq                xilinx         zynq
 zynq_dcc                     arm         armv7       zynq                xilinx         zynq        zynq:ZYNQ_DCC
-socfpga_cyclone5                arm         armv7          socfpga_cyclone5    altera		    socfpga
+socfpga_cyclone5                arm         armv7          socfpga    altera		    socfpga
 actux1_4_16                  arm         ixp         actux1              -              -           actux1:FLASH2X2
 actux1_4_32                  arm         ixp         actux1              -              -           actux1:FLASH2X2,RAM_32MB
 actux1_8_16                  arm         ixp         actux1              -              -           actux1:FLASH1X8

Applied to u-boot-arm/master, thanks!

Amicalement,

Signature · 1 line
Albert.