irqchip: vt8500: Staticize local symbols

PATCH Superseded Axel Lin 2 participants 2 messages Jul 4, 2013 irqchip drivers

Share & tools

Axel Lin

author

2013-07-04 06:11 UTC #0 lore raw

PATCH 1/1 irqchip: vt8500: Staticize local symbols

This driver is converted to use IRQCHIP_DECLARE and irqchip_init. vt8500_handle_irq() and vt8500_irq_init() are only referenced in this file now, make them static.

Signed-off-by Axel Lin <[email protected]>

---
 drivers/irqchip/irq-vt8500.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

drivers/irqchip/irq-vt8500.c +4 -2

index d970595..1846e7d 100644
@@ -178,7 +178,8 @@ static struct irq_domain_ops vt8500_irq_domain_ops = {
 	.xlate = irq_domain_xlate_onecell,
 };
 
-asmlinkage void __exception_irq_entry vt8500_handle_irq(struct pt_regs *regs)
+static asmlinkage
+void __exception_irq_entry vt8500_handle_irq(struct pt_regs *regs)
 {
 	u32 stat, i;
 	int irqnr, virq;

@@ -203,7 +204,8 @@ asmlinkage void __exception_irq_entry vt8500_handle_irq(struct pt_regs *regs)
 	}
 }
 
-int __init vt8500_irq_init(struct device_node *node, struct device_node *parent)
+static int __init vt8500_irq_init(struct device_node *node,
+				  struct device_node *parent)
 {
 	int irq, i;
 	struct device_node *np = node;

Signature · 1 line

1.8.1.2

Tony Prisk

Acked-by on v1 1/1

2013-07-04 18:32 UTC #1 lore raw

Quoted 24 lines · Axel Lin

This driver is converted to use IRQCHIP_DECLARE and irqchip_init. vt8500_handle_irq() and vt8500_irq_init() are only referenced in this file now, make them static.
Signed-off-by Axel Lin <[email protected]>
---
  drivers/irqchip/irq-vt8500.c | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)
drivers/irqchip/irq-vt8500.c +2 -1
index d970595..1846e7d 100644
@@ -178,7 +178,8 @@ static struct irq_domain_ops vt8500_irq_domain_ops = {
  	.xlate = irq_domain_xlate_onecell,
  };
 
-asmlinkage void __exception_irq_entry vt8500_handle_irq(struct pt_regs *regs)
+static asmlinkage
+void __exception_irq_entry vt8500_handle_irq(struct pt_regs *regs)
  {
  	u32 stat, i;
  	int irqnr, virq;

drivers/irqchip/irq-vt8500.c asmlinkage void __exception_irq_entry vt8500_handle_irq(struct pt_regs *regs) · line 208

Quoted 6 lines

drivers/irqchip/irq-vt8500.c +2 -1

@@ -203,7 +204,8 @@ asmlinkage void __exception_irq_entry vt8500_handle_irq(struct pt_regs *regs)
  	}
  }
 
-int __init vt8500_irq_init(struct device_node *node, struct device_node *parent)
+static int __init vt8500_irq_init(struct device_node *node,
+				  struct device_node *parent)

I prefer that the function variables are lined up, rather than aligning with the (. Can you move the 'struct device_node *parent' across one more space?

Otherwise:

Acked-by Tony Prisk <[email protected]>

drivers/irqchip/irq-vt8500.c asmlinkage void __exception_irq_entry vt8500_handle_irq(struct pt_regs *regs) · line 211

Quoted 3 lines

drivers/irqchip/irq-vt8500.c +0 -0

  {
  	int irq, i;
  	struct device_node *np = node;

Regards
Tony P