drm/i915: Fix VLV DP RBR/HDMI/DAC PLL LPF coefficients
Subsystems (2)
PATCH 1/1 drm/i915: Fix VLV DP RBR/HDMI/DAC PLL LPF coefficients
From: Ville Syrjälä <[email protected]>
I just got confirmation that we're using some old values for the PLL LPF coefficients for DP RBR/HDMI/DAC on VLV. The VLV2A0_DP_eDP_HDMI_DPIO_driver_vbios_notes_9 document lists both values by mistake, and apparently we had picked the wrong one. Change the coefficients to the recommended values.
Changing the value doesn't appear to destabilize the VGA output picture even with my sensitive HP ZR24w display. Also HDMI output to my TV still works fine.
--- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_display.c +1 -1
@@ -4448,7 +4448,7 @@ static void vlv_update_pll(struct intel_crtc *crtc) intel_pipe_has_type(&crtc->base, INTEL_OUTPUT_ANALOG) || intel_pipe_has_type(&crtc->base, INTEL_OUTPUT_HDMI))vlv_dpio_write (dev_priv,DPIO_LPF_COEFF (pipe), -0x005f0021 ); +0x009f0003 ); else vlv_dpio_write(dev_priv, DPIO_LPF_COEFF(pipe), 0x00d0000f);
Signature · 6 lines
1.8.1.5 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 22 lines · On Fri, 5 Jul 2013 19:21:38 +0300 [email protected] wrote:
From: Ville Syrjälä <[email protected]>
I just got confirmation that we're using some old values for the PLL LPF coefficients for DP RBR/HDMI/DAC on VLV. The
VLV2A0_DP_eDP_HDMI_DPIO_driver_vbios_notes_9document lists both values by mistake, and apparently we had picked the wrong one. Change the coefficients to the recommended values.Changing the value doesn't appear to destabilize the VGA output picture even with my sensitive HP ZR24w display. Also HDMI output to my TV still works fine.
Signed-off-by Ville Syrjälä <[email protected]>--- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_display.c +0
-0
drivers/gpu/drm/i915/intel_display.c static void vlv_update_pll(struct intel_crtc *crtc) · line 4454
Quoted 8 lines
drivers/gpu/drm/i915/intel_display.c +1
-1@@ -4448,7 +4448,7 @@ static void vlv_update_pll(struct intel_crtc *crtc) intel_pipe_has_type(&crtc->base, INTEL_OUTPUT_ANALOG) || intel_pipe_has_type(&crtc->base, INTEL_OUTPUT_HDMI))vlv_dpio_write (dev_priv,DPIO_LPF_COEFF (pipe), -0x005f0021 ); +0x009f0003 ); else vlv_dpio_write(dev_priv, DPIO_LPF_COEFF(pipe), 0x00d0000f);
Signature · 5 lines
Jesse Barnes, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Daniel Vetter
AppliedQuoted 20 lines · Jesse Barnes
Quoted 17 lines · On Fri, 5 Jul 2013 19:21:38 +0300 [email protected] wrote:
From: Ville Syrjälä <[email protected]>
I just got confirmation that we're using some old values for the PLL LPF coefficients for DP RBR/HDMI/DAC on VLV. The
VLV2A0_DP_eDP_HDMI_DPIO_driver_vbios_notes_9document lists both values by mistake, and apparently we had picked the wrong one. Change the coefficients to the recommended values.Changing the value doesn't appear to destabilize the VGA output picture even with my sensitive HP ZR24w display. Also HDMI output to my TV still works fine.
Signed-off-by Ville Syrjälä <[email protected]>--- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines
drivers/gpu/drm/i915/intel_display.c static void vlv_update_pll(struct intel_crtc *crtc) · line 4454
Quoted 13 lines
drivers/gpu/drm/i915/intel_display.c +1
-1@@ -4448,7 +4448,7 @@ static void vlv_update_pll(struct intel_crtc *crtc) intel_pipe_has_type(&crtc->base, INTEL_OUTPUT_ANALOG) || intel_pipe_has_type(&crtc->base, INTEL_OUTPUT_HDMI))vlv_dpio_write (dev_priv,DPIO_LPF_COEFF (pipe), -0x005f0021 ); +0x009f0003 ); else vlv_dpio_write(dev_priv, DPIO_LPF_COEFF(pipe), 0x00d0000f);Reviewed-by Jesse Barnes <[email protected]>
Queued for -next, thanks for the patch.
-Daniel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch