firmware/dmi_scan: Drop OOM messages
A message that is not in the archive (sent off-list or not yet received): [email protected]
even more trivial...
Review static const char * __init dmi_string(co · line 63
Quoted 4 lines · Jean Delvare
+++
linux-3.11-rc0/drivers/firmware/dmi_scan.c2013-07-10 14:11:56.544792703 +0200(quoted diff) +0
-0@@ -62,8 +62,6 @@ static const char * __init dmi_string(co str = dmi_alloc(len); if (str != NULL)
[]
Review static void __init dmi_save_one_device(i · line 219
Quoted 4 lines
(quoted diff) +1
-0@@ -219,10 +217,8 @@ static void __init dmi_save_one_device(i dev = dmi_alloc(sizeof(*dev) + strlen(name) + 1); + if (!dev) return;
[]
Review static void __init dmi_save_oem_strings_ · line 256
Quoted 4 lines
(quoted diff) +1
-0@@ -258,10 +254,8 @@ static void __init dmi_save_oem_strings_ dev = dmi_alloc(sizeof(*dev)); + if (!dev) break;
[]
Review static void __init dmi_save_ipmi_device( · line 273
Quoted 4 lines
(quoted diff) +1
-0@@ -277,18 +271,14 @@ static void __init dmi_save_ipmi_device( data = dmi_alloc(dm->length); + if (data == NULL) return;
[]
Review static void __init dmi_save_ipmi_device( · line 276
Quoted 3 lines
(quoted diff) +1
-0dev = dmi_alloc(sizeof(*dev)); + if (!dev) return;
[]
Review static void __init dmi_save_dev_onboard( · line 295
Quoted 4 lines
(quoted diff) +1
-0@@ -303,10 +293,9 @@ static void __init dmi_save_dev_onboard( onboard_dev = dmi_alloc(sizeof(*onboard_dev) + strlen(name) + 1); + if (!onboard_dev) return;
It'd also be nice to use the same test style
in all 6 uses.
if (!foo)
Hi Joe,
Quoted 35 lines · Joe Perches
even more trivial...
Review static const char * __init dmi_string(co · line 63
Quoted 4 lines · Jean Delvare
+++
linux-3.11-rc0/drivers/firmware/dmi_scan.c2013-07-10 14:11:56.544792703 +0200(quoted diff) +0
-0@@ -62,8 +62,6 @@ static const char * __init dmi_string(co str = dmi_alloc(len); if (str != NULL)[]
Review static void __init dmi_save_one_device(i · line 219
Quoted 4 lines
(quoted diff) +1
-0@@ -219,10 +217,8 @@ static void __init dmi_save_one_device(i dev = dmi_alloc(sizeof(*dev) + strlen(name) + 1); + if (!dev) return;[]
Review static void __init dmi_save_oem_strings_ · line 256
Quoted 4 lines
(quoted diff) +1
-0@@ -258,10 +254,8 @@ static void __init dmi_save_oem_strings_ dev = dmi_alloc(sizeof(*dev)); + if (!dev) break;[]
Review static void __init dmi_save_ipmi_device( · line 273
Quoted 4 lines
(quoted diff) +1
-0@@ -277,18 +271,14 @@ static void __init dmi_save_ipmi_device( data = dmi_alloc(dm->length); + if (data == NULL) return;[]
Review static void __init dmi_save_ipmi_device( · line 276
Quoted 3 lines
(quoted diff) +1
-0dev = dmi_alloc(sizeof(*dev)); + if (!dev) return;[]
Review static void __init dmi_save_dev_onboard( · line 295
Quoted 4 lines
(quoted diff) +1
-0@@ -303,10 +293,9 @@ static void __init dmi_save_dev_onboard( onboard_dev = dmi_alloc(sizeof(*onboard_dev) + strlen(name) + 1); + if (!onboard_dev) return;It'd also be nice to use the same test style
in all 6 uses.
Quoted 1 line
if (!foo)
Both styles are used throughout the file, and checkpatch doesn't complain. Unifying the coding style is beyond the scope of my patchset, sorry. Feel free to send a patch on top of mine if you really care.
Signature · 2 lines
Jean Delvare Suse L3
Quoted 2 lines · Jean Delvare
Quoted 1 line · Joe Perches
even more trivial...
[]
Quoted 7 lines
Quoted 4 lines
It'd also be nice to use the same test style
in all 6 uses.if (!foo)Both styles are used throughout the file, and checkpatch doesn't complain.
And it might be wrong for checkpatch to complain as there are tens of thousands of those in the kernel.
I think using both styles in the same file is poor form though.
Quoted 2 lines
Unifying the coding style is beyond the scope of my patchset, sorry. Feel free to send a patch on top of mine if you really care.
No worries. If I remember, I'll send a patch after yours hit -next.