usb: gadget: fotg210-udc: Remove bogus __init/__exit annotations
PATCH 1/1 usb: gadget: fotg210-udc: Remove bogus __init/__exit annotations
When builtin (CONFIG_USB_FOTG210_UDC=y):
LD drivers/usb/gadget/built-in.o
WARNING: drivers/usb/gadget/built-in.o(.data+0xbf8): Section mismatch in reference from the variable fotg210_driver to the function .init.text:fotg210_udc_probe() The variable fotg210_driver references
the function __init fotg210_udc_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
LD drivers/usb/built-in.o
WARNING: drivers/usb/built-in.o(.data+0x14684): Section mismatch in reference from the variable fotg210_driver to the function .init.text:fotg210_udc_probe() The variable fotg210_driver references
the function __init fotg210_udc_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
LD drivers/built-in.o
WARNING: drivers/built-in.o(.data+0x8b0c8): Section mismatch in reference from the variable fotg210_driver to the function .init.text:fotg210_udc_probe() The variable fotg210_driver references
the function __init fotg210_udc_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
CHK include/generated/uapi/linux/version.h LINK vmlinux LD vmlinux.o
MODPOST vmlinux.o
WARNING: vmlinux.o(.data+0xc6730): Section mismatch in reference from the variable fotg210_driver to the function .init.text:fotg210_udc_probe() The variable fotg210_driver references
the function __init fotg210_udc_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
GEN .version CHK include/generated/compile.h UPD include/generated/compile.h CC init/version.o LD init/built-in.o
.exit.text' referenced in section .data' of drivers/built-in.o: defined in discarded section `.exit.text' of drivers/built-in.o make[3]: *** [vmlinux] Error 1
--- drivers/usb/gadget/fotg210-udc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/gadget/fotg210-udc.c +2 -2
@@ -1074,7 +1074,7 @@ static struct usb_gadget_ops fotg210_gadget_ops = { .udc_stop = fotg210_udc_stop, }; -static int __exit fotg210_udc_remove(struct platform_device *pdev) +static int fotg210_udc_remove (struct platform_device *pdev) {struct fotg210_udc *fotg210 =dev_get_drvdata (&pdev->dev);
@@ -1088,7 +1088,7 @@ static int __exit fotg210_udc_remove(struct platform_device *pdev)return 0 ; } -static int __init fotg210_udc_probe (struct platform_device *pdev) +static int fotg210_udc_probe (struct platform_device *pdev) {struct resource *res, *ires;struct fotg210_udc *fotg210 =NULL ;
Signature · 1 line
1.7.9.5
Quoted 55 lines · Geert Uytterhoeven
When builtin (
CONFIG_USB_FOTG210_UDC=y):LD
drivers/usb/gadget/built-in.o
WARNING: drivers/usb/gadget/built-in.o(.data+0xbf8): Section mismatch in reference from the variablefotg210_driverto the function .init.text:fotg210_udc_probe() The variablefotg210_driverreferences
the function__initfotg210_udc_probe()
If the reference is valid then annotate the
variable with __init* or__refdata(seelinux/init.h) or name the variable:*_template,*_timer,*_sht,*_ops,*_probe,*_probe_one,*_consoleLD
drivers/usb/built-in.o
WARNING: drivers/usb/built-in.o(.data+0x14684): Section mismatch in reference from the variablefotg210_driverto the function .init.text:fotg210_udc_probe() The variablefotg210_driverreferences
the function__initfotg210_udc_probe()
If the reference is valid then annotate the
variable with __init* or__refdata(seelinux/init.h) or name the variable:*_template,*_timer,*_sht,*_ops,*_probe,*_probe_one,*_consoleLD
drivers/built-in.o
WARNING: drivers/built-in.o(.data+0x8b0c8): Section mismatch in reference from the variablefotg210_driverto the function .init.text:fotg210_udc_probe() The variablefotg210_driverreferences
the function__initfotg210_udc_probe()
If the reference is valid then annotate the
variable with __init* or__refdata(seelinux/init.h) or name the variable:*_template,*_timer,*_sht,*_ops,*_probe,*_probe_one,*_consoleCHK include/generated/uapi/linux/version.h LINK vmlinux LD vmlinux.oMODPOST vmlinux.o
WARNING:vmlinux.o(.data+0xc6730): Section mismatch in reference from the variablefotg210_driverto the function .init.text:fotg210_udc_probe() The variablefotg210_driverreferences
the function__initfotg210_udc_probe()
If the reference is valid then annotate the
variable with __init* or__refdata(seelinux/init.h) or name the variable:*_template,*_timer,*_sht,*_ops,*_probe,*_probe_one,*_consoleGEN .version CHK include/generated/compile.h UPD include/generated/compile.h CC init/version.o LD init/built-in.o
.exit.text' referenced in section.data' ofdrivers/built-in.o: defined in discarded section `.exit.text' ofdrivers/built-in.omake[3]: *** [vmlinux] Error 1Signed-off-by Geert Uytterhoeven <[email protected]>--- drivers/usb/gadget/fotg210-udc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/usb/gadget/fotg210-udc.c +0
-0
drivers/usb/gadget/fotg210-udc.c static struct usb_gadget_ops fotg210_gadget_ops = { · line 1077
Quoted 5 lines
drivers/usb/gadget/fotg210-udc.c +1
-1@@ -1074,7 +1074,7 @@ static struct usb_gadget_ops fotg210_gadget_ops = { .udc_stop = fotg210_udc_stop, }; -static int __exit fotg210_udc_remove(struct platform_device *pdev) +static int fotg210_udc_remove (struct platform_device *pdev)
I think you can leave __exit annotation here, if you enclose the
reference in the driver structure in __exit_p()...
WBR, Sergei
Quoted 24 lines · Sergei Shtylyov
Quoted 22 lines · Geert Uytterhoeven
When builtin (
CONFIG_USB_FOTG210_UDC=y):LD
drivers/usb/gadget/built-in.o
WARNING: drivers/usb/gadget/built-in.o(.data+0xbf8): Section mismatch in reference from the variablefotg210_driverto the function .init.text:fotg210_udc_probe()
The variablefotg210_driverreferences
the function__initfotg210_udc_probe()
If the reference is valid then annotate the
variable with __init* or__refdata(seelinux/init.h) or name the variable:*_template,*_timer,*_sht,*_ops,*_probe,*_probe_one,*_consoledrivers/usb/gadget/fotg210-udc.c +0
-0@@ -1074,7 +1074,7 @@ static struct usb_gadget_ops fotg210_gadget_ops = { .udc_stop = fotg210_udc_stop, };
Quoted 6 lines
drivers/usb/gadget/fotg210-udc.c static struct usb_gadget_ops fotg210_gadget_ops = { · line 1077
Quoted 2 lines
drivers/usb/gadget/fotg210-udc.c +1
-1-static int __exit fotg210_udc_remove(struct platform_device *pdev) +static int fotg210_udc_remove (struct platform_device *pdev)I think you can leave
__exitannotation here, if you enclose the
reference in the driver structure in__exit_p()...
The driver is using module_platform_driver(), not module_platform_driver_probe(),
so it expects the platform device to show up or disappear anytime.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Hello.
Quoted 28 lines · Geert Uytterhoeven
Quoted 22 lines
Quoted 22 lines
When builtin (
CONFIG_USB_FOTG210_UDC=y):LD
drivers/usb/gadget/built-in.o
WARNING: drivers/usb/gadget/built-in.o(.data+0xbf8): Section mismatch in reference from the variablefotg210_driverto the function .init.text:fotg210_udc_probe()
The variablefotg210_driverreferences
the function__initfotg210_udc_probe()
If the reference is valid then annotate the
variable with __init* or__refdata(seelinux/init.h) or name the variable:*_template,*_timer,*_sht,*_ops,*_probe,*_probe_one,*_consoledrivers/usb/gadget/fotg210-udc.c +0
-0@@ -1074,7 +1074,7 @@ static struct usb_gadget_ops fotg210_gadget_ops = { .udc_stop = fotg210_udc_stop, };Quoted 5 lines
drivers/usb/gadget/fotg210-udc.c static struct usb_gadget_ops fotg210_gadget_ops = { · line 1077
Quoted 2 lines
drivers/usb/gadget/fotg210-udc.c +1
-1-static int __exit fotg210_udc_remove(struct platform_device *pdev) +static int fotg210_udc_remove (struct platform_device *pdev)I think you can leave
__exitannotation here, if you enclose the
reference in the driver structure in__exit_p()...
Quoted 3 lines
The driver is using
module_platform_driver(), notmodule_platform_driver_probe(),
so it expects the platform device to show up or disappear anytime.
Well, I don't think it actually does. Perhaps the reason was that
the latter function wasn't available yet at the time of conversion to the former (IIRC it appeared later).
WBR, Sergei
Quoted 42 lines · Geert Uytterhoeven
When builtin (
CONFIG_USB_FOTG210_UDC=y):LD
drivers/usb/gadget/built-in.o
WARNING: drivers/usb/gadget/built-in.o(.data+0xbf8): Section mismatch in reference from the variablefotg210_driverto the function .init.text:fotg210_udc_probe() The variablefotg210_driverreferences
the function__initfotg210_udc_probe()
If the reference is valid then annotate the
variable with __init* or__refdata(seelinux/init.h) or name the variable:*_template,*_timer,*_sht,*_ops,*_probe,*_probe_one,*_consoleLD
drivers/usb/built-in.o
WARNING: drivers/usb/built-in.o(.data+0x14684): Section mismatch in reference from the variablefotg210_driverto the function .init.text:fotg210_udc_probe() The variablefotg210_driverreferences
the function__initfotg210_udc_probe()
If the reference is valid then annotate the
variable with __init* or__refdata(seelinux/init.h) or name the variable:*_template,*_timer,*_sht,*_ops,*_probe,*_probe_one,*_consoleLD
drivers/built-in.o
WARNING: drivers/built-in.o(.data+0x8b0c8): Section mismatch in reference from the variablefotg210_driverto the function .init.text:fotg210_udc_probe() The variablefotg210_driverreferences
the function__initfotg210_udc_probe()
If the reference is valid then annotate the
variable with __init* or__refdata(seelinux/init.h) or name the variable:*_template,*_timer,*_sht,*_ops,*_probe,*_probe_one,*_consoleCHK include/generated/uapi/linux/version.h LINK vmlinux LD vmlinux.oMODPOST vmlinux.o
WARNING:vmlinux.o(.data+0xc6730): Section mismatch in reference from the variablefotg210_driverto the function .init.text:fotg210_udc_probe() The variablefotg210_driverreferences
the function__initfotg210_udc_probe()
If the reference is valid then annotate the
variable with __init* or__refdata(seelinux/init.h) or name the variable:*_template,*_timer,*_sht,*_ops,*_probe,*_probe_one,*_consoleGEN .version CHK include/generated/compile.h UPD include/generated/compile.h CC init/version.o LD init/built-in.o
Quoted 4 lines
.exit.text' referenced in section.data' ofdrivers/built-in.o: defined in discarded section `.exit.text' ofdrivers/built-in.omake[3]: *** [vmlinux] Error 1Signed-off-by Geert Uytterhoeven <[email protected]>
has already being sent before. Sorry
Signature · 1 line
balbi