Skip to contentSkip to conversation

x86/pci: fix checkpatch.pl indentation warnings

PATCH In review Valentina Manea 2 participants 2 messages Jul 11, 2013 – Jul 12, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/pci: fix checkpatch.pl indentation warnings

This patch fixes warnings generated by checkpatch.pl regarding indentation.

---
 arch/x86/pci/mrst.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/pci/mrst.c +2 -2
index 6eb18c4..cd0a373 100644
@@ -251,8 +251,8 @@ static void pci_d3delay_fixup(struct pci_dev *dev)
 {
 	/* PCI fixups are effectively decided compile time. If we have a dual
 	   SoC/non-SoC kernel we don't want to mangle d3 on non SoC devices */
-        if (!pci_soc_mode)
-            return;
+	if (!pci_soc_mode)
+		return;
 	/* true pci devices in lincroft should allow type 1 access, the rest
 	 * are langwell fake pci devices.
 	 */
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 13 lines · Valentina Manea

This patch fixes warnings generated by checkpatch.pl regarding indentation.

---
 arch/x86/pci/mrst.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/pci/mrst.c +0 -0
index 6eb18c4..cd0a373 100644

arch/x86/pci/mrst.c static void pci_d3delay_fixup(struct pci_dev *dev) · line 258

Quoted 10 lines
arch/x86/pci/mrst.c +2 -2
@@ -251,8 +251,8 @@ static void pci_d3delay_fixup(struct pci_dev *dev)
 {
 	/* PCI fixups are effectively decided compile time. If we have a dual
 	   SoC/non-SoC kernel we don't want to mangle d3 on non SoC devices */
-        if (!pci_soc_mode)
-            return;
+	if (!pci_soc_mode)
+		return;
 	/* true pci devices in lincroft should allow type 1 access, the rest
 	 * are langwell fake pci devices.
 	 */

If you do whitespace cleanups then please also fix all the other problems in that file, right now mrst.c has more than just one:

total: 3 errors, 7 warnings, 3 checks, 303 lines checked

plus the area you patched has some wierd comment formatting as well. For multi-line comments we use:

/*
* Comment .....
* ...... goes here.
*/

as specified in Documentation/CodingStyle.

Thanks,

Ingo