nds32: Enable FPU if the version of CPU supported
PATCH 1/1 nds32: Enable FPU if the version of CPU supported
Some version of Andes core support FPU coprocessor, if this is the case, we should enable it at low level initialization time.
--- arch/nds32/cpu/n1213/ag101/lowlevel_init.S | 22 ++++++++++++++++++++++ arch/nds32/cpu/n1213/ag102/lowlevel_init.S | 22 ++++++++++++++++++++++ 2 files changed, 44 insertions(+)
arch/nds32/cpu/n1213/ag101/lowlevel_init.S +22 -0
@@ -98,6 +98,9 @@ lowlevel_init: led 0x10 jal remap + led 0x1f + jal enable_fpu + led 0x20 ret $r10
@@ -234,6 +237,25 @@ relo_base: 2: ret + /* + * enable_fpu: + * Some of Andes CPU version support FPU coprocessor, if so, + * we should enable it. + */ +enable_fpu: + mfsr $r0, $CPU_VER /* enable FPU if it exists */ + srli $r0, $r0, 3 + andi $r0, $r0, 1 + beqz $r0, 1f /* skip if no COP */ + mfsr $r0, $FUCOP_EXIST + srli $r0, $r0, 31 + beqz $r0, 1f /* skip if no FPU */ + mfsr $r0, $FUCOP_CTL + ori $r0, $r0, 1 + mtsr $r0, $FUCOP_CTL +1: + ret + .globl show_led show_led: li $r8, (CONFIG_DEBUG_LED)
arch/nds32/cpu/n1213/ag102/lowlevel_init.S +22 -0
@@ -114,6 +114,9 @@ lowlevel_init: led 0x20 jal remap + led 0x2f + jal enable_fpu + led 0x30 ret $r10
@@ -289,6 +292,25 @@ relo_base: 2: ret + /* + * enable_fpu: + * Some of Andes CPU version support FPU coprocessor, if so, + * we should enable it. + */ +enable_fpu: + mfsr $r0, $CPU_VER /* enable FPU if it exists */ + srli $r0, $r0, 3 + andi $r0, $r0, 1 + beqz $r0, 1f /* skip if no COP */ + mfsr $r0, $FUCOP_EXIST + srli $r0, $r0, 31 + beqz $r0, 1f /* skip if no FPU */ + mfsr $r0, $FUCOP_CTL + ori $r0, $r0, 1 + mtsr $r0, $FUCOP_CTL +1: + ret + .globl show_led show_led: li $r8, (CONFIG_DEBUG_LED)
Signature · 1 line
1.7.9.5
PATCH 1/1 nds32: Enable FPU if the version of CPU supported
Hi Kuan-Yu Kuo,
2013/7/18 Kuan-Yu Kuo <[email protected]>:
Quoted 6 lines
arch/nds32/cpu/n1213/ag101/lowlevel_init.S +6
-0+ /* + * enable_fpu: + * Some of Andes CPU version support FPU coprocessor, if so, + * we should enable it. + */ +enable_fpu:
arch/nds32/cpu/n1213/ag101/lowlevel_init.S relo_base: · line 255
Quoted 10 lines
arch/nds32/cpu/n1213/ag101/lowlevel_init.S +10
-0+ mfsr $r0, $CPU_VER /* enable FPU if it exists */ + srli $r0, $r0, 3 + andi $r0, $r0, 1 + beqz $r0, 1f /* skip if no COP */ + mfsr $r0, $FUCOP_EXIST + srli $r0, $r0, 31 + beqz $r0, 1f /* skip if no FPU */ + mfsr $r0, $FUCOP_CTL + ori $r0, $r0, 1 + mtsr $r0, $FUCOP_CTL
There are two kinds of toolchain in Andes architecture, one is FPU supported and the other is not, for the latter one, there is no need to enable FPU even if the processor supports it. This code snippet only useful for the toolchain that will generate FPU instructions, so add compile option to determine Andes predefined macros would be better. For example:
#if defined(NDS32_EXT_FPU_DP) || defined(NDS32_EXT_FPU_SP)
Andes Technology Corporation
PATCH 1/1 nds32: Enable FPU if the version of CPU supported
Hi Kuan-Yu,
2013/7/18 <[email protected]>:
Quoted 2 lines
Hi Kuan-Yu Kuo,
...
Quoted 11 lines
arch/nds32/cpu/n1213/ag101/lowlevel_init.S relo_base: · line 255
Quoted 11 lines
arch/nds32/cpu/n1213/ag101/lowlevel_init.S +11
-0+enable_fpu: + mfsr $r0, $CPU_VER /* enable FPU if it exists */ + srli $r0, $r0, 3 + andi $r0, $r0, 1 + beqz $r0, 1f /* skip if no COP */ + mfsr $r0, $FUCOP_EXIST + srli $r0, $r0, 31 + beqz $r0, 1f /* skip if no FPU */ + mfsr $r0, $FUCOP_CTL + ori $r0, $r0, 1 + mtsr $r0, $FUCOP_CTL
WARNING: line over 80 characters
#53: FILE: arch/nds32/cpu/n1213/ag101/lowlevel_init.S:249:
+ beqz $r0, 1f /*
skip if no COP */
WARNING: line over 80 characters
#56: FILE: arch/nds32/cpu/n1213/ag101/lowlevel_init.S:252:
+ beqz $r0, 1f /*
skip if no FPU */
WARNING: line over 80 characters
#93: FILE: arch/nds32/cpu/n1213/ag102/lowlevel_init.S:304:
+ beqz $r0, 1f /*
skip if no COP */
WARNING: line over 80 characters
#96: FILE: arch/nds32/cpu/n1213/ag102/lowlevel_init.S:307:
+ beqz $r0, 1f /*
skip if no FPU */
1. Please clean up this patch and check with checkpatch.pl then resend it.
Quoted 7 lines
There are two kinds of toolchain in Andes architecture, one is FPU supported and the other is not, for the latter one, there is no need to enable FPU even if the processor supports it. This code snippet only useful for the toolchain that will generate FPU instructions, so add compile option to determine Andes predefined macros would be better. For example:
#ifdefined(NDS32_EXT_FPU_DP)||defined(NDS32_EXT_FPU_SP)Andes Technology Corporation
2. According to the official suggestion from Andes Technology Corporation, your patch will be better to reorganized with these macro definitions to help the toolchain to distinguish the differences. But! The most users cannot distinguish the differences of these toolchain-with-SoC combination, hence I think to keep the most Error-Proof protection will be better.
Thanks.
Signature · 2 lines
Best regards, Macpaul Lin
PATCH v2 1/1 nds32: Enable FPU if the version of CPU supported
In reply to Kuan-Yu KuoSome version of Andes core support FPU coprocessor, if this is the case, and toolchain support FPU instruction set, we should enable it at low level initialization time.
---
Change for v2:
- Add compile option to determine if current used toolchain support FPU instruction or not.
arch/nds32/cpu/n1213/ag101/lowlevel_init.S | 26 ++++++++++++++++++++++++++ arch/nds32/cpu/n1213/ag102/lowlevel_init.S | 26 ++++++++++++++++++++++++++ 2 files changed, 52 insertions(+)
arch/nds32/cpu/n1213/ag101/lowlevel_init.S +26 -0
@@ -98,6 +98,11 @@ lowlevel_init: led 0x10 jal remap +#if (defined(NDS32_EXT_FPU_DP) || defined(NDS32_EXT_FPU_SP)) + led 0x1f + jal enable_fpu +#endif + led 0x20 ret $r10
@@ -234,6 +239,27 @@ relo_base: 2: ret + /* + * enable_fpu: + * Some of Andes CPU version support FPU coprocessor, if so, + * and toolchain support FPU instruction set, we should enable it. + */ +#if (defined(NDS32_EXT_FPU_DP) || defined(NDS32_EXT_FPU_SP)) +enable_fpu: + mfsr $r0, $CPU_VER /* enable FPU if it exists */ + srli $r0, $r0, 3 + andi $r0, $r0, 1 + beqz $r0, 1f /* skip if no COP */ + mfsr $r0, $FUCOP_EXIST + srli $r0, $r0, 31 + beqz $r0, 1f /* skip if no FPU */ + mfsr $r0, $FUCOP_CTL + ori $r0, $r0, 1 + mtsr $r0, $FUCOP_CTL +1: + ret +#endif + .globl show_led show_led: li $r8, (CONFIG_DEBUG_LED)
arch/nds32/cpu/n1213/ag102/lowlevel_init.S +26 -0
@@ -114,6 +114,11 @@ lowlevel_init: led 0x20 jal remap +#if (defined(NDS32_EXT_FPU_DP) || defined(NDS32_EXT_FPU_SP)) + led 0x2f + jal enable_fpu +#endif + led 0x30 ret $r10
@@ -289,6 +294,27 @@ relo_base: 2: ret + /* + * enable_fpu: + * Some of Andes CPU version support FPU coprocessor, if so, + * and toolchain support FPU instruction set, we should enable it. + */ +#if (defined(NDS32_EXT_FPU_DP) || defined(NDS32_EXT_FPU_SP)) +enable_fpu: + mfsr $r0, $CPU_VER /* enable FPU if it exists */ + srli $r0, $r0, 3 + andi $r0, $r0, 1 + beqz $r0, 1f /* skip if no COP */ + mfsr $r0, $FUCOP_EXIST + srli $r0, $r0, 31 + beqz $r0, 1f /* skip if no FPU */ + mfsr $r0, $FUCOP_CTL + ori $r0, $r0, 1 + mtsr $r0, $FUCOP_CTL +1: + ret +#endif + .globl show_led show_led: li $r8, (CONFIG_DEBUG_LED)
Signature · 1 line
1.7.9.5
PATCH v2 1/1 nds32: Enable FPU if the version of CPU supported
Hi Kuan-Yu,
2013/7/25 Kuan-Yu Kuo <[email protected]>:
Quoted 6 lines
Some version of Andes core support FPU coprocessor, if this is the case, and toolchain support FPU instruction set, we should enable it at low level initialization time.
Signed-off-by Kuan-Yu Kuo <[email protected]>Cc Macpaul Lin <[email protected]>
Quoted 9 lines
---
Change for v2:
- Add compile option to determine if current used toolchain support FPU instruction or not.arch/nds32/cpu/n1213/ag101/lowlevel_init.S | 26 ++++++++++++++++++++++++++ arch/nds32/cpu/n1213/ag102/lowlevel_init.S | 26 ++++++++++++++++++++++++++ 2 files changed, 52 insertions(+)
Applied to u-boot-nds32.
Thanks!
Signature · 2 lines
Best regards, Macpaul Lin