Skip to contentSkip to conversation

perf, x86: Report TSX transaction abort cost as weight

PATCH New Andi Kleen 1 participant 1 message Jul 18, 2013

Subsystems (2)
lore
Share & tools
lore

Andi Kleen

author
#0 lore raw

PATCH 1/1 perf, x86: Report TSX transaction abort cost as weight

From: Andi Kleen <[email protected]>

[This requires one patch to the user space code to revert afab87b91f3f331d so that --weight works again without perf mem. The patch has been submitted separately]

Use the existing weight reporting facility to report the transaction abort cost, that is the number of cycles wasted in aborts. Haswell reports this in the PEBS record.

This was in fact the original user for weight.

This is a very useful sort key to concentrate on the most costly aborts and a good metric for TSX tuning.

---
 arch/x86/kernel/cpu/perf_event_intel_ds.c | 6 ++++++
 1 file changed, 6 insertions(+)
arch/x86/kernel/cpu/perf_event_intel_ds.c +6 -0
index 3065c57..8959cc7 100644
@@ -838,6 +838,12 @@ static void __intel_pmu_pebs_event(struct perf_event *event,
 		x86_pmu.intel_cap.pebs_format >= 1)
 		data.addr = pebs->dla;
 
+	if ((event->attr.sample_type & PERF_SAMPLE_WEIGHT) &&
+	    !fll &&
+	    (x86_pmu.intel_cap.pebs_format >= 2) &&
+	    pebs_hsw->tsx_tuning)
+		data.weight = pebs_hsw->tsx_tuning & 0xffffffff;
+
 	if (has_branch_stack(event))
 		data.br_stack = &cpuc->lbr_stack;
 
Signature · 1 line
1.8.1.4