net: phy: Set SUPPORTED_1000baseX_Half flag in ESTATUS_1000_XHALF case

PATCH New Fabio Estevam 5 participants 10 messages Jul 19, 2013

Subsystems (2)

Network drivers Ethernet PHY

lore

Share & tools

lore

Fabio Estevam

author

2013-07-19 13:01 UTC #0 lore raw

PATCH 1/1 net: phy: Set SUPPORTED_1000baseX_Half flag in ESTATUS_1000_XHALF case

From: Fabio Estevam <[email protected]>

Commit de1d786e (add support for Xilinx 1000BASE-X phy (GTX)) introduced the checking for ESTATUS_1000_XHALF, but it incorrectly sets the SUPPORTED_1000baseX_Full flag in this case.

Set the SUPPORTED_1000baseX_Half flag instead.

Signed-off-by Fabio Estevam <[email protected]>

---
 drivers/net/phy/phy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/net/phy/phy.c +1 -1

index 5ddb926..5692b1c 100644
@@ -404,7 +404,7 @@ int genphy_config(struct phy_device *phydev)
 		if (val & ESTATUS_1000_XFULL)
 			features |= SUPPORTED_1000baseX_Full;
 		if (val & ESTATUS_1000_XHALF)
-			features |= SUPPORTED_1000baseX_Full;
+			features |= SUPPORTED_1000baseX_Half;
 	}
 
 	phydev->supported = features;

Signature · 1 line

1.8.1.2

Charles Coldwell

2013-07-19 13:59 UTC #1 lore raw

PATCH 1/1 net: phy: Set SUPPORTED_1000baseX_Half flag in ESTATUS_1000_XHALF case

Quoted 5 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>
Commit de1d786e (add support for Xilinx 1000BASE-X phy (GTX)) introduced the checking for ESTATUS_1000_XHALF, but it incorrectly sets the SUPPORTED_1000baseX_Full flag in this case.

Signed-off-by Charles Coldwell <[email protected]>

--
Charles M. Coldwell, W1CMC
Belmont, Massachusetts, New England
"Turn on, log in, tune out"

Fabio Estevam

author

2013-07-19 14:01 UTC #2 lore raw

PATCH 1/1 net: phy: Set SUPPORTED_1000baseX_Half flag in ESTATUS_1000_XHALF case

Hi Charles,

Quoted 8 lines · Charles Coldwell

Quoted 5 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Commit de1d786e (add support for Xilinx 1000BASE-X phy (GTX)) introduced the checking for ESTATUS_1000_XHALF, but it incorrectly sets the SUPPORTED_1000baseX_Full flag in this case.
Signed-off-by Charles Coldwell <[email protected]>

I guess you meant Acked-by instead?

Charles Coldwell

2013-07-19 14:02 UTC #3 lore raw

PATCH 1/1 net: phy: Set SUPPORTED_1000baseX_Half flag in ESTATUS_1000_XHALF case

Quoted 6 lines · Fabio Estevam

Hi Charles,
Quoted 3 lines · Charles Coldwell
Quoted 2 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>

Quoted 7 lines

Quoted 5 lines
Quoted 3 lines
Commit de1d786e (add support for Xilinx 1000BASE-X phy (GTX)) introduced the checking for ESTATUS_1000_XHALF, but it incorrectly sets the SUPPORTED_1000baseX_Full flag in this case.
Signed-off-by Charles Coldwell <[email protected]>
I guess you meant Acked-by instead?

Sigh. Indeed, acked. My LKML skills are rusty.

--
Charles M. Coldwell, W1CMC
Belmont, Massachusetts, New England
"Turn on, log in, tune out"

Sascha Silbe

2013-07-19 15:50 UTC #4 lore raw

PATCH 1/1 net: phy: Set SUPPORTED_1000baseX_Half flag in ESTATUS_1000_XHALF case

In reply to Fabio Estevam

Quoted 5 lines · Fabio Estevam

Commit de1d786e (add support for Xilinx 1000BASE-X phy (GTX)) introduced the checking for ESTATUS_1000_XHALF, but it incorrectly sets the SUPPORTED_1000baseX_Full flag in this case.
Set the SUPPORTED_1000baseX_Half flag instead.

Nice catch.

Reviewed-by Sascha Silbe <[email protected]>

No test done as my current test set-up is 100Base-T only.

Sascha
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 489 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130719/53680c16/attachment.pgp>

Tom Rini

2013-07-19 16:55 UTC #5 lore raw

PATCH 1/1 net: phy: Set SUPPORTED_1000baseX_Half flag in ESTATUS_1000_XHALF case

In reply to Fabio Estevam

Quoted 9 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>
Commit de1d786e (add support for Xilinx 1000BASE-X phy (GTX)) introduced the checking for ESTATUS_1000_XHALF, but it incorrectly sets the SUPPORTED_1000baseX_Full flag in this case.
Set the SUPPORTED_1000baseX_Half flag instead.
Signed-off-by Fabio Estevam <[email protected]>

So, do we need both patches to fix the problem?

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130719/bfd2c0a7/attachment.pgp>

Charles Coldwell

2013-07-19 16:56 UTC #6 lore raw

PATCH 1/1 net: phy: Set SUPPORTED_1000baseX_Half flag in ESTATUS_1000_XHALF case

Quoted 8 lines · Tom Rini

Quoted 6 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Commit de1d786e (add support for Xilinx 1000BASE-X phy (GTX)) introduced the checking for ESTATUS_1000_XHALF, but it incorrectly sets the SUPPORTED_1000baseX_Full flag in this case.

Quoted 5 lines

Quoted 3 lines
Set the SUPPORTED_1000baseX_Half flag instead.
Signed-off-by Fabio Estevam <[email protected]>
So, do we need both patches to fix the problem?

One patch fixes "the" problem; the other fixes another problem we haven't seen yet (but will).

--
Charles M. Coldwell, W1CMC
Belmont, Massachusetts, New England
"Turn on, log in, tune out"

Fabio Estevam

author

2013-07-19 19:20 UTC #7 lore raw

PATCH 1/1 net: phy: Set SUPPORTED_1000baseX_Half flag in ESTATUS_1000_XHALF case

Hi Tom,

Quoted 9 lines · Charles Coldwell

Quoted 8 lines · Tom Rini
Quoted 6 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Commit de1d786e (add support for Xilinx 1000BASE-X phy (GTX)) introduced the checking for ESTATUS_1000_XHALF, but it incorrectly sets the SUPPORTED_1000baseX_Full flag in this case.

Quoted 8 lines

Quoted 5 lines
Quoted 3 lines
Set the SUPPORTED_1000baseX_Half flag instead.
Signed-off-by Fabio Estevam <[email protected]>
So, do we need both patches to fix the problem?
One patch fixes "the" problem; the other fixes another problem we haven't seen yet (but will).

I agree with Charles.

Sascha Silbe's patch fixes the regression we noticed on some mx6 boards.

This one is about a different issue and it is not related to the previous problem.

IMHO we should apply both of them.

Thanks,

Fabio Estevam

Joe Hershberger

2013-07-19 18:15 UTC #8 lore raw

PATCH 1/1 net: phy: Set SUPPORTED_1000baseX_Half flag in ESTATUS_1000_XHALF case

In reply to Fabio Estevam

Quoted 9 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>
Commit de1d786e (add support for Xilinx 1000BASE-X phy (GTX)) introduced the checking for ESTATUS_1000_XHALF, but it incorrectly sets the SUPPORTED_1000baseX_Full flag in this case.
Set the SUPPORTED_1000baseX_Half flag instead.
Signed-off-by Fabio Estevam <[email protected]>

Reviewed-by Joe Hershberger <[email protected]>

Tom Rini

2013-07-19 21:13 UTC #9 lore raw

PATCH 1/1 net: phy: Set SUPPORTED_1000baseX_Half flag in ESTATUS_1000_XHALF case

In reply to Fabio Estevam

Quoted 9 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>
Commit de1d786e (add support for Xilinx 1000BASE-X phy (GTX)) introduced the checking for ESTATUS_1000_XHALF, but it incorrectly sets the SUPPORTED_1000baseX_Full flag in this case.
Set the SUPPORTED_1000baseX_Half flag instead.
Signed-off-by Fabio Estevam <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130719/cc424b82/attachment.pgp>