perf, x86: Enable PEBS mode automatically for mem-{loads,stores} v4
Subsystems (2)
PATCH 1/1 perf, x86: Enable PEBS mode automatically for mem-{loads,stores} v4
From: Andi Kleen <[email protected]>
[The patch to enable this in the user tools has been sent separately]
With the earlier patches to automatically try cpu// and add a precise sys attribute, we can now enable PEBS for the mem-loads, mem-stores events everywhere.
This allows to use
perf record -e mem-loads ...
instead of
perf record -e cpu/mem-loads/p ...
Always use precise=2 even though it is costly pre-Haswell
Cc: [email protected]
v2: Different white space
v3: Always use precise=2, as people seem to think overhead doesn't matter.
v4: Longer lines
--- arch/x86/kernel/cpu/perf_event_intel.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
arch/x86/kernel/cpu/perf_event_intel.c +6 -5
@@ -176,9 +176,9 @@ static struct extra_reg intel_snbep_extra_regs[] __read_mostly = {EVENT_EXTRA_END }; -EVENT_ATTR_STR (mem-loads, mem_ld_nhm,"event=0x0b,umask=0x10,ldlat=3" ); -EVENT_ATTR_STR (mem-loads, mem_ld_snb,"event=0xcd,umask=0x1,ldlat=3" ); -EVENT_ATTR_STR (mem-stores, mem_st_snb,"event=0xcd,umask=0x2" ); +EVENT_ATTR_STR (mem-loads, mem_ld_nhm,"event=0x0b,umask=0x10,ldlat=3,precise=2" ); +EVENT_ATTR_STR (mem-loads, mem_ld_snb,"event=0xcd,umask=0x1,ldlat=3,precise=2" ); +EVENT_ATTR_STR (mem-stores, mem_st_snb,"event=0xcd,umask=0x2,precise=2" );struct attribute *nhm_events_attrs[] = {EVENT_PTR (mem_ld_nhm),
@@ -2034,8 +2034,9 @@ static __init void intel_nehalem_quirk(void) } } -EVENT_ATTR_STR (mem-loads, mem_ld_hsw,"event=0xcd,umask=0x1,ldlat=3" ); -EVENT_ATTR_STR(mem-stores, mem_st_hsw, "event=0xd0,umask=0x82") +EVENT_ATTR_STR (mem-loads, mem_ld_hsw, +"event=0xcd,umask=0x1,ldlat=3,precise=2" ); +EVENT_ATTR_STR(mem-stores, mem_st_hsw, "event=0xd0,umask=0x82,precise=2")static struct attribute *hsw_events_attrs[] = {EVENT_PTR (mem_ld_hsw),
Signature · 1 line
1.8.1.4
Quoted 3 lines · Andi Kleen
From: Andi Kleen <[email protected]>
[The patch to enable this in the user tools has been sent separately]
Why are they not in the same series, Cc:-ed to the same parties?
Thanks,
Ingo