Skip to contentSkip to conversation

hw_random: mxc-rnga: Check the return value from clk_prepare_enable()

PATCH In review Fabio Estevam 2 participants 2 messages Jul 21, 2013 – Aug 1, 2013

Subsystems (2)
Arm i.MX and Layerscape Hardware random number generator core
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 hw_random: mxc-rnga: Check the return value from clk_prepare_enable()

From: Fabio Estevam <[email protected]>

clk_prepare_enable() may fail, so let's check its return value and propagate it in the case of error.

Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/char/hw_random/mxc-rnga.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/char/hw_random/mxc-rnga.c +3 -1
index 19a12ac..6a86b6f 100644
@@ -164,7 +164,9 @@ static int __init mxc_rnga_probe(struct platform_device *pdev)
 		goto out;
 	}
 
-	clk_prepare_enable(mxc_rng->clk);
+	err = clk_prepare_enable(mxc_rng->clk);
+	if (err)
+		goto out;
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	mxc_rng->mem = devm_ioremap_resource(&pdev->dev, res);
Signature · 1 line
1.8.1.2
#1 lore raw
Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

clk_prepare_enable() may fail, so let's check its return value and propagate it in the case of error.

Signed-off-by Fabio Estevam <[email protected]>

Patch applied. Thanks!

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt