nand: mxc_nand: Remove unneeded check for platform_get_resource()

PATCH Applied Fabio Estevam 2 participants 2 messages Jul 21, 2013 – Aug 2, 2013

Subsystems (3)

Arm i.MX and Layerscape Memory technology devices (MTD) NAND flash

lore

Share & tools

lore

Fabio Estevam

author reviewer

2013-07-21 17:52 UTC #0 lore raw

PATCH 1/1 nand: mxc_nand: Remove unneeded check for platform_get_resource()

From: Fabio Estevam <[email protected]>

devm_ioremap_resource() checks its arguments, so there is no need for explicitly checking the return value from platform_get_resource().

Signed-off-by Fabio Estevam <[email protected]>

---
 drivers/mtd/nand/mxc_nand.c | 5 -----
 1 file changed, 5 deletions(-)

drivers/mtd/nand/mxc_nand.c +0 -5

index 18855ad..0581bd3 100644
@@ -1446,8 +1446,6 @@ static int mxcnd_probe(struct platform_device *pdev)
 
 	if (host->devtype_data->needs_ip) {
 		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-		if (!res)
-			return -ENODEV;
 		host->regs_ip = devm_ioremap_resource(&pdev->dev, res);
 		if (IS_ERR(host->regs_ip))
 			return PTR_ERR(host->regs_ip);

@@ -1457,9 +1455,6 @@ static int mxcnd_probe(struct platform_device *pdev)
 		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	}
 
-	if (!res)
-		return -ENODEV;
-
 	host->base = devm_ioremap_resource(&pdev->dev, res);
 	if (IS_ERR(host->base))
 		return PTR_ERR(host->base);

Signature · 1 line

1.8.1.2

Artem Bityutskiy

Applied

2013-08-02 15:30 UTC #1 lore raw

Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>
devm_ioremap_resource() checks its arguments, so there is no need for explicitly checking the return value from platform_get_resource().
Signed-off-by Fabio Estevam <[email protected]>

Pushed to l2-mtd.git, thanks!

Signature · 2 lines

Best Regards,
Artem Bityutskiy