Skip to contentSkip to conversation

ARM: dts: mxs: Add spi alias

PATCH Superseded Fabio Estevam 3 participants 3 messages Jul 22, 2013 – Jul 23, 2013

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 ARM: dts: mxs: Add spi alias

From: Fabio Estevam <[email protected]>

After providing spi alias, we can get the following message during probe:

m25p80 spi1.0: sst25vf016b (2048 Kbytes)

,which looks better than the original one:

m25p80 spi32766.0: sst25vf016b (2048 Kbytes)

While at it, keep the alias entries in alphabetical order.

Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/boot/dts/imx23.dtsi | 2 ++
 arch/arm/boot/dts/imx28.dtsi | 6 ++++--
 2 files changed, 6 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx23.dtsi +2 -0
index 1e528db..28b5ce2 100644
@@ -20,6 +20,8 @@
 		gpio2 = &gpio2;
 		serial0 = &auart0;
 		serial1 = &auart1;
+		spi0 = &ssp0;
+		spi1 = &ssp1;
 	};
 
 	cpus {
arch/arm/boot/dts/imx28.dtsi +4 -2
index db67eb6..89d98a1 100644
@@ -15,6 +15,8 @@
 	interrupt-parent = <&icoll>;
 
 	aliases {
+		ethernet0 = &mac0;
+		ethernet1 = &mac1;
 		gpio0 = &gpio0;
 		gpio1 = &gpio1;
 		gpio2 = &gpio2;

@@ -22,13 +24,13 @@
 		gpio4 = &gpio4;
 		saif0 = &saif0;
 		saif1 = &saif1;
+		spi0 = &ssp1;
+		spi1 = &ssp2;
 		serial0 = &auart0;
 		serial1 = &auart1;
 		serial2 = &auart2;
 		serial3 = &auart3;
 		serial4 = &auart4;
-		ethernet0 = &mac0;
-		ethernet1 = &mac1;
 	};
 
 	cpus {
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH 1/1 ARM: dts: mxs: Add spi alias

Quoted 45 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

After providing spi alias, we can get the following message during probe:

m25p80 spi1.0: sst25vf016b (2048 Kbytes)

,which looks better than the original one:

m25p80 spi32766.0: sst25vf016b (2048 Kbytes)

While at it, keep the alias entries in alphabetical order.

Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/boot/dts/imx23.dtsi | 2 ++
 arch/arm/boot/dts/imx28.dtsi | 6 ++++--
 2 files changed, 6 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx23.dtsi +2 -0
index 1e528db..28b5ce2 100644
@@ -20,6 +20,8 @@
 		gpio2 = &gpio2;
 		serial0 = &auart0;
 		serial1 = &auart1;
+		spi0 = &ssp0;
+		spi1 = &ssp1;
 	};
 
 	cpus {
arch/arm/boot/dts/imx28.dtsi +2 -0
index db67eb6..89d98a1 100644
@@ -15,6 +15,8 @@
 	interrupt-parent = <&icoll>;
 
 	aliases {
+		ethernet0 = &mac0;
+		ethernet1 = &mac1;
 		gpio0 = &gpio0;
 		gpio1 = &gpio1;
 		gpio2 = &gpio2;

arch/arm/boot/dts/imx28.dtsi line 28

Quoted 5 lines
arch/arm/boot/dts/imx28.dtsi +2 -0
@@ -22,13 +24,13 @@
 		gpio4 = &gpio4;
 		saif0 = &saif0;
 		saif1 = &saif1;
+		spi0 = &ssp1;
+		spi1 = &ssp2;

So this should be put after serial, right?

Shawn

Quoted 13 lines
arch/arm/boot/dts/imx28.dtsi +0 -2
 		serial0 = &auart0;
 		serial1 = &auart1;
 		serial2 = &auart2;
 		serial3 = &auart3;
 		serial4 = &auart4;
-		ethernet0 = &mac0;
-		ethernet1 = &mac1;
 	};
 
 	cpus {
Signature · 1 line
1.8.1.2
#2 lore raw

PATCH 1/1 ARM: dts: mxs: Add spi alias

On 07/23/2013 10:38 AM, Shawn Guo wrote:
gpio2 = &gpio2;

Quoted 8 lines

arch/arm/boot/dts/imx28.dtsi line 28

Quoted 6 lines
arch/arm/boot/dts/imx28.dtsi +2 -0
@@ -22,13 +24,13 @@
  		gpio4 = &gpio4;
  		saif0 = &saif0;
  		saif1 = &saif1;
+		spi0 = &ssp1;
+		spi1 = &ssp2;

So this should be put after serial, right?

Yes, please check v2, which has this fixed.

Thanks,

Fabio Estevam