Skip to contentSkip to conversation

gpio_msm: Fix build error due to missing err.h

PATCH In review Stephen Boyd 3 participants 3 messages Jul 24, 2013 – Jul 29, 2013 GPIO

lore
Share & tools
lore

Stephen Boyd

author
#0 lore raw

PATCH 1/1 gpio_msm: Fix build error due to missing err.h

drivers/gpio/gpio-msm-v1.c: In function 'gpio_msm_v1_probe':
drivers/gpio/gpio-msm-v1.c:656:2:
error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration] drivers/gpio/gpio-msm-v1.c:657:3:
error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration]

This driver failed to compile after commit 68515bb (gpio_msm: Convert to use devm_ioremap_resource, 2013-06-10).

Cc Tushar Behera <[email protected]>
Signed-off-by Stephen Boyd <[email protected]>
---
 drivers/gpio/gpio-msm-v1.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpio/gpio-msm-v1.c +1 -0
index e3ceaac..73b7396 100644
@@ -21,6 +21,7 @@
 #include <linux/module.h>
 #include <linux/device.h>
 #include <linux/platform_device.h>
+#include <linux/err.h>
 
 #include <mach/msm_gpiomux.h>
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Stephen Boyd

drivers/gpio/gpio-msm-v1.c: In function 'gpio_msm_v1_probe':
drivers/gpio/gpio-msm-v1.c:656:2:
error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration] drivers/gpio/gpio-msm-v1.c:657:3:
error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration]

Quoted 6 lines

This driver failed to compile after commit 68515bb (gpio_msm: Convert to use devm_ioremap_resource, 2013-06-10).

Cc Tushar Behera <[email protected]>
Signed-off-by Stephen Boyd <[email protected]>

Sorry for this. I must have messed up while testing this patchset.

Acked-by Tushar Behera <[email protected]>
Quoted 17 lines
---
 drivers/gpio/gpio-msm-v1.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpio/gpio-msm-v1.c +1 -0
index e3ceaac..73b7396 100644
@@ -21,6 +21,7 @@
 #include <linux/module.h>
 #include <linux/device.h>
 #include <linux/platform_device.h>
+#include <linux/err.h>
 
 #include <mach/msm_gpiomux.h>
Signature · 1 line
Tushar Behera
#2 lore raw
In reply to Stephen Boyd
Quoted 8 lines · Stephen Boyd

drivers/gpio/gpio-msm-v1.c: In function 'gpio_msm_v1_probe':
drivers/gpio/gpio-msm-v1.c:656:2:
error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration] drivers/gpio/gpio-msm-v1.c:657:3:
error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration]

Quoted 6 lines

This driver failed to compile after commit 68515bb (gpio_msm: Convert to use devm_ioremap_resource, 2013-06-10).

Cc Tushar Behera <[email protected]>
Signed-off-by Stephen Boyd <[email protected]>

Thanks, patch applied and queued for fixes.

Yours,
Linus Walleij