drm/i915: dvo_ch7xxx: fix vsync polarity setting
Subsystems (2)
PATCH 1/1 drm/i915: dvo_ch7xxx: fix vsync polarity setting
This fixes a typo which set the wrong vsync and possibly also hsync polarity for any modes with positive vsync polarity.
--- drivers/gpu/drm/i915/dvo_ch7xxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/dvo_ch7xxx.c +1 -1
@@ -307,7 +307,7 @@ static void ch7xxx_mode_set(struct intel_dvo_device *dvo, idf |= CH7xxx_IDF_HSP;if (mode->flags &DRM_MODE_FLAG_PVSYNC ) - idf |= CH7xxx_IDF_HSP; + idf |= CH7xxx_IDF_VSP;ch7xxx_writeb (dvo, CH7xxx_IDF, idf); }
Signature · 1 line
1.8.3.2
Quoted 2 lines · Imre Deak
This fixes a typo which set the wrong vsync and possibly also hsync polarity for any modes with positive vsync polarity.
Note that this typo exists in the very first import of KMS:
commit 79e539453b34e35f39299a899d263b0a1f1670bd
Author: Jesse Barnes <[email protected]> Date: Fri Nov 7 14:24:08 2008 -0800
DRM: i915: add mode setting support
Quoted 1 line
Signed-off-by Imre Deak <[email protected]>
-Chris
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
Daniel Vetter
AppliedQuoted 6 lines · Chris Wilson
Quoted 2 lines · Imre Deak
This fixes a typo which set the wrong vsync and possibly also hsync polarity for any modes with positive vsync polarity.
Note that this typo exists in the very first import of KMS:
commit79e539453b34e35f39299a899d263b0a1f1670bd
Quoted 8 lines
Author: Jesse Barnes <[email protected]> Date: Fri Nov 7 14:24:08 2008 -0800DRM: i915: add mode setting support
Quoted 1 line
Signed-off-by Imre Deak <[email protected]>Cc Jesse Barnes <[email protected]>Reviewed-by Chris Wilson <[email protected]>
Queued for -next, thanks for the patch.
-Daniel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch