Skip to contentSkip to conversation

regulator: s2mps11: Fix wrong arguments for regmap_update_bits() call

PATCH Applied Axel Lin 2 participants 2 messages Aug 3, 2013 – Aug 13, 2013

Subsystems (2)
Voltage and current regulator framework Samsung multifunction PMIC device drivers
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 regulator: s2mps11: Fix wrong arguments for regmap_update_bits() call

Current code calls regmap_update_bits() with mask and val arguments swapped.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/regulator/s2mps11.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/regulator/s2mps11.c +2 -2
index f047d36..89140ae 100644
@@ -207,8 +207,8 @@ static int s2mps11_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay)
 				  ramp_val << ramp_shift, 1 << ramp_shift);
 
 ramp_disable:
-	return regmap_update_bits(rdev->regmap, S2MPS11_REG_RAMP, 0,
-				  1 << enable_shift);
+	return regmap_update_bits(rdev->regmap, S2MPS11_REG_RAMP,
+				  1 << enable_shift, 0);
 }
 
 static struct regulator_ops s2mps11_ldo_ops = {
Signature · 1 line
1.8.1.2
maintainer Applied
#1 lore raw
Quoted 1 line · Axel Lin

Current code calls regmap_update_bits() with mask and val arguments swapped.

Applied, thanks.