Skip to contentSkip to conversation

radeon: Use Linux division macro in si_calculate_leakage_for_v_and_t_formula

PATCH In review Andi Kleen 2 participants 2 messages Aug 9, 2013

Subsystems (2)
DRM drivers Radeon and amdgpu DRM drivers
lore
Share & tools
lore

Andi Kleen

author
#0 lore raw

PATCH 1/1 radeon: Use Linux division macro in si_calculate_leakage_for_v_and_t_formula

From: Andi Kleen <[email protected]>

This fixes my 32bit build which failed with:

drivers/built-in.o: In function `si_calculate_leakage_for_v_and_t_formula':
/home/ak/lsrc/git/linux-2.6/drivers/gpu/drm/radeon/si_dpm.c:1770:
undefined reference to `__divdi3'

Cc [email protected]
Cc [email protected]
Signed-off-by Andi Kleen <[email protected]>
---
 drivers/gpu/drm/radeon/si_dpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/radeon/si_dpm.c +1 -1
index 7ad22e8..4182557 100644
@@ -1767,7 +1767,7 @@ static void si_calculate_leakage_for_v_and_t_formula(const struct ni_leakage_coe
 	s64 temperature, t_slope, t_intercept, av, bv, t_ref;
 	s64 tmp;
 
-	i_leakage = drm_int2fixp(ileakage) / 100;
+	i_leakage = div64_s64(drm_int2fixp(ileakage), 100);
 	vddc = div64_s64(drm_int2fixp(v), 1000);
 	temperature = div64_s64(drm_int2fixp(t), 1000);
Signature · 1 line
1.8.3.1
maintainer
#1 lore raw

Fix is already merged:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=adfb8e51332153016857194b85309150ac560286

Quoted 42 lines

-----Original Message-----
From: Andi Kleen [mailto:[email protected]]
Sent: Friday, August 09, 2013 11:58 AM
To: [email protected]
Cc: Andi Kleen; [email protected]; Deucher, Alexander
Subject: [PATCH] radeon: Use Linux division macro in si_calculate_leakage_for_v_and_t_formula

From: Andi Kleen <[email protected]>

This fixes my 32bit build which failed with:

drivers/built-in.o: In function `si_calculate_leakage_for_v_and_t_formula':
/home/ak/lsrc/git/linux-2.6/drivers/gpu/drm/radeon/si_dpm.c:1770:
undefined reference to `__divdi3'

Cc [email protected]
Cc [email protected]
Signed-off-by Andi Kleen <[email protected]>
---
 drivers/gpu/drm/radeon/si_dpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/radeon/si_dpm.c +0 -0
index 7ad22e8..4182557 100644
@@ -1767,7 +1767,7 @@ static void

si_calculate_leakage_for_v_and_t_formula(const struct ni_leakage_coe

drivers/gpu/drm/radeon/si_dpm.c +1 -2
 	s64 temperature, t_slope, t_intercept, av, bv, t_ref;
 	s64 tmp;
 
-	i_leakage = drm_int2fixp(ileakage) / 100;
+	i_leakage = div64_s64(drm_int2fixp(ileakage), 100);
 	vddc = div64_s64(drm_int2fixp(v), 1000);
 	temperature = div64_s64(drm_int2fixp(t), 1000);
 
--

1.8.3.1