serial: amba-pl011: Use releases/acquires annotations

PATCH New Fabio Estevam 1 participant 1 message Aug 9, 2013

Subsystems (2)

TTY layer and serial drivers Arm primecell UART PL010 and PL011 drivers

lore

Share & tools

lore

Fabio Estevam

author

2013-08-09 20:59 UTC #0 lore raw

PATCH 1/1 serial: amba-pl011: Use __releases/__acquires annotations

From: Fabio Estevam <[email protected]>

Fix the following sparse warnings:

drivers/tty/serial/amba-pl011.c:687:20: warning: context imbalance in 'pl011_dma_flush_buffer' - unexpected unlock drivers/tty/serial/amba-pl011.c:1200:13: warning: context imbalance in 'pl011_rx_chars' - unexpected unlock

Signed-off-by Fabio Estevam <[email protected]>

---
 drivers/tty/serial/amba-pl011.c | 4 ++++
 1 file changed, 4 insertions(+)

drivers/tty/serial/amba-pl011.c +4 -0

index eb38fb8..aaa2286 100644
@@ -677,6 +677,8 @@ static inline bool pl011_dma_tx_start(struct uart_amba_port *uap)
  * Locking: called with port lock held and IRQs disabled.
  */
 static void pl011_dma_flush_buffer(struct uart_port *port)
+__releases(&uap->port.lock)
+__acquires(&uap->port.lock)
 {
 	struct uart_amba_port *uap = (struct uart_amba_port *)port;

@@ -1198,6 +1200,8 @@ static void pl011_enable_ms(struct uart_port *port)
 }
 
 static void pl011_rx_chars(struct uart_amba_port *uap)
+__releases(&uap->port.lock)
+__acquires(&uap->port.lock)
 {
 	pl011_fifo_to_tty(uap);

Signature · 1 line

1.8.1.2