xfs: another chunk of comment fixes
cover xfs: another chunk of comment fixes
From: Zhi Yong Wu <[email protected]>
Submit another chunk of xfs comment fixes.
Zhi Yong Wu (12):
xfs: fix the comment of xfs_bmap_count_tree()
xfs: fix the comment of xfs_bmap_validate_ret()
xfs: fix the comment of xfs_bmap_last_before()
xfs: fix the comment of xfs_bmap_punch_delalloc_range()
xfs: fix the comment of xfs_setsize_buftarg_early()
xfs: fix the comment of xfs_extent_busy_update_extent()
xfs: fix the comment of xfs_ialloc_ag_select()
xfs: fix the comment of xfs_ifree_cluster()
xfs: fix the comment of xfs_log_unmount_write()
xfs: fix the comment of xlog_recover_do_dquot_buffer()
xfs: fix the comment of xfs_sb_quiet_read_verify()
xfs: fix the comment of xfs_mountfs()
fs/xfs/xfs_bmap.c | 10 +++++----- fs/xfs/xfs_buf.c | 2 +- fs/xfs/xfs_extent_busy.c | 2 +- fs/xfs/xfs_ialloc.c | 2 +- fs/xfs/xfs_inode.c | 2 +- fs/xfs/xfs_log.c | 2 +- fs/xfs/xfs_log_recover.c | 2 +- fs/xfs/xfs_mount.c | 4 ++-- 8 files changed, 13 insertions(+), 13 deletions(-)
Signature · 6 lines
1.7.11.7 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 1/12 xfs: fix the comment of xfs_bmap_count_tree()
From: Zhi Yong Wu <[email protected]>
--- fs/xfs/xfs_bmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_bmap.c +1 -1
@@ -306,7 +306,7 @@ xfs_bmap_disk_count_leaves(/* * Recursively walks each level of a btree -* to count total fsblocks is use. +* to count total fsblocks in use. */ STATIC int /* error */ xfs_bmap_count_tree(
Signature · 6 lines
1.7.11.7 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 2/12 xfs: fix the comment of xfs_bmap_validate_ret()
In reply to [email protected]From: Zhi Yong Wu <[email protected]>
--- fs/xfs/xfs_bmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/xfs/xfs_bmap.c +2 -2
@@ -724,8 +724,8 @@ xfs_bmap_trace_exlist(/* * Validate that the bmbt_irecs being returned from bmapi are valid -* given the callers original parameters. Specifically check the -* ranges of the returned irecs to ensure that they only extent beyond +* given the caller's original parameters. Specifically check the +* ranges of the returned irecs to ensure that they only extend beyond * the given parameters if the XFS_BMAPI_ENTIRE flag was set. */ STATIC void
Signature · 6 lines
1.7.11.7 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 3/12 xfs: fix the comment of xfs_bmap_last_before()
In reply to [email protected]From: Zhi Yong Wu <[email protected]>
--- fs/xfs/xfs_bmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_bmap.c +1 -1
@@ -1815,7 +1815,7 @@ xfs_bmap_first_unused( }/* -* Returns the file-relative block number of the last block + 1 before +* Returns the file-relative block number of the last block - 1 before * last_block (input value) in the file. * This is not based on i_size, it is based on the extent records. * Returns 0 for local files, as they do not have extent records.
Signature · 6 lines
1.7.11.7 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 4/12 xfs: fix the comment of xfs_bmap_punch_delalloc_range()
In reply to [email protected]From: Zhi Yong Wu <[email protected]>
--- fs/xfs/xfs_bmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_bmap.c +1 -1
@@ -6074,7 +6074,7 @@ xfs_getbmap(/* * dead simple method of punching delalyed allocation blocks from a range in * the inode. Walks a block at a time so will be slow, but is only executed in -* rare error cases so the overhead is not critical. This will alays punch out +* rare error cases so the overhead is not critical. This will always punch out * both the start and end blocks, even if the ranges only partially overlap * them, so it is up to the caller to ensure that partial blocks are not * passed in.
Signature · 6 lines
1.7.11.7 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 5/12 xfs: fix the comment of xfs_setsize_buftarg_early()
In reply to [email protected]From: Zhi Yong Wu <[email protected]>
--- fs/xfs/xfs_buf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_buf.c +1 -1
@@ -1621,7 +1621,7 @@ xfs_setsize_buftarg_flags(/* * When allocating the initial buffer target we have not yet * read in the superblock, so don't know what sized sectors -* are being used is at this early stage. Play safe. +* are being used at this early stage. Play safe. */ STATIC int xfs_setsize_buftarg_early(
Signature · 6 lines
1.7.11.7 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 6/12 xfs: fix the comment of xfs_extent_busy_update_extent()
In reply to [email protected]From: Zhi Yong Wu <[email protected]>
--- fs/xfs/xfs_extent_busy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_extent_busy.c +1 -1
@@ -147,7 +147,7 @@ xfs_extent_busy_search(* extent. If the overlap covers the beginning, the end, or all of the busy * extent, the overlapping portion can be made unbusy and used for the * allocation. We can't split a busy extent because we can't modify a -* transaction/CIL context busy list, but we can update an entries block +* transaction/CIL context busy list, but we can update an entrie's block * number or length. * * Returns true if the extent can safely be reused, or false if the search
Signature · 6 lines
1.7.11.7 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Re: [PATCH 06/12] xfs: fix the comment of xfs_extent_busy_update_extent()
Quoted 12 lines · On 08/11/13 22:14, [email protected] wrote:
From: Zhi Yong Wu<[email protected]>
Signed-off-by Zhi Yong Wu<[email protected]>--- fs/xfs/xfs_extent_busy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/xfs/xfs_extent_busy.c +0
-0
fs/xfs/xfs_extent_busy.c xfs_extent_busy_search( · line 150
Quoted 5 lines
fs/xfs/xfs_extent_busy.c +1
-1@@ -147,7 +147,7 @@ xfs_extent_busy_search(* extent. If the overlap covers the beginning, the end, or all of the busy * extent, the overlapping portion can be made unbusy and used for the * allocation. We can't split a busy extent because we can't modify a -* transaction/CIL context busy list, but we can update an entries block +* transaction/CIL context busy list, but we can update an entrie's block
^^^^^^
changed that to entry's
fs/xfs/xfs_extent_busy.c xfs_extent_busy_search( · line 153
Quoted 3 lines
fs/xfs/xfs_extent_busy.c +0
-0* number or length. * * Returns true if the extent can safely be reused, or false if the search
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Re: [PATCH 06/12] xfs: fix the comment of xfs_extent_busy_update_extent()
Quoted 9 lines · Mark Tinguely
Quoted 8 lines · On 08/11/13 22:14, [email protected] wrote:
From: Zhi Yong Wu<[email protected]>
Signed-off-by Zhi Yong Wu<[email protected]>--- fs/xfs/xfs_extent_busy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines
Quoted 11 lines
fs/xfs/xfs_extent_busy.c +0
-0@@ -147,7 +147,7 @@ xfs_extent_busy_search(* extent. If the overlap covers the beginning, the end, or all of the busy
* extent, the overlapping portion can be made unbusy and used for the
* allocation. We can't split a busy extent because we can't modify a
- * transaction/CIL context busy list, but we can update an entries block
+ * transaction/CIL context busy list, but we can update an entrie's block^^^^^^
changed that to entry's
Good catch, thanks.
Quoted 7 lines
Quoted 5 lines
* number or length.
*
* Returns true if the extent can safely be reused, or false if the
search
Signature · 8 lines
Regards, Zhi Yong Wu _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 7/12 xfs: fix the comment of xfs_ialloc_ag_select()
In reply to [email protected]From: Zhi Yong Wu <[email protected]>
--- fs/xfs/xfs_ialloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_ialloc.c +1 -1
@@ -506,7 +506,7 @@ xfs_ialloc_next_ag(/* * Select an allocation group to look for a free inode in, based on the parent -* inode and then mode. Return the allocation group buffer. +* inode and the mode. Return the allocation group buffer. */ STATIC xfs_agnumber_t xfs_ialloc_ag_select(
Signature · 6 lines
1.7.11.7 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 8/12 xfs: fix the comment of xfs_ifree_cluster()
In reply to [email protected]From: Zhi Yong Wu <[email protected]>
--- fs/xfs/xfs_inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_inode.c +1 -1
@@ -1861,7 +1861,7 @@ xfs_iunlink_remove( }/* -* A big issue when freeing the inode cluster is is that we _cannot_ skip any +* A big issue when freeing the inode cluster is that we _cannot_ skip any * inodes that are in memory - they all must be marked stale and attached to * the cluster buffer. */
Signature · 6 lines
1.7.11.7 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 9/12 xfs: fix the comment of xfs_log_unmount_write()
In reply to [email protected]From: Zhi Yong Wu <[email protected]>
--- fs/xfs/xfs_log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_log.c +1 -1
@@ -720,7 +720,7 @@ xfs_log_mount_finish(xfs_mount_t *mp)* Unmount record used to have a string "Unmount filesystem--" in the * data section where the "Un" was really a magic number (XLOG_UNMOUNT_TYPE). * We just write the magic number now since that particular field isn't -* currently architecture converted and "nUmount" is a bit foo. +* currently architecture converted and "Unmount" is a bit foo. * As far as I know, there weren't any dependencies on the old behaviour. */
Signature · 6 lines
1.7.11.7 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 10/12 xfs: fix the comment of xlog_recover_do_dquot_buffer()
In reply to [email protected]From: Zhi Yong Wu <[email protected]>
--- fs/xfs/xfs_log_recover.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_log_recover.c +1 -1
@@ -2366,7 +2366,7 @@ xfs_qm_dqcheck(/* * Perform a dquot buffer recovery. -* Simple algorithm: if we have found a QUOTAOFF logitem of the same type +* Simple algorithm: if we have found a QUOTAOFF log item of the same type * (ie. USR or GRP), then just toss this buffer away; don't recover it. * Else, treat it as a regular buffer and do recovery. */
Signature · 6 lines
1.7.11.7 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 11/12 xfs: fix the comment of xfs_sb_quiet_read_verify()
In reply to [email protected]From: Zhi Yong Wu <[email protected]>
--- fs/xfs/xfs_mount.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_mount.c +1 -1
@@ -785,7 +785,7 @@ out_error:/* * We may be probed for a filesystem match, so we may not want to emit * messages when the superblock buffer is not actually an XFS superblock. -* If we find an XFS superblock, the run a normal, noisy mount because we are +* If we find an XFS superblock, then run a normal, noisy mount because we are * really going to mount it and want to know about errors. */ static void
Signature · 6 lines
1.7.11.7 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
PATCH 12/12 xfs: fix the comment of xfs_mountfs()
In reply to [email protected]From: Zhi Yong Wu <[email protected]>
--- fs/xfs/xfs_mount.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/xfs_mount.c +1 -1
@@ -1400,7 +1400,7 @@ xfs_mountfs(xfs_set_inoalignment (mp);/* -* Check that the data (and log if separate) are an ok size. +* Check that the data (and log if separate) is an ok size. */ error =xfs_check_sizes (mp);if (error)
Signature · 6 lines
1.7.11.7 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Quoted 4 lines · On 08/11/13 22:14, [email protected] wrote:
From: Zhi Yong Wu<[email protected]>
Submit another chunk of xfs comment fixes.
Quoted 13 lines
Zhi Yong Wu (12):
xfs: fix the comment ofxfs_bmap_count_tree()
xfs: fix the comment ofxfs_bmap_validate_ret()
xfs: fix the comment ofxfs_bmap_last_before()
xfs: fix the comment ofxfs_bmap_punch_delalloc_range()
xfs: fix the comment ofxfs_setsize_buftarg_early()
xfs: fix the comment ofxfs_extent_busy_update_extent()
xfs: fix the comment ofxfs_ialloc_ag_select()
xfs: fix the comment ofxfs_ifree_cluster()
xfs: fix the comment ofxfs_log_unmount_write()
xfs: fix the comment ofxlog_recover_do_dquot_buffer()
xfs: fix the comment ofxfs_sb_quiet_read_verify()
xfs: fix the comment ofxfs_mountfs()
I fixed up the files:
xfs_inode.c -> xfs_inode_fork.c
xfs_bmap.c -> xfs_bmap_util.c
The mentioned patch 6/12 in this series.
I will send the changes to Ben
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Ben Myers
AppliedQuoted 3 lines · On Mon, Aug 12, 2013 at 11:14:51AM +0800, [email protected] wrote:
From: Zhi Yong Wu <[email protected]>
Submit another chunk of xfs comment fixes.
Applied this series. Thanks.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs