Basic Multicast Optimizations
This is the eighth revision of the basic multicast optimization patches.
It adds many style + functional changes and fixes some bugs.
It also adds a new, important fifth patch, which addresses an issue that I would have overlooked if it weren't for the extensive offline talks with Simon about the interaction of batman-adv and various multicast related RFCs.
# Changelog v7 -> v8
## Style improvements
* renamed batadv_mcast_tt_clean() tobatadv_mcast_tt_retract()
* renamed batadv_mcast_tvlv_update_flag_counter() to batadv_mcast_update_counter()
* renamed batadv_mcast_mla_tt_update() to batadv_mcast_mla_update()
* renamed batadv_mcast_update_counter() to batadv_mcast_counter_update()
* renamed BATADV_MCAST_HAS_NO_BRIDGE to BATADV_MCAST_WANT_ALL_UNSNOOPABLES (and reverse its logic)
* change value of BATADV_UNINIT_FLAGS from -1 to an unused bit, BIT(15)
-> no more need to check BATADV_UNINIT_FLAGS in batadv_mcast_counter_update()
* moved code from batadv_mcast_mla_tt_update() to newly introduced batadv_mcast_mla_tvlv_update
* moved introduction of multicast_mode sysfs file to the third patch
* added kernel doc for struct batadv_priv_mcast and enum batadv_mcast_flag
## Functional improvements
* changed a '== -EINVAL' to '< 0'
* check for a bridge anywhere on top of bat0 (like br0 on bond0 on bat0, not just br0 on bat0)
(as discussed on IRC we don't need to check for bridges on top of vlans yet as multicast
optimizations are only enabled for non-VLAN packets at the moment)
* removed sysfs file control over multicast TT+TVLV announcements, moved sysfs file introduction to the third patch
* removed BATADV_MCAST_LISTENER_ANNOUNCEMENT flag: its purpose is now provided by checking the existence of the multicast tvlv instead
* made the tvlv value length check in the multicast tvlv handler to not only accept a length of one byte but anything greater, too
* New Patch: batman-adv: Send multicast packets to nodes with a WANT_ALL flag
## Bugs
* converted the static 'enabled' variable in batadv_mcast_mla_tt_update() to a per bat_priv variable, using bat_priv->mcast.flags (fixes a bug when using multiple batX interfaces)
* the announced tvlv was missing the BATADV_MCAST_HAS_NO_BRIDGE flag (not needed anymore with the reversed logic)
* batadv_mcast_update_counter() was missing a case which would have needed a BATADV_UNINIT_FLAGS check (not needed anymore with reversed logic and new value for BATADV_UNINIT_FLAGS)
* added missing update for num_want_all_unsnoopables (former num_has_bridge) counter in batadv_mcast_purge_orig()
Cheers, Linus
PATCH v8 1/5 batman-adv: Multicast Listener Announcements via Translation Table
With this patch a node which has no bridge interface on top of its soft interface announces its local multicast listeners via the translation table.
--- Makefile | 2 + Makefile.kbuild | 1 + compat.h | 41 ++++++++ gen-compat-autoconf.sh | 1 + main.c | 6 ++ main.h | 1 + multicast.c | 243 ++++++++++++++++++++++++++++++++++++++++++++++++ multicast.h | 43 +++++++++ translation-table.c | 22 ++++- types.h | 23 +++++ 10 files changed, 379 insertions(+), 4 deletions(-) create mode 100644 multicast.c create mode 100644 multicast.h
Makefile +2 -0
@@ -27,6 +27,8 @@ export CONFIG_BATMAN_ADV_BLA=y export CONFIG_BATMAN_ADV_DAT=y # B.A.T.M.A.N network coding (catwoman): export CONFIG_BATMAN_ADV_NC=n +# B.A.T.M.A.N. multicast optimizations: +export CONFIG_BATMAN_ADV_MCAST=y PWD:=$(shell pwd) KERNELPATH ?= /lib/modules/$(shell uname -r)/build
Makefile.kbuild +1 -0
@@ -38,3 +38,4 @@ batman-adv-y += send.o batman-adv-y += soft-interface.o batman-adv-y += sysfs.o batman-adv-y += translation-table.o +batman-adv-$(CONFIG_BATMAN_ADV_MCAST) += multicast.o
compat.h +41 -0
59 lines not on this page · raw message
gen-compat-autoconf.sh +1 -0
@@ -39,6 +39,7 @@ gen_config() { gen_config 'CONFIG_BATMAN_ADV_DEBUG' ${CONFIG_BATMAN_ADV_DEBUG:="n"} >> "${TMP}" gen_config 'CONFIG_BATMAN_ADV_BLA' ${CONFIG_BATMAN_ADV_BLA:="y"} >> "${TMP}" gen_config 'CONFIG_BATMAN_ADV_DAT' ${CONFIG_BATMAN_ADV_DAT:="y"} >> "${TMP}" +gen_config 'CONFIG_BATMAN_ADV_MCAST' ${CONFIG_BATMAN_ADV_MCAST:="y"} >> "${TMP}" gen_config 'CONFIG_BATMAN_ADV_NC' ${CONFIG_BATMAN_ADV_NC:="n"} >> "${TMP}" # only regenerate compat-autoconf.h when config was changed
main.c +6 -0
@@ -36,6 +36,7 @@#include "gateway_client.h" #include "bridge_loop_avoidance.h" #include "distributed-arp-table.h" +#include "multicast.h" #include "gateway_common.h" #include "hash.h" #include "bat_algo.h"
@@ -121,6 +122,9 @@ int batadv_mesh_init(struct net_device *soft_iface)INIT_LIST_HEAD (&bat_priv->tt.changes_list);INIT_LIST_HEAD (&bat_priv->tt.req_list);INIT_LIST_HEAD (&bat_priv->tt.roam_list); +#ifdef CONFIG_BATMAN_ADV_MCAST +INIT_HLIST_HEAD (&bat_priv->mcast.mla_list); +#endif INIT_HLIST_HEAD (&bat_priv->tvlv.container_list);INIT_HLIST_HEAD (&bat_priv->tvlv.handler_list);INIT_HLIST_HEAD (&bat_priv->softif_vlan_list);
@@ -172,6 +176,8 @@ void batadv_mesh_free(struct net_device *soft_iface)batadv_dat_free (bat_priv);batadv_bla_free (bat_priv); +batadv_mcast_free (bat_priv); +/* Free the TT and the originator tables only after having terminated * all the other depending components which may use these structures for * their purposes.
main.h +1 -0
@@ -164,6 +164,7 @@ enum batadv_uev_type {#include <linux/percpu.h> #include <linux/slab.h> #include <net/sock.h> /* struct sock */ +#include <net/addrconf.h> /* ipv6 address stuff */ #include <net/rtnetlink.h> #include <linux/jiffies.h> #include <linux/seq_file.h>
multicast.c new file +243 -0
243 lines not on this page · raw message
multicast.h new file +43 -0
43 lines not on this page · raw message
translation-table.c +18 -4
@@ -26,6 +26,7 @@#include "originator.h" #include "routing.h" #include "bridge_loop_avoidance.h" +#include "multicast.h" #include <linux/crc32c.h>
@@ -445,14 +446,16 @@ void batadv_tt_local_add(struct net_device *soft_iface, const uint8_t *addr, {struct batadv_priv *bat_priv =netdev_priv (soft_iface);struct batadv_tt_local_entry *tt_local; -struct batadv_tt_global_entry *tt_global; +struct batadv_tt_global_entry *tt_global =NULL ;struct hlist_head *head;struct batadv_tt_orig_list_entry *orig_entry;int hash_added;bool roamed_back = false; tt_local =batadv_tt_local_hash_find (bat_priv, addr, vid); - tt_global =batadv_tt_global_hash_find (bat_priv, addr, vid); + +if (!is_multicast_ether_addr (addr)) + tt_global =batadv_tt_global_hash_find (bat_priv, addr, vid);if (tt_local) { tt_local->last_seen = jiffies;
@@ -506,8 +509,11 @@ void batadv_tt_local_add(struct net_device *soft_iface, const uint8_t *addr, tt_local->last_seen = jiffies; tt_local->common.added_at = tt_local->last_seen; -/* the batman interface mac address should never be purged */ -if (batadv_compare_eth (addr, soft_iface->dev_addr)) +/* the batman interface mac and multicast addresses should never be +* purged +*/ +if (batadv_compare_eth (addr, soft_iface->dev_addr) || +is_multicast_ether_addr (addr)) tt_local->common.flags |=BATADV_TT_CLIENT_NOPURGE ; hash_added = batadv_hash_add(bat_priv->tt.local_hash, batadv_compare_tt,
@@ -1258,6 +1264,11 @@ add_orig_entry: ret = true; out_remove: +/* Do not remove multicast addresses from the local hash on +* global additions +*/ +if (is_multicast_ether_addr (tt_addr)) + goto out;/* remove address from local hash if present */ local_flags = batadv_tt_local_remove(bat_priv, tt_addr, vid,
@@ -2967,6 +2978,9 @@ void batadv_tt_local_commit_changes(struct batadv_priv *bat_priv) {spin_lock_bh (&bat_priv->tt.commit_lock); +/* Update multicast addresses in local translation table */ +batadv_mcast_mla_update (bat_priv); +if (atomic_read (&bat_priv->tt.local_changes) <1 ) {if (!batadv_atomic_dec_not_zero (&bat_priv->tt.ogm_append_cnt))batadv_tt_tvlv_container_update (bat_priv);
types.h +23 -0
@@ -537,6 +537,16 @@ struct batadv_priv_dat { };#endif +#ifdef CONFIG_BATMAN_ADV_MCAST +/** +* struct batadv_priv_mcast - per mesh interface mcast data +* @mla_list: list of multicast addresses we are currently announcing via TT +*/ +struct batadv_priv_mcast { +struct hlist_head mla_list; +}; +#endif +/** * struct batadv_priv_nc - per mesh interface network coding private data * @work: work queue callback item for cleanup
@@ -684,6 +694,9 @@ struct batadv_priv {#ifdef CONFIG_BATMAN_ADV_DAT struct batadv_priv_dat dat;#endif +#ifdef CONFIG_BATMAN_ADV_MCAST +struct batadv_priv_mcast mcast; +#endif #ifdef CONFIG_BATMAN_ADV_NC atomic_t network_coding;struct batadv_priv_nc nc;
@@ -1009,6 +1022,16 @@ struct batadv_dat_entry { };/** +* struct batadv_hw_addr - a list entry for a MAC address +* @list: list node for the linking of entries +* @addr: the MAC address of this list entry +*/ +struct batadv_hw_addr { +struct hlist_node list; +unsigned char addr[ETH_ALEN ]; +}; + +/** * struct batadv_dat_candidate - candidate destination for DAT operations * @type: the type of the selected candidate. It can one of the following: * - BATADV_DAT_CANDIDATE_NOT_FOUND
Signature · 1 line
1.7.10.4
PATCH v8 2/5 batman-adv: Announce new capability via multicast TVLV
In reply to Linus LüssingIf the soft interface of a node is not part of a bridge then a node announces a new multicast TVLV: The existence of this TVLV signalizes that this node is announcing all of its multicast listeners via the translation table infrastructure.
--- main.c | 4 ++ main.h | 1 + multicast.c | 125 +++++++++++++++++++++++++++++++++++++++++++++++++++--- multicast.h | 14 ++++++ originator.c | 6 +++ packet.h | 2 + soft-interface.c | 4 ++ types.h | 11 +++++ 8 files changed, 162 insertions(+), 5 deletions(-)
main.c +4 -0
@@ -149,6 +149,10 @@ int batadv_mesh_init(struct net_device *soft_iface)if (ret <0 ) goto err; + ret =batadv_mcast_init (bat_priv); +if (ret <0 ) + goto err; + ret =batadv_gw_init (bat_priv);if (ret <0 ) goto err;
main.h +1 -0
@@ -68,6 +68,7 @@#define BATADV_ROAMING_MAX_TIME 20000#define BATADV_ROAMING_MAX_COUNT 5 +#define BATADV_UNINIT_FLAGS BIT(15)#define BATADV_NO_FLAGS 0#define BATADV_NULL_IFINDEX 0/* dummy ifindex used to avoid iface checks */
multicast.c +120 -5
151 lines not on this page · raw message
multicast.h +14 -0
@@ -24,8 +24,12 @@void batadv_mcast_mla_update (struct batadv_priv *bat_priv); +int batadv_mcast_init (struct batadv_priv *bat_priv); +void batadv_mcast_free (struct batadv_priv *bat_priv); +void batadv_mcast_purge_orig (struct batadv_orig_node *orig_node); +#else static inline void batadv_mcast_mla_update (struct batadv_priv *bat_priv)
@@ -33,11 +37,21 @@ static inline void batadv_mcast_mla_update(struct batadv_priv *bat_priv)return ; } +static inline int batadv_mcast_init (struct batadv_priv *bat_priv) +{ +return 0 ; +} +static inline void batadv_mcast_free (struct batadv_priv *bat_priv) {return ; } +static inline void batadv_mcast_purge_orig (struct batadv_orig_node *orig_node) +{ +return ; +} +#endif /* CONFIG_BATMAN_ADV_MCAST */ #endif /* _NET_BATMAN_ADV_MULTICAST_H_ */
originator.c +6 -0
@@ -29,6 +29,7 @@#include "bridge_loop_avoidance.h" #include "network-coding.h" #include "fragmentation.h" +#include "multicast.h" /* hash class keys */ static struct lock_class_key batadv_orig_hash_lock_class_key;
@@ -225,6 +226,8 @@ static void batadv_orig_node_free_rcu(struct rcu_head *rcu)spin_unlock_bh (&orig_node->neigh_list_lock); +batadv_mcast_purge_orig (orig_node); +/* Free nc_nodes */ batadv_nc_purge_orig (orig_node->bat_priv, orig_node,NULL );
@@ -342,6 +345,9 @@ struct batadv_orig_node *batadv_get_orig_node(struct batadv_priv *bat_priv, reset_time = jiffies -1 -msecs_to_jiffies (BATADV_RESET_PROTECTION_MS ); orig_node->bcast_seqno_reset = reset_time; orig_node->batman_seqno_reset = reset_time; +#ifdef CONFIG_BATMAN_ADV_MCAST + orig_node->mcast_flags =BATADV_UNINIT_FLAGS ; +#endif atomic_set (&orig_node->bond_candidates,0 );
packet.h +2 -0
@@ -145,6 +145,7 @@ enum batadv_bla_claimframe {* @BATADV_TVLV_NC: network coding tvlv * @BATADV_TVLV_TT: translation table tvlv * @BATADV_TVLV_ROAM: roaming advertisement tvlv +* @BATADV_TVLV_MCAST: multicast capability tvlv */ enum batadv_tvlv_type {BATADV_TVLV_GW =0x01 ,
@@ -152,6 +153,7 @@ enum batadv_tvlv_type {BATADV_TVLV_NC =0x03 ,BATADV_TVLV_TT =0x04 ,BATADV_TVLV_ROAM =0x05 , + BATADV_TVLV_MCAST = 0x06, };/* the destination hardware field in the ARP frame is used to
soft-interface.c +4 -0
@@ -658,6 +658,10 @@ static int batadv_softif_init_late(struct net_device *dev)#ifdef CONFIG_BATMAN_ADV_DAT atomic_set (&bat_priv->distributed_arp_table,1 );#endif +#ifdef CONFIG_BATMAN_ADV_MCAST + bat_priv->mcast.flags =BATADV_UNINIT_FLAGS ; +atomic_set (&bat_priv->mcast.num_disabled,0 ); +#endif atomic_set (&bat_priv->gw_mode,BATADV_GW_MODE_OFF );atomic_set (&bat_priv->gw_sel_class,20 );atomic_set (&bat_priv->gw.bandwidth_down,100 );
types.h +11 -0
@@ -144,6 +144,7 @@ struct batadv_orig_node_vlan {* @last_seen: time when last packet from this node was received * @bcast_seqno_reset: time when the broadcast seqno window was reset * @batman_seqno_reset: time when the batman seqno window was reset +* @mcast_flags: multicast flags announced by the orig node * @capabilities: announced capabilities of this originator * @last_ttvn: last seen translation table version number * @tt_buff: last tt changeset this node received from the orig node
@@ -194,6 +195,9 @@ struct batadv_orig_node {unsigned long last_seen;unsigned long bcast_seqno_reset;unsigned long batman_seqno_reset; +#ifdef CONFIG_BATMAN_ADV_MCAST +int mcast_flags; +#endif uint8_t capabilities;atomic_t last_ttvn;unsigned char *tt_buff;
@@ -236,10 +240,13 @@ struct batadv_orig_node {* enum batadv_orig_capabilities - orig node capabilities * @BATADV_ORIG_CAPA_HAS_DAT: orig node has distributed arp table enabled * @BATADV_ORIG_CAPA_HAS_NC: orig node has network coding enabled +* @BATADV_ORIG_CAPA_HAS_MCAST: orig node has some multicast capability +* (= orig node announces a tvlv of type BATADV_TVLV_MCAST) */ enum batadv_orig_capabilities {BATADV_ORIG_CAPA_HAS_DAT =BIT (1 ),BATADV_ORIG_CAPA_HAS_NC =BIT (2 ), +BATADV_ORIG_CAPA_HAS_MCAST =BIT (3 ), };/**
@@ -541,9 +548,13 @@ struct batadv_priv_dat {/** * struct batadv_priv_mcast - per mesh interface mcast data * @mla_list: list of multicast addresses we are currently announcing via TT +* @flags: the flags we have last sent in our mcast tvlv +* @num_disabled: number of nodes that have no mcast tvlv */ struct batadv_priv_mcast {struct hlist_head mla_list; +int flags; +atomic_t num_disabled; };#endif
Signature · 1 line
1.7.10.4
PATCH v8 3/5 batman-adv: Modified forwarding behaviour for multicast packets
In reply to Linus LüssingWith this patch a multicast packet is not always simply flooded anymore, the bevahiour for the following cases is changed to reduce unnecessary overhead:
If all nodes within the horizon of a certain node have signalized multicast listener announcement capability then an IPv6 multicast packet with a destination of IPv6 link-local scope (excluding ff02::1) coming from the upstream of this node...
* ...is dropped if there is no according multicast listener in the translation table,
* ...is forwarded via unicast if there is a single node with interested multicast listeners
* ...and otherwise still gets flooded.
--- multicast.c | 102 ++++++++++++++++++++++++++++++++++++++++++++++++++ multicast.h | 23 ++++++++++++ soft-interface.c | 24 ++++++++++-- sysfs-class-net-mesh | 9 +++++ sysfs.c | 6 +++ translation-table.c | 91 ++++++++++++++++++++++++++++++++++---------- translation-table.h | 2 + types.h | 5 +++ 8 files changed, 238 insertions(+), 24 deletions(-)
multicast.c +102 -0
@@ -21,6 +21,7 @@#include "originator.h" #include "hard-interface.h" #include "translation-table.h" +#include "multicast.h" /** * batadv_mcast_mla_softif_get - get softif multicast listeners
@@ -265,6 +266,107 @@ out: }/** +* batadv_mcast_forw_mode_check_ipv6 - check for optimized forwarding potential +* @skb: the IPv6 packet to check +* @bat_priv: the bat priv with all the soft interface information +* +* Check whether the given IPv6 packet has the potential to +* be forwarded with a mode more optimal than classic flooding. +* +* If so then return 0. Otherwise -EINVAL is returned or -ENOMEM if we are +* out of memory. +*/ +static int batadv_mcast_forw_mode_check_ipv6 (struct sk_buff *skb, +struct batadv_priv *bat_priv) +{ +struct ipv6hdr *ip6hdr; + +/* We might fail due to out-of-memory -> drop it */ +if (!pskb_may_pull (skb,sizeof (struct ethhdr ) +sizeof (*ip6hdr))) +return -ENOMEM ; + + ip6hdr =ipv6_hdr (skb); + +/* TODO: Implement Multicast Router Discovery (RFC4286), +* then allow scope > link local, too +*/ +if (IPV6_ADDR_MC_SCOPE (&ip6hdr->daddr) != +IPV6_ADDR_SCOPE_LINKLOCAL ) +return -EINVAL ; + +/* With one bridge involved, we cannot be certain about +* link-local-all-nodes multicast listener announcements anymore +* (see RFC4541, section 3, paragraph 3) +*/ +if (ipv6_addr_is_ll_all_nodes (&ip6hdr->daddr)) +return -EINVAL ; + +return 0 ; +} + +/** +* batadv_mcast_forw_mode_check - check for optimized forwarding potential +* @skb: the multicast frame to check +* @bat_priv: the bat priv with all the soft interface information +* +* Check whether the given multicast ethernet frame has the potential to +* be forwarded with a mode more optimal than classic flooding. +* +* If so then return 0. Otherwise -EINVAL is returned or -ENOMEM if we are +* out of memory. +*/ +static int batadv_mcast_forw_mode_check (struct sk_buff *skb, +struct batadv_priv *bat_priv) +{ +struct ethhdr *ethhdr = (struct ethhdr *)(skb->data); + +if (!atomic_read (&bat_priv->multicast_mode)) +return -EINVAL ; + +if (atomic_read (&bat_priv->mcast.num_disabled)) +return -EINVAL ; + +switch (ntohs (ethhdr->h_proto)) { +case ETH_P_IPV6 : +return batadv_mcast_forw_mode_check_ipv6 (skb, bat_priv); +default : +return -EINVAL ; + } +} + +/** +* batadv_mcast_forw_mode - check on how to forward a multicast packet +* @skb: The multicast packet to check +* @bat_priv: the bat priv with all the soft interface information +* +* Return the forwarding mode as enum batadv_forw_mode. +*/ +enum batadv_forw_mode +batadv_mcast_forw_mode (struct sk_buff *skb,struct batadv_priv *bat_priv) +{ +struct ethhdr *ethhdr = (struct ethhdr *)(skb->data); +int ret; + + ret =batadv_mcast_forw_mode_check (skb, bat_priv); +if (ret == -ENOMEM ) +return BATADV_FORW_NONE ; +else if (ret <0 ) +return BATADV_FORW_ALL ; + + ret =batadv_tt_global_hash_count (bat_priv, ethhdr->h_dest, +BATADV_NO_FLAGS ); + +switch (ret) { +case 0 : +return BATADV_FORW_NONE ; +case 1 : +return BATADV_FORW_SINGLE ; +default : +return BATADV_FORW_ALL ; + } +} + +/** * batadv_mcast_counter_update - update the counter of a flag * @flag: the flag we want to update counters for * @flag_counter: the counter we might update
multicast.h +23 -0
@@ -20,10 +20,27 @@#ifndef _NET_BATMAN_ADV_MULTICAST_H_#define _NET_BATMAN_ADV_MULTICAST_H_ +/** +* batadv_forw_mode - the way a packet should be forwarded as +* @BATADV_FORW_ALL: forward the packet to all nodes +* (currently via classic flooding) +* @BATADV_FORW_SINGLE: forward the packet to a single node +* (currently via the BATMAN_IV unicast routing protocol) +* @BATADV_FORW_NONE: don't forward, drop it +*/ +enum batadv_forw_mode { +BATADV_FORW_ALL , +BATADV_FORW_SINGLE , +BATADV_FORW_NONE , +}; +#ifdef CONFIG_BATMAN_ADV_MCAST void batadv_mcast_mla_update (struct batadv_priv *bat_priv); +enum batadv_forw_mode +batadv_mcast_forw_mode (struct sk_buff *skb,struct batadv_priv *bat_priv); +int batadv_mcast_init (struct batadv_priv *bat_priv);void batadv_mcast_free (struct batadv_priv *bat_priv);
@@ -37,6 +54,12 @@ static inline void batadv_mcast_mla_update(struct batadv_priv *bat_priv)return ; } +static inline enum batadv_forw_mode +batadv_mcast_forw_mode (struct sk_buff *skb,struct batadv_priv *bat_priv) +{ +return BATADV_FORW_ALL ; +} +static inline int batadv_mcast_init (struct batadv_priv *bat_priv) {return 0 ;
soft-interface.c +20 -4
@@ -34,6 +34,7 @@#include <linux/ethtool.h> #include <linux/etherdevice.h> #include <linux/if_vlan.h> +#include "multicast.h" #include "bridge_loop_avoidance.h" #include "network-coding.h"
@@ -169,6 +170,8 @@ static int batadv_interface_tx(struct sk_buff *skb,bool do_bcast = false;unsigned short vid;uint32_t seqno; +enum batadv_forw_mode mode; +bool forw_to_gw = false;if (atomic_read (&bat_priv->mesh_state) !=BATADV_MESH_ACTIVE ) goto dropped;
@@ -229,17 +232,29 @@ static int batadv_interface_tx(struct sk_buff *skb,* via unicast to their gateway */ ret =batadv_gw_is_dhcp_target (skb, &header_len); -if (ret) +if (ret) { do_bcast = false; + forw_to_gw = true; + }break ;case BATADV_GW_MODE_OFF :default :break ; } -/* reminder: ethhdr might have become unusable from here on -* (batadv_gw_is_dhcp_target() might have reallocated skb data) +/* skb->data might have been reallocated by +* batadv_gw_is_dhcp_target() */ + ethhdr = (struct ethhdr *)skb->data; + +if (do_bcast && !is_broadcast_ether_addr (ethhdr->h_dest)) { + mode =batadv_mcast_forw_mode (skb, bat_priv); +if (mode ==BATADV_FORW_NONE ) + goto dropped; + +if (mode ==BATADV_FORW_SINGLE ) + do_bcast = false; + } }batadv_skb_set_priority (skb,0 );
@@ -298,7 +313,7 @@ static int batadv_interface_tx(struct sk_buff *skb,batadv_dat_snoop_outgoing_arp_reply (bat_priv, skb); -if (is_multicast_ether_addr (ethhdr->h_dest)) +if (forw_to_gw) ret =batadv_send_skb_via_gw (bat_priv, skb, vid);else ret =batadv_send_skb_via_tt (bat_priv, skb, vid);
@@ -660,6 +675,7 @@ static int batadv_softif_init_late(struct net_device *dev)#endif #ifdef CONFIG_BATMAN_ADV_MCAST bat_priv->mcast.flags =BATADV_UNINIT_FLAGS ; +atomic_set (&bat_priv->multicast_mode,1 );atomic_set (&bat_priv->mcast.num_disabled,0 );#endif atomic_set (&bat_priv->gw_mode,BATADV_GW_MODE_OFF );
sysfs-class-net-mesh +9 -0
@@ -68,6 +68,15 @@ Description: Defines the penalty which will be applied to an originator message's tq-field on every hop. +What: /sys/class/net/<mesh_iface>/mesh/multicast_mode +Date: June 2013 +Contact: Linus Lüssing <[email protected]> +Description: + Indicates whether multicast optimizations are enabled + or disabled. If set to zero then all nodes in the + mesh are going to use classic flooding for any + multicast packet with no optimizations. + What: /sys/class/net/<mesh_iface>/mesh/network_coding Date: Nov 2012 Contact: Martin Hundeboll <[email protected]>
sysfs.c +6 -0
@@ -464,6 +464,9 @@ BATADV_ATTR_SIF_UINT(gw_sel_class, S_IRUGO | S_IWUSR, 1, BATADV_TQ_MAX_VALUE, batadv_post_gw_deselect); static BATADV_ATTR(gw_bandwidth, S_IRUGO | S_IWUSR, batadv_show_gw_bwidth, batadv_store_gw_bwidth); +#ifdef CONFIG_BATMAN_ADV_MCAST +BATADV_ATTR_SIF_BOOL (multicast_mode,S_IRUGO |S_IWUSR ,NULL ); +#endif #ifdef CONFIG_BATMAN_ADV_DEBUG BATADV_ATTR_SIF_UINT (log_level,S_IRUGO |S_IWUSR ,0 ,BATADV_DBG_ALL ,NULL );#endif
@@ -481,6 +484,9 @@ static struct batadv_attribute *batadv_mesh_attrs[] = {#ifdef CONFIG_BATMAN_ADV_DAT &batadv_attr_distributed_arp_table,#endif +#ifdef CONFIG_BATMAN_ADV_MCAST + &batadv_attr_multicast_mode, +#endif &batadv_attr_fragmentation, &batadv_attr_routing_algo, &batadv_attr_gw_mode,
translation-table.c +71 -20
149 lines not on this page · raw message
translation-table.h +2 -0
@@ -31,6 +31,8 @@ int batadv_tt_global_seq_print_text(struct seq_file *seq, void *offset);void batadv_tt_global_del_orig (struct batadv_priv *bat_priv,struct batadv_orig_node *orig_node,int32_t match_vid,const char *message); +int batadv_tt_global_hash_count (struct batadv_priv *bat_priv, +const uint8_t *addr,unsigned short vid); struct batadv_orig_node *batadv_transtable_search(struct batadv_priv *bat_priv, const uint8_t *src, const uint8_t *addr,
types.h +5 -0
@@ -669,6 +669,9 @@ struct batadv_priv {#ifdef CONFIG_BATMAN_ADV_DAT atomic_t distributed_arp_table;#endif +#ifdef CONFIG_BATMAN_ADV_MCAST +atomic_t multicast_mode; +#endif atomic_t gw_mode;atomic_t gw_sel_class;atomic_t orig_interval;
@@ -830,12 +833,14 @@ struct batadv_tt_local_entry {* struct batadv_tt_global_entry - translation table global entry data * @common: general translation table data * @orig_list: list of orig nodes announcing this non-mesh client +* @orig_list_count: number of items in the orig_list * @list_lock: lock protecting orig_list * @roam_at: time at which TT_GLOBAL_ROAM was set */ struct batadv_tt_global_entry {struct batadv_tt_common_entry common;struct hlist_head orig_list; +atomic_t orig_list_count;spinlock_t list_lock;/* protects orig_list */ unsigned long roam_at; };
Signature · 1 line
1.7.10.4
Re: [B.A.T.M.A.N.] [PATCHv8 3/5] batman-adv: Modified forwarding behaviour for multicast packets
Hey Linus,
I'm currently playing a little with this patchset ...
Quoted 11 lines · Linus Lüssing
[...]
types.h +3
-0+ count =atomic_read (&tt_global_entry->orig_list_count); +atomic_inc (&tt_global->orig_list_count); +atomic_set (&tt_global_entry->orig_list_count,0 );@@ -830,12 +833,14 @@ struct batadv_tt_local_entry {* struct batadv_tt_global_entry - translation table global entry data * @common: general translation table data * @orig_list: list of orig nodes announcing this non-mesh client
types.h struct batadv_tt_local_entry { · line 845
Quoted 10 lines
types.h +2
-0+* @orig_list_count: number of items in the orig_list * @list_lock: lock protecting orig_list * @roam_at: time at which TT_GLOBAL_ROAM was set */ struct batadv_tt_global_entry {struct batadv_tt_common_entry common;struct hlist_head orig_list; +atomic_t orig_list_count;spinlock_t list_lock;/* protects orig_list */ unsigned long roam_at;
You never decrease this orig_list_count, do you? But actually you should when a node leaves the group. What I've tried is:
Node 1 pings a multicast address
-> no group member, nothing is sent
Node 2 is added to the group
-> multicast is now sent as unicast
Node 3 is added to the group
-> multicast is now sent as broadcast
Node 2 is removed from the group
-> multicast is still sent as broadcast (should be unicast!)
Node 3 is removed from the group
-> nothing is sent (as to be expected).
Could you please check the removal case?
Thanks,
Simon
Re: [B.A.T.M.A.N.] [PATCHv8 3/5] batman-adv: Modified forwarding behaviour for multicast packets
Quoted 41 lines · Simon Wunderlich
Hey Linus,
I'm currently playing a little with this patchset ...
Quoted 11 lines · Linus Lüssing
[...]
types.h +3
-0+ count =atomic_read (&tt_global_entry->orig_list_count); +atomic_inc (&tt_global->orig_list_count); +atomic_set (&tt_global_entry->orig_list_count,0 );@@ -830,12 +833,14 @@ struct batadv_tt_local_entry {* struct batadv_tt_global_entry - translation table global entry data * @common: general translation table data * @orig_list: list of orig nodes announcing this non-mesh client types.h struct batadv_tt_local_entry { · line 845
Quoted 10 lines
types.h +2
-0+* @orig_list_count: number of items in the orig_list * @list_lock: lock protecting orig_list * @roam_at: time at which TT_GLOBAL_ROAM was set */ struct batadv_tt_global_entry {struct batadv_tt_common_entry common;struct hlist_head orig_list; +atomic_t orig_list_count;spinlock_t list_lock;/* protects orig_list */ unsigned long roam_at;You never decrease this
orig_list_count, do you? But actually you should when a node leaves the group. What I've tried is:Node 1 pings a multicast address
-> no group member, nothing is sent
Node 2 is added to the group
-> multicast is now sent as unicast
Node 3 is added to the group
-> multicast is now sent as broadcast
Node 2 is removed from the group
-> multicast is still sent as broadcast (should be unicast!)
Node 3 is removed from the group
-> nothing is sent (as to be expected).
Quoted 4 lines
Could you please check the removal case?
Thanks,
Simon
Hrm, stupid regression introduced with v8 while rebasing... Sorry and thanks for spotting it! Going to send v9 in a minute.
PATCH v8 4/5 batman-adv: Add IPv4 link-local/IPv6-ll-all-nodes multicast support
In reply to Linus LüssingWith this patch a node may additionally perform the dropping or unicasting behaviour for a link-local IPv4 and link-local-all-nodes IPv6 multicast packet, too.
The extra counter and BATADV_MCAST_WANT_ALL_UNSNOOPABLES flag is needed because with a future bridge snooping support integration a node with a bridge on top of its soft interface is not able to reliably detect its multicast listeners for IPv4 link-local and the IPv6 link-local-all-nodes addresses anymore (see RFC4541, section 2.1.2.2 and section 3).
Even though this new flag does make "no difference" now, it'll ensure a seamless integration of multicast bridge support without needing to break compatibility later.
Also note, that even with multicast bridge support it will need only one node with a bridge to disable optimizations for link-local IPv4 and IPv6-link-local-all-nodes multicast, resulting in flooding all these packets again. So the 224.0.0.x address range and the ff02::1 address will never be a safe choice for multicast streaming etc. if you do not control every node.
--- main.h | 1 + multicast.c | 49 ++++++++++++++++++++++++++++++++++++++++++++++++- packet.h | 9 +++++++++ soft-interface.c | 1 + types.h | 2 ++ 5 files changed, 61 insertions(+), 1 deletion(-)
main.h +1 -0
@@ -166,6 +166,7 @@ enum batadv_uev_type {#include <linux/slab.h> #include <net/sock.h> /* struct sock */ #include <net/addrconf.h> /* ipv6 address stuff */ +#include <linux/ip.h> #include <net/rtnetlink.h> #include <linux/jiffies.h> #include <linux/seq_file.h>
multicast.c +48 -1
77 lines not on this page · raw message
packet.h +9 -0
@@ -91,6 +91,15 @@ enum batadv_icmp_packettype { BATADV_PARAMETER_PROBLEM = 12, }; +/** +* enum batadv_mcast_flags - flags for multicast capabilities and settings +* @BATADV_MCAST_WANT_ALL_UNSNOOPABLES: we want all packets destined for +* 224.0.0.0/24 or ff02::1 +*/ +enum batadv_mcast_flags { +BATADV_MCAST_WANT_ALL_UNSNOOPABLES =BIT (0 ), +}; +/* tt data subtypes */ #define BATADV_TT_DATA_TYPE_MASK 0x0F
soft-interface.c +1 -0
@@ -677,6 +677,7 @@ static int batadv_softif_init_late(struct net_device *dev) bat_priv->mcast.flags =BATADV_UNINIT_FLAGS ;atomic_set (&bat_priv->multicast_mode,1 );atomic_set (&bat_priv->mcast.num_disabled,0 ); +atomic_set (&bat_priv->mcast.num_want_all_unsnoopables,0 );#endif atomic_set (&bat_priv->gw_mode,BATADV_GW_MODE_OFF );atomic_set (&bat_priv->gw_sel_class,20 );
types.h +2 -0
@@ -550,11 +550,13 @@ struct batadv_priv_dat {* @mla_list: list of multicast addresses we are currently announcing via TT * @flags: the flags we have last sent in our mcast tvlv * @num_disabled: number of nodes that have no mcast tvlv +* @num_want_all_unsnoopables: number of nodes wanting unsnoopable IP traffic */ struct batadv_priv_mcast {struct hlist_head mla_list;int flags;atomic_t num_disabled; +atomic_t num_want_all_unsnoopables; };#endif
Signature · 1 line
1.7.10.4
PATCH v8 5/5 batman-adv: Send multicast packets to nodes with a WANT_ALL flag
In reply to Linus LüssingWith this patch a node sends IPv4 multicast packets to nodes which have a BATADV_MCAST_WANT_ALL_IPV4 flag set and IPv6 multicast packets to nodes which have a BATADV_MCAST_WANT_ALL_IPV6 flag set, too.
Why is this needed? There are scenarios involving bridges where multicast report snooping and multicast TT announcements are not sufficient, which would lead to packet loss for some nodes otherwise:
MLDv1 and IGMPv1/IGMPv2 have a suppression mechanism
for multicast listener reports. When we have an MLDv1/IGMPv1/IGMPv2 querier behind a bridge then our snooping bridge is potentially not going to see any reports even though listeners exist because according to RFC4541 such reports are only forwarded to multicast routers:
-----------------------------------------------------------
---------------
{Querier}---|Snoop. Switch|----{Listener}
---------------
\ ^
-------
| br0 | < ???
-------
\
_-~---~_
_-~/ ~-_
~ batman-adv \-----{Sender}
\~_ cloud ~/
-~~__-__-~_/I) MLDv1 Query: {Querier} -> flooded
II) MLDv1 Report: {Listener} -> {Querier}-> br0 cannot detect the {Listener}
=> Packets from {Sender} need to be forwarded to all
detected listeners and MLDv1/IGMPv1/IGMPv2 queriers.
-----------------------------------------------------------
Note that we do not need to explicitly forward to MLDv2/IGMPv3 queriers, because these protocols have no report suppression: A bridge has no trouble detecting MLDv2/IGMPv3 listeners.
Even though we do not support bridges yet we need to provide the according infrastructure already to not break compatibility later.
--- main.c | 7 ++ multicast.c | 194 +++++++++++++++++++++++++++++++++++++++++++++++++++++- multicast.h | 15 ++++- packet.h | 4 ++ send.c | 23 +++++++ send.h | 3 + soft-interface.c | 9 ++- types.h | 16 +++++ 8 files changed, 267 insertions(+), 4 deletions(-)
main.c +7 -0
@@ -112,6 +112,9 @@ int batadv_mesh_init(struct net_device *soft_iface)spin_lock_init (&bat_priv->tt.last_changeset_lock);spin_lock_init (&bat_priv->tt.commit_lock);spin_lock_init (&bat_priv->gw.list_lock); +#ifdef CONFIG_BATMAN_ADV_MCAST +spin_lock_init (&bat_priv->mcast.want_lists_lock); +#endif spin_lock_init (&bat_priv->tvlv.container_list_lock);spin_lock_init (&bat_priv->tvlv.handler_list_lock);spin_lock_init (&bat_priv->softif_vlan_list_lock);
@@ -119,6 +122,10 @@ int batadv_mesh_init(struct net_device *soft_iface)INIT_HLIST_HEAD (&bat_priv->forw_bat_list);INIT_HLIST_HEAD (&bat_priv->forw_bcast_list);INIT_HLIST_HEAD (&bat_priv->gw.list); +#ifdef CONFIG_BATMAN_ADV_MCAST +INIT_HLIST_HEAD (&bat_priv->mcast.want_all_ipv4_list); +INIT_HLIST_HEAD (&bat_priv->mcast.want_all_ipv6_list); +#endif INIT_LIST_HEAD (&bat_priv->tt.changes_list);INIT_LIST_HEAD (&bat_priv->tt.req_list);INIT_LIST_HEAD (&bat_priv->tt.roam_list);
multicast.c +193 -1
235 lines not on this page · raw message
multicast.h +13 -2
@@ -39,7 +39,8 @@ enum batadv_forw_mode {void batadv_mcast_mla_update (struct batadv_priv *bat_priv);enum batadv_forw_mode -batadv_mcast_forw_mode (struct sk_buff *skb,struct batadv_priv *bat_priv); +batadv_mcast_forw_mode (struct sk_buff *skb,struct batadv_priv *bat_priv, +struct hlist_head **want_all_list);int batadv_mcast_init (struct batadv_priv *bat_priv);
@@ -47,6 +48,9 @@ void batadv_mcast_free(struct batadv_priv *bat_priv);void batadv_mcast_purge_orig (struct batadv_orig_node *orig_node); +struct batadv_orig_node * +batadv_mcast_want_all_node_get (struct hlist_head *want_all_list, +struct batadv_priv *bat_priv);#else static inline void batadv_mcast_mla_update (struct batadv_priv *bat_priv)
@@ -55,7 +59,8 @@ static inline void batadv_mcast_mla_update(struct batadv_priv *bat_priv) }static inline enum batadv_forw_mode -batadv_mcast_forw_mode (struct sk_buff *skb,struct batadv_priv *bat_priv) +batadv_mcast_forw_mode (struct sk_buff *skb,struct batadv_priv *bat_priv, +struct hlist_head **want_all_list) {return BATADV_FORW_ALL ; }
@@ -75,6 +80,12 @@ static inline void batadv_mcast_purge_orig(struct batadv_orig_node *orig_node)return ; } +static inline struct batadv_orig_node * +batadv_mcast_want_all_node_get (struct hlist_head *want_all_list, +struct batadv_priv *bat_priv) +{ +return NULL ; +}#endif /* CONFIG_BATMAN_ADV_MCAST */ #endif /* _NET_BATMAN_ADV_MULTICAST_H_ */
packet.h +4 -0
@@ -95,9 +95,13 @@ enum batadv_icmp_packettype {* enum batadv_mcast_flags - flags for multicast capabilities and settings * @BATADV_MCAST_WANT_ALL_UNSNOOPABLES: we want all packets destined for * 224.0.0.0/24 or ff02::1 +* @BATADV_MCAST_WANT_ALL_IPV4: we want all IPv4 multicast packets +* @BATADV_MCAST_WANT_ALL_IPV6: we want all IPv6 multicast packets */ enum batadv_mcast_flags {BATADV_MCAST_WANT_ALL_UNSNOOPABLES =BIT (0 ), +BATADV_MCAST_WANT_ALL_IPV4 =BIT (1 ), +BATADV_MCAST_WANT_ALL_IPV6 =BIT (2 ), };/* tt data subtypes */
send.c +23 -0
@@ -29,6 +29,7 @@#include "originator.h" #include "network-coding.h" #include "fragmentation.h" +#include "multicast.h" static void batadv_send_outstanding_bcast_packet (struct work_struct *work);
@@ -353,6 +354,28 @@ int batadv_send_skb_via_gw(struct batadv_priv *bat_priv, struct sk_buff *skb, orig_node, vid); } +/** +* batadv_send_skb_via_mcast - send an skb to a node with a WANT_ALL flag +* @bat_priv: the bat priv with all the soft interface information +* @skb: payload to send +* @vid: the vid to be used to search the translation table +* @want_all_list: a list of originators with a WANT_ALL flag +* +* Get an originator node from the want_all_list. Wrap the given skb into a +* batman-adv unicast header and send this frame to this node. +*/ +int batadv_send_skb_via_mcast (struct batadv_priv *bat_priv, +struct sk_buff *skb,unsigned short vid, +struct hlist_head *want_all_list) + +{ +struct batadv_orig_node *orig_node; + + orig_node =batadv_mcast_want_all_node_get (want_all_list, bat_priv); +return batadv_send_skb_unicast (bat_priv, skb,BATADV_UNICAST ,0 , + orig_node, vid); +} +void batadv_schedule_bat_ogm (struct batadv_hard_iface *hard_iface) {struct batadv_priv *bat_priv =netdev_priv (hard_iface->soft_iface);
send.h +3 -0
@@ -43,6 +43,9 @@ int batadv_send_skb_via_tt_generic(struct batadv_priv *bat_priv, int packet_subtype, unsigned short vid);int batadv_send_skb_via_gw (struct batadv_priv *bat_priv,struct sk_buff *skb,unsigned short vid); +int batadv_send_skb_via_mcast (struct batadv_priv *bat_priv, +struct sk_buff *skb,unsigned short vid, +struct hlist_head *want_all_list);/** * batadv_send_skb_via_tt - send an skb via TT lookup
soft-interface.c +8 -1
@@ -159,6 +159,7 @@ static int batadv_interface_tx(struct sk_buff *skb,struct batadv_hard_iface *primary_if =NULL ;struct batadv_bcast_packet *bcast_packet;__be16 ethertype =htons (ETH_P_BATMAN ); +struct hlist_head *want_all_list =NULL ;static const uint8_t stp_addr[ETH_ALEN ] = {0x01 ,0x80 ,0xC2 ,0x00 ,0x00 ,0x00 };static const uint8_t ectp_addr[ETH_ALEN ] = {0xCF ,0x00 ,0x00 ,0x00 ,
@@ -248,7 +249,8 @@ static int batadv_interface_tx(struct sk_buff *skb, ethhdr = (struct ethhdr *)skb->data;if (do_bcast && !is_broadcast_ether_addr (ethhdr->h_dest)) { - mode =batadv_mcast_forw_mode (skb, bat_priv); + mode =batadv_mcast_forw_mode (skb, bat_priv, + &want_all_list);if (mode ==BATADV_FORW_NONE ) goto dropped;
@@ -315,6 +317,9 @@ static int batadv_interface_tx(struct sk_buff *skb,if (forw_to_gw) ret =batadv_send_skb_via_gw (bat_priv, skb, vid); +else if (want_all_list) + ret =batadv_send_skb_via_mcast (bat_priv, skb, vid, + want_all_list);else ret =batadv_send_skb_via_tt (bat_priv, skb, vid);
@@ -678,6 +683,8 @@ static int batadv_softif_init_late(struct net_device *dev)atomic_set (&bat_priv->multicast_mode,1 );atomic_set (&bat_priv->mcast.num_disabled,0 );atomic_set (&bat_priv->mcast.num_want_all_unsnoopables,0 ); +atomic_set (&bat_priv->mcast.num_want_all_ipv4,0 ); +atomic_set (&bat_priv->mcast.num_want_all_ipv6,0 );#endif atomic_set (&bat_priv->gw_mode,BATADV_GW_MODE_OFF );atomic_set (&bat_priv->gw_sel_class,20 );
types.h +16 -0
@@ -145,6 +145,8 @@ struct batadv_orig_node_vlan {* @bcast_seqno_reset: time when the broadcast seqno window was reset * @batman_seqno_reset: time when the batman seqno window was reset * @mcast_flags: multicast flags announced by the orig node +* @mcast_want_all_ipv4_node: a list node for the mcast.want_all_ipv4 list +* @mcast_want_all_ipv6_node: a list node for the mcast.want_all_ipv6 list * @capabilities: announced capabilities of this originator * @last_ttvn: last seen translation table version number * @tt_buff: last tt changeset this node received from the orig node
@@ -197,6 +199,8 @@ struct batadv_orig_node {unsigned long batman_seqno_reset;#ifdef CONFIG_BATMAN_ADV_MCAST int mcast_flags; +struct hlist_node mcast_want_all_ipv4_node; +struct hlist_node mcast_want_all_ipv6_node;#endif uint8_t capabilities;atomic_t last_ttvn;
@@ -548,15 +552,27 @@ struct batadv_priv_dat {/** * struct batadv_priv_mcast - per mesh interface mcast data * @mla_list: list of multicast addresses we are currently announcing via TT +* @want_all_ipv4_list: a list of orig_nodes wanting all IPv4 multicast traffic +* @want_all_ipv6_list: a list of orig_nodes wanting all IPv6 multicast traffic * @flags: the flags we have last sent in our mcast tvlv * @num_disabled: number of nodes that have no mcast tvlv * @num_want_all_unsnoopables: number of nodes wanting unsnoopable IP traffic +* @num_want_all_ipv4: counter for items in want_all_ipv4_list +* @num_want_all_ipv6: counter for items in want_all_ipv6_list +* @want_lists_lock: lock for protecting modifications to mcast want lists +* (traversals are rcu-locked) */ struct batadv_priv_mcast {struct hlist_head mla_list; +struct hlist_head want_all_ipv4_list; +struct hlist_head want_all_ipv6_list;int flags;atomic_t num_disabled;atomic_t num_want_all_unsnoopables; +atomic_t num_want_all_ipv4; +atomic_t num_want_all_ipv6; +/* protects want_all_ipv4_list & want_all_ipv6_list */ +spinlock_t want_lists_lock; };#endif
Signature · 1 line
1.7.10.4
Hey Linus,
I've tested the patchset, and it looks good from my testcases (testing multicast to IPv4 and IPv6 addresses). I've not tested the MLD stuff though, but from our discussions your implementation looks reasonable. Did you get to test it somehow?
From my perspective, if you fix the orig list stuff we could integrate your patchset. I'd like to ask others to review the patchset too. :)
Thanks,
Simon
Quoted 6 lines · Simon Wunderlich
Hey Linus,
I've tested the patchset, and it looks good from my testcases (testing multicast to IPv4 and IPv6 addresses). I've not tested the MLD stuff though, but from our discussions your implementation looks reasonable. Did you get to test it somehow?
Yes, I was testing it with the following patch from the branch linus/multicast-bridge:
"debug: batman-adv: manual querier flag sysfs switch" (e947548bf)
Quoted 6 lines
From my perspective, if you fix the orig list stuff we could integrate your patchset. I'd like to ask others to review the patchset too. :)
Thanks,
Simon