Skip to contentSkip to conversation

ARM: dts: Enable USB hub on Arndale

PATCH New Mark Brown 2 participants 3 messages Aug 14, 2013

Subsystems (2)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 ARM: dts: Enable USB hub on Arndale

From: Mark Brown <[email protected]>

The Arndale has a SMSC USB3503 connected in hardware only mode like a PHY, support it using the usb-nop-xceiv binding.

Note that due to a regrettable decision to use a regulator to represent the reset signal this uses a fixed voltage regulator to do that, there is a plan to use the reset controller binding once that is merged so it does not seem worthwhile to fix the usb-nop-xceiv driver at this point.

---

This doesn't 100% work right now since we don't yet have a solution to ensure that this gets started after the USB controller but those modifications are small (or can be done at runtime with module loading).

 arch/arm/boot/dts/exynos5250-arndale.dts | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
arch/arm/boot/dts/exynos5250-arndale.dts +18 -0
index 96d528d..e477e23 100644
@@ -539,4 +539,22 @@
 	rtc {
 		status = "okay";
 	};
+
+	usb_hub_bus {
+		compatible = "simple-bus";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		// SMSC USB3503 connected in hardware only mode as a PHY
+		usb_hub: usb_hub {
+			compatible = "smsc,usb3503a";
+
+			reset-gpios = <&gpx3 5 1>;
+			connect-gpios = <&gpd1 7 1>;
+		};
+	};
+
+	usb at 12110000 {
+		usb-phy = <&usb2_phy>;
+	};
 };
Signature · 1 line
1.8.4.rc2
#1 lore raw

PATCH 1/1 ARM: dts: Enable USB hub on Arndale

Quoted 38 lines · Mark Brown

From: Mark Brown <[email protected]>

The Arndale has a SMSC USB3503 connected in hardware only mode like a PHY, support it using the usb-nop-xceiv binding.

Note that due to a regrettable decision to use a regulator to represent the reset signal this uses a fixed voltage regulator to do that, there is a plan to use the reset controller binding once that is merged so it does not seem worthwhile to fix the usb-nop-xceiv driver at this point.

---

This doesn't 100% work right now since we don't yet have a solution to ensure that this gets started after the USB controller but those modifications are small (or can be done at runtime with module loading).

 arch/arm/boot/dts/exynos5250-arndale.dts | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
arch/arm/boot/dts/exynos5250-arndale.dts +10 -0
index 96d528d..e477e23 100644
@@ -539,4 +539,22 @@
        rtc {
                status = "okay";
        };
+
+       usb_hub_bus {
+               compatible = "simple-bus";
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               // SMSC USB3503 connected in hardware only mode as a PHY
+               usb_hub: usb_hub {
+                       compatible = "smsc,usb3503a";
+

arch/arm/boot/dts/exynos5250-arndale.dts line 559

Quoted 10 lines
arch/arm/boot/dts/exynos5250-arndale.dts +8 -0
+                       reset-gpios = <&gpx3 5 1>;
+                       connect-gpios = <&gpd1 7 1>;
+               };
+       };
+
 
 
+       usb at 12110000 {
+               usb-phy = <&usb2_phy>;
+       };

ehci-s5p driver doesn't use 'usb-phy' property to find the PHY driver, hence this is not required.

Without this change,

Signature · 1 line
Tushar Behera
author
#2 lore raw

PATCH 1/1 ARM: dts: Enable USB hub on Arndale

Quoted 8 lines · Tushar Behera

arch/arm/boot/dts/exynos5250-arndale.dts line 559

Quoted 3 lines · Mark Brown
arch/arm/boot/dts/exynos5250-arndale.dts +3 -0
+       usb at 12110000 {
+               usb-phy = <&usb2_phy>;
+       };

ehci-s5p driver doesn't use 'usb-phy' property to find the PHY driver, hence this is not required.

I added that for documentation since it is actually what gets used - the
obvious way of handing this is for the hub to be treated like a PHY but
that doesn't work since we actually need the built in PHY to talk to the
hub. Though I did mean it to be a separate patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130814/ca31e70b/attachment.sig>