Skip to contentSkip to conversation

ARM: imx_v6_v7_defconfig: Remove CONFIG_USB_PHY selection

PATCH New Fabio Estevam 2 participants 3 messages Aug 14, 2013 – Aug 18, 2013

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH v2 1/2 ARM: imx_v6_v7_defconfig: Remove CONFIG_USB_PHY selection

From: Fabio Estevam <[email protected]>

Since commit 052a11d1 (usb: phy: make PHY driver selection possible by controller drivers), CONFIG_USB_PHY is selected via drivers/usb/phy/Kconfig, so there is no need to select it via defconfig anymore.

---
Changes since v1:
- Split it in two patches

 arch/arm/configs/imx_v6_v7_defconfig | 1 -
 1 file changed, 1 deletion(-)
arch/arm/configs/imx_v6_v7_defconfig +0 -1
index 5d488c2..402f282 100644
@@ -195,7 +195,6 @@ CONFIG_USB_EHCI_MXC=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_CHIPIDEA=y
 CONFIG_USB_CHIPIDEA_HOST=y
-CONFIG_USB_PHY=y
 CONFIG_NOP_USB_XCEIV=y
 CONFIG_USB_MXS_PHY=y
 CONFIG_MMC=y
Signature · 1 line
1.8.1.2
author reviewer
#1 lore raw

PATCH v2 2/2 ARM: mxs_defconfig: Remove CONFIG_USB_PHY selection

From: Fabio Estevam <[email protected]>

Since commit 052a11d1 (usb: phy: make PHY driver selection possible by controller drivers), CONFIG_USB_PHY is selected via drivers/usb/phy/Kconfig, so there is no need to select it via defconfig anymore.

---
Changes since v1:
- Split it in two patches

 arch/arm/configs/mxs_defconfig | 1 -
 1 file changed, 1 deletion(-)
arch/arm/configs/mxs_defconfig +0 -1
index 4555c02..a9fb093 100644
@@ -116,7 +116,6 @@ CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_CHIPIDEA=y
 CONFIG_USB_CHIPIDEA_HOST=y
-CONFIG_USB_PHY=y
 CONFIG_USB_MXS_PHY=y
 CONFIG_MMC=y
 CONFIG_MMC_UNSAFE_RESUME=y
Signature · 1 line
1.8.1.2
#2 lore raw

PATCH v2 1/2 ARM: imx_v6_v7_defconfig: Remove CONFIG_USB_PHY selection

In reply to Fabio Estevam
Quoted 5 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Since commit 052a11d1 (usb: phy: make PHY driver selection possible by controller drivers), CONFIG_USB_PHY is selected via drivers/usb/phy/Kconfig, so there is no need to select it via defconfig anymore.

Applying the patch on IMX tree will break the boot right away, because the prerequisite commit 052a11d1 is available on IMX tree and causes CONFIG_USB_PHY lost. So please do not send me such patches until the prerequisite ones hit mainline.

Also, I do not think the change is worth a patch, since it will go away when next time we run savedefconfig.

Shawn

Quoted 24 lines

---
Changes since v1:
- Split it in two patches

 arch/arm/configs/imx_v6_v7_defconfig | 1 -
 1 file changed, 1 deletion(-)
arch/arm/configs/imx_v6_v7_defconfig +0 -1
index 5d488c2..402f282 100644
@@ -195,7 +195,6 @@ CONFIG_USB_EHCI_MXC=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_CHIPIDEA=y
 CONFIG_USB_CHIPIDEA_HOST=y
-CONFIG_USB_PHY=y
 CONFIG_NOP_USB_XCEIV=y
 CONFIG_USB_MXS_PHY=y
 CONFIG_MMC=y
Signature · 1 line
1.8.1.2