arm: socfpga: Fix incorrect sdmmc clock name

PATCH New dinguyen at altera.com 4 participants 9 messages Aug 12, 2013 – Oct 8, 2013

Subsystems (2)

Common clk Arm/socfpga clock framework support

lore

Share & tools

lore

dinguyen at altera.com

author

2013-08-12 15:42 UTC #0 lore raw

PATCH 1/1 arm: socfpga: Fix incorrect sdmmc clock name

From: Dinh Nguyen <[email protected]>

The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".

Signed-off-by Dinh Nguyen <[email protected]>

Cc Mike Turquette <[email protected]>

CC Arnd Bergmann <[email protected]>

CC Olof Johansson <[email protected]>

Cc Pavel Machek <[email protected]>

Cc linux-arm-kernel at lists.infradead.org

---
 drivers/clk/socfpga/clk.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/clk/socfpga/clk.c +1 -1

index 5bb848c..81dd31a 100644
@@ -49,7 +49,7 @@
 #define SOCFPGA_L4_SP_CLK		"l4_sp_clk"
 #define SOCFPGA_NAND_CLK		"nand_clk"
 #define SOCFPGA_NAND_X_CLK		"nand_x_clk"
-#define SOCFPGA_MMC_CLK			"mmc_clk"
+#define SOCFPGA_MMC_CLK			"sdmmc_clk"
 #define SOCFPGA_DB_CLK			"gpio_db_clk"
 
 #define div_mask(width)	((1 << (width)) - 1)

Signature · 1 line

1.7.9.5

Olof Johansson

2013-08-14 05:48 UTC #1 lore raw

PATCH 1/1 arm: socfpga: Fix incorrect sdmmc clock name

Quoted 10 lines · dinguyen at altera.com

From: Dinh Nguyen <[email protected]>
The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".
Signed-off-by Dinh Nguyen <[email protected]>
Cc Mike Turquette <[email protected]>
CC Arnd Bergmann <[email protected]>
CC Olof Johansson <[email protected]>
Cc Pavel Machek <[email protected]>
Cc linux-arm-kernel at lists.infradead.org

Hi Dinh,

Do you want this applied in fixes for 3.11? If so, can you give me a oneliner on what the impact here is? mmc doesn't come up at all, or something more subtle?

-Olof

Dinh Nguyen

author

2013-08-14 14:57 UTC #2 lore raw

PATCH 1/1 arm: socfpga: Fix incorrect sdmmc clock name

Quoted 12 lines · Olof Johansson

Quoted 10 lines · dinguyen at altera.com
From: Dinh Nguyen <[email protected]>
The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".
Signed-off-by Dinh Nguyen <[email protected]>
Cc Mike Turquette <[email protected]>
CC Arnd Bergmann <[email protected]>
CC Olof Johansson <[email protected]>
Cc Pavel Machek <[email protected]>
Cc linux-arm-kernel at lists.infradead.org

Quoted 5 lines

Hi Dinh,
Do you want this applied in fixes for 3.11? If so, can you give me a oneliner on what the impact here is? mmc doesn't come up at all, or something more subtle?

Hi Olof,

No, this is go into 3.12 as I am still working on the bindings for SD/MMC.

The oneliner: "The SD/MMC driver was intermittently not coming up because it was not able to get the correct clock."

Thanks,
Dinh

Quoted 4 lines

-Olof

Mike Turquette

2013-10-07 20:12 UTC #3 lore raw

PATCH 1/1 arm: socfpga: Fix incorrect sdmmc clock name

Quoting Dinh Nguyen (2013-08-14 07:57:54)

Quoted 19 lines · Olof Johansson

Quoted 12 lines · dinguyen at altera.com
Quoted 10 lines
From: Dinh Nguyen <[email protected]>
The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".
Signed-off-by Dinh Nguyen <[email protected]>
Cc Mike Turquette <[email protected]>
CC Arnd Bergmann <[email protected]>
CC Olof Johansson <[email protected]>
Cc Pavel Machek <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Quoted 5 lines
Hi Dinh,
Do you want this applied in fixes for 3.11? If so, can you give me a oneliner on what the impact here is? mmc doesn't come up at all, or something more subtle?

Quoted 7 lines

Hi Olof,
No, this is go into 3.12 as I am still working on the bindings for SD/MMC.
The oneliner: "The SD/MMC driver was intermittently not coming up because it was not able to get the correct clock."

Olof, did you take this? If not I'll put it into my next batch of fixes for 3.12.

Regards,
Mike

Quoted 7 lines

Thanks,
Dinh
Quoted 4 lines
-Olof

Dinh Nguyen

author

2013-10-07 20:37 UTC #4 lore raw

PATCH 1/1 arm: socfpga: Fix incorrect sdmmc clock name

Hi Mike,

Quoted 22 lines · Mike Turquette

Quoting Dinh Nguyen (2013-08-14 07:57:54)
Quoted 21 lines · Olof Johansson
Quoted 12 lines · dinguyen at altera.com
Quoted 10 lines
From: Dinh Nguyen <[email protected]>
The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".
Signed-off-by Dinh Nguyen <[email protected]>
Cc Mike Turquette <[email protected]>
CC Arnd Bergmann <[email protected]>
CC Olof Johansson <[email protected]>
Cc Pavel Machek <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Quoted 5 lines
Hi Dinh,
Do you want this applied in fixes for 3.11? If so, can you give me a oneliner on what the impact here is? mmc doesn't come up at all, or something more subtle?
Hi Olof,

Quoted 8 lines

Quoted 5 lines
No, this is go into 3.12 as I am still working on the bindings for SD/MMC.
The oneliner: "The SD/MMC driver was intermittently not coming up because it was not able to get the correct clock."
Olof, did you take this? If not I'll put it into my next batch of fixes for 3.12.

No, Olof did not get a chance to pick this up for 3.12. I resent the patch with the updated commit message for 3.13:

http://lists.infradead.org/pipermail/linux-arm-kernel/2013-September/198824.html

Thanks,
Dinh

Quoted 12 lines

Regards,
Mike
Quoted 7 lines
Thanks,
Dinh
Quoted 4 lines
-Olof

Mike Turquette

2013-10-07 23:28 UTC #5 lore raw

PATCH 1/1 arm: socfpga: Fix incorrect sdmmc clock name

Quoting Dinh Nguyen (2013-10-07 13:37:29)

Quoted 31 lines

Hi Mike,
Quoted 28 lines · Mike Turquette
Quoting Dinh Nguyen (2013-08-14 07:57:54)
Quoted 26 lines · Olof Johansson
Quoted 12 lines · dinguyen at altera.com
Quoted 10 lines
From: Dinh Nguyen <[email protected]>
The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".
Signed-off-by Dinh Nguyen <[email protected]>
Cc Mike Turquette <[email protected]>
CC Arnd Bergmann <[email protected]>
CC Olof Johansson <[email protected]>
Cc Pavel Machek <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Quoted 5 lines
Hi Dinh,
Do you want this applied in fixes for 3.11? If so, can you give me a oneliner on what the impact here is? mmc doesn't come up at all, or something more subtle?
Hi Olof,
No, this is go into 3.12 as I am still working on the bindings for SD/MMC.
The oneliner: "The SD/MMC driver was intermittently not coming up because it was not able to get the correct clock."

Quoted 7 lines

Quoted 2 lines
Olof, did you take this? If not I'll put it into my next batch of fixes for 3.12.
No, Olof did not get a chance to pick this up for 3.12. I resent the patch with the updated commit message for 3.13:
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-September/198824.html

Thanks for the link. I've taken that version into clk-fixes for 3.12.

Regards,
Mike

Quoted 15 lines

Thanks,
Dinh
Quoted 12 lines
Regards,
Mike
Quoted 7 lines
Thanks,
Dinh
Quoted 4 lines
-Olof

Olof Johansson

2013-10-07 23:43 UTC #6 lore raw

PATCH 1/1 arm: socfpga: Fix incorrect sdmmc clock name

Quoted 35 lines · Mike Turquette

Quoting Dinh Nguyen (2013-10-07 13:37:29)
Quoted 34 lines
Hi Mike,
Quoted 30 lines · Mike Turquette
Quoting Dinh Nguyen (2013-08-14 07:57:54)
Quoted 19 lines · Olof Johansson
Quoted 12 lines · dinguyen at altera.com
Quoted 10 lines
From: Dinh Nguyen <[email protected]>
The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".
Signed-off-by Dinh Nguyen <[email protected]>
Cc Mike Turquette <[email protected]>
CC Arnd Bergmann <[email protected]>
CC Olof Johansson <[email protected]>
Cc Pavel Machek <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Quoted 5 lines
Hi Dinh,
Do you want this applied in fixes for 3.11? If so, can you give me a oneliner on what the impact here is? mmc doesn't come up at all, or something more subtle?
Quoted 7 lines
Hi Olof,
No, this is go into 3.12 as I am still working on the bindings for SD/MMC.
The oneliner: "The SD/MMC driver was intermittently not coming up because it was not able to get the correct clock."
Olof, did you take this? If not I'll put it into my next batch of fixes for 3.12.

Quoted 6 lines

Quoted 4 lines
No, Olof did not get a chance to pick this up for 3.12. I resent the patch with the updated commit message for 3.13:
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-September/198824.html
Thanks for the link. I've taken that version into clk-fixes for 3.12.

Thanks Mike, and sorry for dropping the ball Dinh. Next time feel free to remind me if it happens. A week is the normal grace period. :)

-Olof

Mike Turquette

2013-10-08 01:39 UTC #7 lore raw

PATCH 1/1 arm: socfpga: Fix incorrect sdmmc clock name

Quoting Olof Johansson (2013-10-07 16:43:14)

Quoted 39 lines · Mike Turquette

Quoted 38 lines
Quoting Dinh Nguyen (2013-10-07 13:37:29)
Quoted 37 lines
Hi Mike,
Quoted 22 lines · Mike Turquette
Quoting Dinh Nguyen (2013-08-14 07:57:54)
Quoted 21 lines · Olof Johansson
Quoted 12 lines · dinguyen at altera.com
Quoted 10 lines
From: Dinh Nguyen <[email protected]>
The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".
Signed-off-by Dinh Nguyen <[email protected]>
Cc Mike Turquette <[email protected]>
CC Arnd Bergmann <[email protected]>
CC Olof Johansson <[email protected]>
Cc Pavel Machek <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Quoted 5 lines
Hi Dinh,
Do you want this applied in fixes for 3.11? If so, can you give me a oneliner on what the impact here is? mmc doesn't come up at all, or something more subtle?
Hi Olof,
Quoted 8 lines
Quoted 5 lines
No, this is go into 3.12 as I am still working on the bindings for SD/MMC.
The oneliner: "The SD/MMC driver was intermittently not coming up because it was not able to get the correct clock."
Olof, did you take this? If not I'll put it into my next batch of fixes for 3.12.
No, Olof did not get a chance to pick this up for 3.12. I resent the patch with the updated commit message for 3.13:

Quoted 7 lines

Quoted 3 lines
Quoted 1 line
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-September/198824.html
Thanks for the link. I've taken that version into clk-fixes for 3.12.
Thanks Mike, and sorry for dropping the ball Dinh. Next time feel free to remind me if it happens. A week is the normal grace period. :)

No problem ;-)

Dinh,

I changed your $SUBJECT line to:

"clk: socfpga: Fix incorrect sdmmc clock name"

Just a simple s/arm/clk/

Regards,
Mike

Quoted 3 lines

-Olof

Dinh Nguyen

2013-10-08 02:40 UTC #8 lore raw

PATCH 1/1 arm: socfpga: Fix incorrect sdmmc clock name

Quoted 41 lines · Mike Turquette

Quoting Olof Johansson (2013-10-07 16:43:14)
Quoted 40 lines · Mike Turquette
Quoted 29 lines
Quoting Dinh Nguyen (2013-10-07 13:37:29)
Quoted 28 lines
Hi Mike,
Quoted 25 lines · Mike Turquette
Quoting Dinh Nguyen (2013-08-14 07:57:54)
Quoted 24 lines · Olof Johansson
Quoted 11 lines · dinguyen at altera.com
Quoted 10 lines
From: Dinh Nguyen <[email protected]>
The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".
Signed-off-by Dinh Nguyen <[email protected]>
Cc Mike Turquette <[email protected]>
CC Arnd Bergmann <[email protected]>
CC Olof Johansson <[email protected]>
Cc Pavel Machek <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Quoted 5 lines
Hi Dinh,
Do you want this applied in fixes for 3.11? If so, can you give me a oneliner on what the impact here is? mmc doesn't come up at all, or something more subtle?
Hi Olof,
No, this is go into 3.12 as I am still working on the bindings for SD/MMC.
The oneliner: "The SD/MMC driver was intermittently not coming up because it was not able to get the correct clock."
Quoted 7 lines
Quoted 6 lines
Quoted 2 lines
Olof, did you take this? If not I'll put it into my next batch of fixes for 3.12.
No, Olof did not get a chance to pick this up for 3.12. I resent the patch with the updated commit message for 3.13:
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-September/198824.html
Thanks for the link. I've taken that version into clk-fixes for 3.12.
Thanks Mike, and sorry for dropping the ball Dinh. Next time feel free to remind me if it happens. A week is the normal grace period. :)

No problem Olof! The patches to enable SDMMC is still floating out there so there wasn't a huge
hurry for 3.12.

Any chance you might take a look? I'll ping Chris Ball again tomorrow.

http://lists.infradead.org/pipermail/linux-arm-kernel/2013-September/198824.html

Thanks...

Quoted 9 lines

No problem ;-)
Dinh,
I changed your $SUBJECT line to:
"clk: socfpga: Fix incorrect sdmmc clock name"
Just a simple s/arm/clk/

Thanks Mike!

Dinh

Quoted 6 lines

Regards,
Mike
Quoted 2 lines
-Olof