ARM: fiq: Cast the first argument of flush_icache_range()

PATCH New Fabio Estevam 2 participants 3 messages Aug 16, 2013 – Aug 17, 2013 Arm (32-bit)

lore

Share & tools

lore

Fabio Estevam

author

2013-08-16 00:35 UTC #0 lore raw

PATCH 1/1 ARM: fiq: Cast the first argument of flush_icache_range()

From: Fabio Estevam <[email protected]>

Commit 2ba85e7af4 (ARM: Fix FIQ code on VIVT CPUs) causes the following build warning:

arch/arm/kernel/fiq.c: In function 'set_fiq_handler':
arch/arm/kernel/fiq.c:92:3: warning: passing argument 1 of 'cpu_cache.coherent_kern_range' makes integer from pointer without a cast [enabled by default] arch/arm/kernel/fiq.c:92:3: note: expected 'long unsigned int' but argument is of type 'void *'

Cast it as '(unsigned long)base' to avoid the warning.

Signed-off-by Fabio Estevam <[email protected]>

---
 arch/arm/kernel/fiq.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

arch/arm/kernel/fiq.c +2 -1

index fc79202..d6515b9 100644
@@ -89,7 +89,8 @@ void set_fiq_handler(void *start, unsigned int length)
 
 	memcpy(base + offset, start, length);
 	if (!cache_is_vipt_nonaliasing())
-		flush_icache_range(base + offset, offset + length);
+		flush_icache_range((unsigned long)base + offset, offset +
+				   length);
 	flush_icache_range(0xffff0000 + offset, 0xffff0000 + offset + length);
 }

Signature · 1 line

1.8.1.2

Olof Johansson

2013-08-17 04:24 UTC #1 lore raw

PATCH 1/1 ARM: fiq: Cast the first argument of flush_icache_range()

Quoted 5 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>
Commit 2ba85e7af4 (ARM: Fix FIQ code on VIVT CPUs) causes the following build warning:

Quoted 7 lines

arch/arm/kernel/fiq.c: In function 'set_fiq_handler':
arch/arm/kernel/fiq.c:92:3: warning: passing argument 1 of 'cpu_cache.coherent_kern_range' makes integer from pointer without a cast [enabled by default] arch/arm/kernel/fiq.c:92:3: note: expected 'long unsigned int' but argument is of type 'void *'
Cast it as '(unsigned long)base' to avoid the warning.
Signed-off-by Fabio Estevam <[email protected]>

Acked-by Olof Johansson <[email protected]>

This warning just showed up on mainline with the last arm fixes. Please send to the patch tracker.

-Olof

Fabio Estevam

author

2013-08-17 04:36 UTC #2 lore raw

PATCH 1/1 ARM: fiq: Cast the first argument of flush_icache_range()

Quoted 10 lines · Olof Johansson

Quoted 9 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Commit 2ba85e7af4 (ARM: Fix FIQ code on VIVT CPUs) causes the following build warning:
arch/arm/kernel/fiq.c: In function 'set_fiq_handler':
arch/arm/kernel/fiq.c:92:3: warning: passing argument 1 of 'cpu_cache.coherent_kern_range' makes integer from pointer without a cast [enabled by default] arch/arm/kernel/fiq.c:92:3: note: expected 'long unsigned int' but argument is of type 'void *'

Quoted 8 lines

Quoted 3 lines
Cast it as '(unsigned long)base' to avoid the warning.
Signed-off-by Fabio Estevam <[email protected]>
Acked-by Olof Johansson <[email protected]>
This warning just showed up on mainline with the last arm fixes. Please send to the patch tracker.

Yes, I have already sent it to the patch system:
http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=7819/1

Regards,

Fabio Estevam